summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLukas Slebodnik <lslebodn@redhat.com>2016-07-22 09:53:40 +0200
committerLukas Slebodnik <lslebodn@redhat.com>2016-07-22 13:05:31 +0200
commit6c82774653f37945bdd0a311eb1ecc289cac683d (patch)
treef93316777e3bab17bf9e15e645c09a8e6d99fa8d
parent35f29b17699c3d52f77857c530300318b14148f8 (diff)
downloadsssd-6c82774653f37945bdd0a311eb1ecc289cac683d.tar.gz
sssd-6c82774653f37945bdd0a311eb1ecc289cac683d.tar.xz
sssd-6c82774653f37945bdd0a311eb1ecc289cac683d.zip
SECRETS: Log message for failures with removing file
Type: Unchecked return value Reported by coverity Reviewed-by: Petr Čech <pcech@redhat.com>
-rw-r--r--src/responder/secrets/local.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/src/responder/secrets/local.c b/src/responder/secrets/local.c
index 620134ea6..2a85ac069 100644
--- a/src/responder/secrets/local.c
+++ b/src/responder/secrets/local.c
@@ -624,7 +624,13 @@ int generate_master_key(const char *filename, size_t size)
rsize = sss_atomic_io_s(fd, buf, size, false);
close(fd);
if (rsize != size) {
- unlink(filename);
+ ret = unlink(filename);
+ /* non-fatal failure */
+ if (ret != EOK) {
+ DEBUG(SSSDBG_MINOR_FAILURE,
+ "Failed to remove file: %s - %d [%s]!\n",
+ filename, ret, sss_strerror(ret));
+ }
return EFAULT;
}