diff options
| author | Lukas Slebodnik <lslebodn@redhat.com> | 2016-08-30 16:39:49 +0200 |
|---|---|---|
| committer | Lukas Slebodnik <lslebodn@redhat.com> | 2016-09-13 16:02:23 +0200 |
| commit | 6c335dee38da943796710b5e336472a10cf641f2 (patch) | |
| tree | b8e425d81aff544caee5e79c56bf425e1ab15c74 | |
| parent | d3348f49260998880bb7cd3b2fb72d562b1b7a64 (diff) | |
| download | sssd-6c335dee38da943796710b5e336472a10cf641f2.tar.gz sssd-6c335dee38da943796710b5e336472a10cf641f2.tar.xz sssd-6c335dee38da943796710b5e336472a10cf641f2.zip | |
SDAP: Fix settig paging attribute in sdap_get_generic_ext_send
We should set pagging flag in state and not in local
variable which is not read anywhere in the function.
Found by clang static analyzer.
Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
| -rw-r--r-- | src/providers/ldap/sdap_async.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/providers/ldap/sdap_async.c b/src/providers/ldap/sdap_async.c index 4195ba95d..e9ce2d5fd 100644 --- a/src/providers/ldap/sdap_async.c +++ b/src/providers/ldap/sdap_async.c @@ -1254,7 +1254,7 @@ sdap_get_generic_ext_send(TALLOC_CTX *memctx, */ if (scope == LDAP_SCOPE_BASE && (flags & SDAP_SRCH_FLG_PAGING)) { /* Disable paging */ - flags &= ~SDAP_SRCH_FLG_PAGING; + state->flags &= ~SDAP_SRCH_FLG_PAGING; DEBUG(SSSDBG_TRACE_FUNC, "WARNING: Disabling paging because scope is set to base.\n"); } @@ -1267,7 +1267,7 @@ sdap_get_generic_ext_send(TALLOC_CTX *memctx, serverctrls, NULL); if (control) { - flags |= SDAP_SRCH_FLG_PAGING; + state->flags |= SDAP_SRCH_FLG_PAGING; } /* ASQ */ @@ -1275,7 +1275,7 @@ sdap_get_generic_ext_send(TALLOC_CTX *memctx, serverctrls, NULL); if (control) { - flags |= SDAP_SRCH_FLG_PAGING; + state->flags |= SDAP_SRCH_FLG_PAGING; } for (state->nserverctrls=0; |