summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJakub Hrozek <jhrozek@redhat.com>2016-08-08 13:50:54 +0200
committerJakub Hrozek <jhrozek@redhat.com>2016-08-17 16:55:23 +0200
commit942b4ce6e60e88e4e31600655fad8980f3986f68 (patch)
treef4d8e23e7788f0d80e62de2e5f632d566066da1f
parentb3a22ee1d91aa4ed1544475be16ec2b7cf886180 (diff)
downloadsssd-942b4ce6e60e88e4e31600655fad8980f3986f68.tar.gz
sssd-942b4ce6e60e88e4e31600655fad8980f3986f68.tar.xz
sssd-942b4ce6e60e88e4e31600655fad8980f3986f68.zip
SECRETS: Use sss_atomic_read/write for better readability
sss_atomic_read_s and sss_atomic_write_s are macro-wrappers around sss_atomic_io_s but it's easier to follow the code with the read/write vairants used directly. Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com> Reviewed-by: Fabiano Fidêncio <fabiano@fidencio.org>
-rw-r--r--src/responder/secrets/local.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/responder/secrets/local.c b/src/responder/secrets/local.c
index 470aec0e1..17469249b 100644
--- a/src/responder/secrets/local.c
+++ b/src/responder/secrets/local.c
@@ -621,7 +621,7 @@ int generate_master_key(const char *filename, size_t size)
fd = open(filename, O_CREAT|O_EXCL|O_WRONLY, 0600);
if (fd == -1) return errno;
- rsize = sss_atomic_io_s(fd, buf, size, false);
+ rsize = sss_atomic_write_s(fd, buf, size);
close(fd);
if (rsize != size) {
ret = unlink(filename);
@@ -681,8 +681,8 @@ int local_secrets_provider_handle(struct sec_ctx *sctx,
}
if (ret) return EFAULT;
- size = sss_atomic_io_s(mfd, lctx->master_key.data,
- lctx->master_key.length, true);
+ size = sss_atomic_read_s(mfd, lctx->master_key.data,
+ lctx->master_key.length);
close(mfd);
if (size < 0 || size != lctx->master_key.length) return EIO;