sssd.git/src/util, branch prompting

UTIL: exit() the forked process if exec()-ing a child process fails

2016-05-19T11:56:57+00:00

When exec() fails, we should not attempt to continue, but just kill the
forked process. The patch adds this logic to the exec_child() and
exec_child_ex() functions to avoid code duplication

Resolves:
https://fedorahosted.org/sssd/ticket/3016

Reviewed-by: Lukáš Slebodník

UTIL: Add ERR_SBUS_REQUEST_HANDLED

2016-05-10T15:08:18+00:00

In most cases when sbus request parsing finishes, the request is handled
internally and a reply is sent to the caller. However, in handlers that
are parsed and handled completely manually, we might want to be notified
about this case so that the called of sbus_request_parse_or_finish()
aborts the request and doesn't proceed with using the sbus request which
is already freed internally in sbus_request_parse_or_finish().

Reviewed-by: Pavel Březina

util: make concatenate_string_array() reusable

2016-04-13T08:43:18+00:00

Reviewed-by: Pavel Březina

UTIL: Allow to append new line in sss_vdebug_fn

2016-03-23T11:07:10+00:00

libldb is not consistent with appending line feed
in debug messages. AS a result of this two messages can be on the same line
in sssd log files. Which makes analyzing log files more difficult.

Reviewed-by: Pavel Březina

UTIL: Move debug part from util.h -> new debug.h

2016-03-23T11:07:05+00:00

Reviewed-by: Pavel Březina 
Reviewed-by: Jakub Hrozek

utils: return const char ** from dup_string_list

2016-03-14T16:34:35+00:00

This function is not used anywhere and const char ** suits better
in my use case (next patch) so I just changed the function.

Reviewed-by: Jakub Hrozek

UTIL: Do not call stderr with negative number

2016-03-14T10:43:56+00:00

The function connect return -1 in case of error
and we could call strerror with -1 instead of
errno.

Reviewed-by: Jakub Hrozek

libipa_hbac: Ensure we always build with C90

2016-03-12T20:19:06+00:00

libipa_hbac is also used by external projects such as pam_hbac:
    https://github.com/jhrozek/pam_hbac

In order to make sure we don't use C99 features in the libipa_hbac code
in the future, this patch adds an explicit -std=c89 flag to CFLAGS.

Signed-off-by: Jakub Hrozek 
Reviewed-by: Jakub Hrozek

UTIL: Fix warning misleading-indentation

2016-03-10T13:35:22+00:00

Warnings are emited from macro generated code in dlinklist.h
e.g.
src/ldb_modules/memberof.c:4209:13: error: statement is indented as if it were
    guarded by... [-Werror=misleading-indentation]
             DLIST_DEMOTE(ctx->group_list, grp, struct mbof_member *);
             ^~~~~~~~~~~~
src/ldb_modules/memberof.c:4209:13: note: ...this ‘if’ clause, but it is not
src/ldb_modules/memberof.c: In function ‘mbof_member_update’:
src/ldb_modules/memberof.c:4305:9: error: statement is indented as if it were
    guarded by... [-Werror=misleading-indentation]
         DLIST_PROMOTE(ctx->group_list, mem);
         ^~~~~~~~~~~~~
src/ldb_modules/memberof.c:4305:9: note: ...this ‘if’ clause, but it is not
src/ldb_modules/memberof.c: In function ‘mbof_rcmp_update’:
src/ldb_modules/memberof.c:4408:9: error: statement is indented as if it were
    guarded by... [-Werror=misleading-indentation]
         DLIST_REMOVE(ctx->user_list, x);
         ^~~~~~~~~~~~
src/util/crypto/nss/nss_obfuscate.c: In function ‘sss_password_decrypt’:
src/util/crypto/nss/nss_obfuscate.c:419:5: error: statement is indented
    as if it were guarded by... [-Werror=misleading-indentation]
     SAFEALIGN_COPY_UINT16_CHECK(&meth, obfbuf+p, obflen, &p);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
src/python/pyhbac.c: In function ‘PyInit_pyhbac’:
src/python/pyhbac.c:1987:5: error: statement is indented as if it were
    guarded by... [-Werror=misleading-indentation]
     TYPE_READY(m, pyhbac_hbacrule_type, "HbacRule");
     ^~~~~~~~~~
src/python/pyhbac.c:1987:5: note: ...this ‘if’ clause, but it is not

Reviewed-by: Pavel Březina 
Reviewed-by: Michal Židek

UTIL: Fix indentation in dlinklist.h

2016-03-10T13:35:13+00:00

Reviewed-by: Pavel Březina 
Reviewed-by: Michal Židek