sssd.git/src/tools, branch wip

Remove unused structures.

2014-02-26T18:29:46+00:00

Reported by: cppcheck

'struct py_sss_transaction', 'struct resolve_get_domain_stat',
'struct sync_op_res' were defined in implementation modules, but they were not
used anywhere.

Reviewed-by: Michal Žídek

DEBUG: Allow debug_fn to process FILE and LINE

2014-02-19T11:28:05+00:00

In preparation for enabling journald support for the DEBUG logs, we
will need to be able to pass in certain additional arguments that will
be required, specifically the code file and line number.

We will be able to optionally enable this in the file-based logs as well
if we so choose, but for right now we will avoid breaking the log
format on disk.

Reviewed-by: Jakub Hrozek 
Reviewed-by: Lukáš Slebodník

Update DEBUG* invocations to use new levels

2014-02-12T21:31:02+00:00

Use a script to update DEBUG* macro invocations, which use literal
numbers for levels, to use bitmask macros instead:

grep -rl --include '*.[hc]' DEBUG . |
    while read f; do
        mv "$f"{,.orig}
        perl -e 'use strict;
                 use File::Slurp;
                 my @map=qw"
                    SSSDBG_FATAL_FAILURE
                    SSSDBG_CRIT_FAILURE
                    SSSDBG_OP_FAILURE
                    SSSDBG_MINOR_FAILURE
                    SSSDBG_CONF_SETTINGS
                    SSSDBG_FUNC_DATA
                    SSSDBG_TRACE_FUNC
                    SSSDBG_TRACE_LIBS
                    SSSDBG_TRACE_INTERNAL
                    SSSDBG_TRACE_ALL
                 ";
                 my $text=read_file(\*STDIN);
                 my $repl;
                 $text=~s/
                            ^
                            (
                                .*
                                \b
                                (DEBUG|DEBUG_PAM_DATA|DEBUG_GR_MEM)
                                \s*
                                \(\s*
                            )(
                                [0-9]
                            )(
                                \s*,
                            )
                            (
                                \s*
                            )
                            (
                                .*
                            )
                            $
                         /
                            $repl = $1.$map[$3].$4.$5.$6,
                            length($repl) <= 80
                                ? $repl
                                : $1.$map[$3].$4."\n".(" " x length($1)).$6
                         /xmge;
                 print $text;
        ' < "$f.orig" > "$f"
        rm "$f.orig"
    done

Reviewed-by: Jakub Hrozek 
Reviewed-by: Stephen Gallagher 
Reviewed-by: Simo Sorce

Fixup DEBUG macro invocations update

2014-02-12T21:30:58+00:00

Fix mistakes made by the update script in f87797f "Make DEBUG macro
invocations variadic".

Reviewed-by: Jakub Hrozek 
Reviewed-by: Stephen Gallagher 
Reviewed-by: Simo Sorce

Make DEBUG macro invocations variadic

2014-02-12T21:30:55+00:00

Use a script to update DEBUG macro invocations to use it as a variadic
macro, supplying format string and its arguments directly, instead of
wrapping them in parens.

This script was used to update the code:

grep -rwl --include '*.[hc]' DEBUG . |
    while read f; do
        mv "$f"{,.orig}
        perl -e \
            'use strict;
             use File::Slurp;
             my $text=read_file(\*STDIN);
             $text=~s#(\bDEBUG\s*\([^(]+)\((.*?)\)\s*\)\s*;#$1$2);#gs;
             print $text;' < "$f.orig" > "$f"
        rm "$f.orig"
    done

Reviewed-by: Jakub Hrozek 
Reviewed-by: Stephen Gallagher 
Reviewed-by: Simo Sorce

Move DEBUG macro body to debug_fn

2014-02-12T21:30:44+00:00

Move DEBUG macro body to the debug_fn function, adding "function"
argument to the latter.
Rename "debug_fn" in sssd_krb5_locator_plugin.c to "plugin_debug_fn" to
remove conflict with the sssd debug_fn.
Replace DEBUG_MSG macro usage with debug_fn function usage.
Remove DEBUG_MSG macro along with tests.

The above makes the total size of binaries drop by 20% for the standard
Fedora build and by 44% for a build configured according to Debian
packaging script.

Reviewed-by: Jakub Hrozek 
Reviewed-by: Stephen Gallagher 
Reviewed-by: Simo Sorce

Update debug levels in sss_semanage_error_callback

2014-02-12T21:30:41+00:00

Switch to using new debug levels in sss_semanage_error_callback.
Make SEMANAGE_MSG_WARN map to SSSDBG_MINOR_FAILURE instead of
SSSDBG_CONF_SETTINGS as it suits it better.

This prepares the function for the following patch switching it
to using updated "debug_fn" which expects new debug levels.

Reviewed-by: Jakub Hrozek 
Reviewed-by: Stephen Gallagher 
Reviewed-by: Simo Sorce

SSS_CACHE: Reset the initgroups attribute when resetting users

2014-02-12T14:17:45+00:00

sss_cache: fix case-sensitivity issue

2013-12-19T09:24:16+00:00

For case-insensitive domains the lower-case name for case-insensitive
searches is stored in SYSDB_NAME_ALIAS.

Related to https://fedorahosted.org/sssd/ticket/1741

sss_cache: initialize names member of sss_domain_info