sssd.git/src/tools, branch memberof_default_view

sssctl: improve readability of a condition

2016-07-13T10:08:04+00:00

Reviewed-by: Fabiano Fidêncio

sssctl: move filter creation to separate function

2016-07-13T10:07:58+00:00

Reviewed-by: Fabiano Fidêncio

TOOLS: Prevent dereference of null pointer

2016-07-12T12:23:32+00:00

VAR_CHECK is called with (var, EOK, ...)
EOK would be returned in case of "var != EOK"
and output argument _attrs would not be initialized.
Therefore there could be dereference of null pointer
after calling function usermod_build_attrs.

Reviewed-by: Pavel Březina

sssctl: Fix warning maybe-uninitialized

2016-07-12T09:57:57+00:00

It looks like some special gcc optimalisation and special case
may cause to have unitialized output argument _dom when return
code is EOK

src/tools/sssctl/sssctl_cache.c: In function ‘sssctl_print_object’:
src/tools/sssctl/sssctl_cache.c:491:8: error: ‘dom’ may be used
  uninitialized in this function [-Werror=maybe-uninitialized]
     if (dom == NULL) {
        ^
src/tools/sssctl/sssctl_cache.c:447:15: error: ‘entry’ may be used
  uninitialized in this function [-Werror=maybe-uninitialized]
     *_entry = talloc_steal(mem_ctx, entry);
               ^~~~~~~~~~~~
src/tools/sssctl/sssctl_cache.c:412:25: note: ‘entry’ was declared here
     struct sysdb_attrs *entry;
                         ^~~~~

Reviewed-by: Jakub Hrozek

sssctl: Fix format string for size_t

2016-07-12T09:57:57+00:00

src/tools/sssctl/sssctl_config.c: In function 'sssctl_config_check':
src/tools/sssctl/sssctl_config.c:93:14: warning: format '%lu' expects
  argument of type 'long unsigned int', but argument 2 has type
  'size_t {aka unsigned int}' [-Wformat=]
     printf(_("Issues identified by validators: %lu\n"), num_errors);
              ^
src/tools/sssctl/sssctl_config.c:93:12: note: in expansion of macro '_'
     printf(_("Issues identified by validators: %lu\n"), num_errors);
            ^
Reviewed-by: Jakub Hrozek

sssctl: config-check access check report

2016-07-11T10:07:07+00:00

Improve output when access check error
is detected by sssctl config-check command.

Reviewed-by: Pavel Březina

sssctl: Fix error handling after memory allocation failure

2016-07-11T10:03:13+00:00

Reviewed-by: Pavel Březina

sssctl: Add config-check command

2016-07-07T12:54:02+00:00

Fixes:
https://fedorahosted.org/sssd/ticket/2269

sssctl sconfig-check command allows to
call SSSD config file validators on
demand.

Reviewed-by: Lukáš Slebodník

TOOLS: Add the upgrade-cache command

2016-07-07T08:30:23+00:00

Allows to upgrade the cache using the sssctl tool, which might be useful
e.g. in RPM %post scripts.

Reviewed-by: Sumit Bose

TOOLS: Some tools command might not need initialization to succeed

2016-07-07T08:30:18+00:00

Since we want to use the sssctl tool during upgrade, we need to amend
the tools initialization code to not error out if sysdb can't be
instantiated, but rather return errno and let the tool handle the error.

Each tool command now has a 'allowed errno' the command is able to
handle. In this patch iteration, only a single errno can be handled and
only the upgrade command is able to do so.

Reviewed-by: Sumit Bose