sssd.git/src/tools, branch certificate_mapping

sssctl: Fix warning may be used uninitialized

2017-02-01T13:11:09+00:00

gcc 7 probably does some new optimisations which might cause few
wariables to be uninitialized.

src/tools/sssctl/sssctl_cache.c: In function ‘sssctl_print_object’:
src/tools/sssctl/sssctl_cache.c:523:13: error: ‘dom’ may be used uninitialized
  in this function [-Werror=maybe-uninitialized]
         ret = info[i].attr_fn(tmp_ctx, entry, dom, info[i].attr, &value);
         ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/tools/sssctl/sssctl_cache.c:472:15: error: ‘entry’ may be used
  uninitialized in this function [-Werror=maybe-uninitialized]
     *_entry = talloc_steal(mem_ctx, entry);
               ^~~~~~~~~~~~
src/tools/sssctl/sssctl_cache.c:437:25: note: ‘entry’ was declared here
     struct sysdb_attrs *entry;
                         ^~~~~

Another workaround would be to remove static modifier from function
sssctl_find_object which probably prevents some inlinig + optimisation.

Reviewed-by: Fabiano Fidêncio

TOOLS: Fix warning format-truncation

2017-02-01T13:11:02+00:00

src/tools/sss_groupshow.c: In function ‘print_group_info’:
src/tools/sss_groupshow.c:612:22: error: ‘%d’ directive output truncated
  writing between 10 and 11 bytes into a region of size 7 [-Werror=format-truncation=]
     snprintf(fmt, 8, "%%%ds", level*PADDING_SPACES);
                      ^~~~~~~
src/tools/sss_groupshow.c:612:22: note: using the range
  [-2147483648, 2147483647] for directive argument
src/tools/sss_groupshow.c:612:5: note: ‘snprintf’ output between 13 and 14
  bytes into a destination of size 8
     snprintf(fmt, 8, "%%%ds", level*PADDING_SPACES);

Reviewed-by: Fabiano Fidêncio

sssctl: Case insensitive filters

2016-12-15T09:43:32+00:00

Lowercase the filter in case insensitive domains.

Resolves:
https://fedorahosted.org/sssd/ticket/3235

Reviewed-by: Jakub Hrozek

sssctl: Search by alias

2016-12-15T09:43:29+00:00

Also search by alias when using sssctl to query the cache.

Resolves:
https://fedorahosted.org/sssd/ticket/3235

Reviewed-by: Jakub Hrozek

sssctl: Fix missing declaration

2016-11-25T11:51:12+00:00

The WEXITSTATUS is defined in stdlib.h on linux.
There is a nice comment in stdlib.h:
  /* Define the macros  also would define this way.  */

It's better to not rely on this and use more platfom friendly
way with including "sys/wait.h". For example the libc on FreeBSD
does not provide WEXITSTATUS in stdlib.h.

I found this macro mentioned only in the manual page for wait(2)
and there is mentioned just the "sys/wait.h" and not "stdlib.h"

src/tools/sssctl/sssctl.c: In function 'sssctl_run_command':
src/tools/sssctl/sssctl.c:110: error: implicit declaration of function
'WEXITSTATUS'
gmake[2]: *** [Makefile:22383: src/tools/sssctl/sssctl-sssctl.o] Error 1

Reviewed-by: Fabiano Fidêncio

sssctl: Flags for command initialization

2016-10-27T10:09:36+00:00

Allow passing flags for command specific initialization. Currently
only one flag is available to skip the confdb initialization which is
required to improve config-check command.

Resolves:
https://fedorahosted.org/sssd/ticket/3209

Reviewed-by: Lukáš Slebodník

sssctl: Fix a typo in preprocessor macro

2016-10-14T16:11:07+00:00

Reviewed-by: Lukáš Slebodník

sssctl: call service with absolute path

2016-10-11T12:31:46+00:00

Reviewed-by: Jakub Hrozek

sssctl: use systemd D-Bus API

2016-10-11T12:31:35+00:00

If systemd is used we leverage it's D-Bus API instead of running systemctl.

Resolves:
https://fedorahosted.org/sssd/ticket/3056

Reviewed-by: Jakub Hrozek

sss_cache: improve option argument handling

2016-10-10T10:08:41+00:00

Print informational message and exit when multiple arguments are provided
for single-argument options with sss_cache

Resolves:
https://fedorahosted.org/sssd/ticket/3180

Reviewed-by: Jakub Hrozek