sssd.git/src/tests/intg, branch certificate_mapping

intg: Return list for enumeration functions

2017-01-16T18:12:04+00:00

The documentation of get_passwd_list/get_group_list
says that they return group/user database entry list.
However, ther return class 'map' with python3 due to
changes in high level function "map".

Traceback (most recent call last):
  File "/dev/shm/sssd/src/tests/intg/ent_test.py",
       line 141, in test_assert_passwd_list
    ent.assert_passwd_list(ent.contains())
  File "/dev/shm/sssd/src/tests/intg/ent.py",
       line 243, in assert_passwd_list
    assert not d, d
AssertionError: not a list, 

Reviewed-by: Martin Basti

intg: Convert output of executed commands to strings

2017-01-16T18:12:00+00:00

We know that all our tested utilities (sssctl, sss_cache, sss_override)
returns strings and not binary data. We can safely encode output to
string (unicode) in python3

Reviewed-by: Martin Basti

intg: Return strings from ctypes wrappers

2017-01-16T18:11:56+00:00

Python module ctypes directly uses C functions from libraries.
C functions usually returns "char *" when string is expected.
But python3 uses unicode for string. Encoding returned bytes
("char *") to unicode strings simplify tests in python3

Reviewed-by: Martin Basti

intg: Use bytes as input in ctypes

2017-01-16T18:11:52+00:00

Python module ctypes directly uses C functions
and C functions expect "char *" as a string and not pointer
to wide characters "wchar *".

Reviewed-by: Martin Basti

intg: Use bytes for value of attributes in ldif

2017-01-16T18:11:47+00:00

Python3 version of ldap module require string for name of attribute
but bytes for value of attribute. It was not a problem in python2
due to unicode changes in python3

Reviewed-by: Martin Basti

intg: Fix creating of slapd configuration

2017-01-16T18:11:43+00:00

The python module subprocess expect bytes as an input.

Traceback (most recent call last):
  File "src/tests/intg/test_ldap.py", line 51, in ds_inst
    ds_inst.setup()
  File "src/tests/intg/ds_openldap.py", line 201, in setup
    self._setup_config()
  File "src/tests/intg/ds_openldap.py", line 169, in _setup_config
    slapadd.communicate(config)
  File "/usr/lib64/python3.6/subprocess.py", line 821, in communicate
    self._stdin_write(input)
  File "/usr/lib64/python3.6/subprocess.py", line 776, in _stdin_write
    self.stdin.write(input)
TypeError: a bytes-like object is required, not 'str'

Reviewed-by: Martin Basti

intg: Use bytes with hash function

2017-01-16T18:11:40+00:00

Python3 expects bytes as an input for hash function.
We need to convert string to bytes before hashing

Traceback (most recent call last):
  File "src/tests/intg/test_ldap.py", line 51, in ds_inst
    ds_inst.setup()
  File "src/tests/intg/ds_openldap.py", line 200, in setup
    self._setup_config()
  File "src/tests/intg/ds_openldap.py", line 76, in _setup_config
    admin_pw_hash = hash_password(self.admin_pw)
  File "src/tests/intg/ds_openldap.py", line 41, in hash_password
    hash = hashlib.sha1(password)
TypeError: Unicode-objects must be encoded before hashing

Reviewed-by: Martin Basti

intg: Avoid using iteritems for dictionary

2017-01-16T18:11:33+00:00

Originally, Python items() built a real list of tuples and returned that.
That could potentially take a lot of extra memory. Python iteritems()
returned an iterator-generator. The original remains for backwards
compatibility.

One of Python 3’s changes is that items() now return iterators,
and a list is never fully built. The iteritems() method is also gone,
since items() in Python 3 works like viewitems() in Python2.

But we do not have a lot of values in dictionary; so it does not worth
to optimize returned list from "items()" on Python2

Reviewed-by: Martin Basti

intg: Avoid using xrange in tests

2017-01-16T18:11:28+00:00

In Python 2 range() returns a list, and xrange() returns an object that
will only generate the items in the range when needed, saving memory.

In Python 3, the range() function is gone, and xrange() has been renamed
range().

We do not strictly require list or iterator in code therefore we can use
range which is in poth version. And we do not use big ranges there
so the memory overhead with list on python2 is not big.

Reviewed-by: Martin Basti

intg: Fix python2,3 urllib

2017-01-16T18:11:24+00:00

The three modules urllib, urllib2 and urlparse has been reorganized
into three new modules, urllib.request, urllib.parse and urllib.error.
And urllib.quote was moved into urllib.parse.

Reviewed-by: Martin Basti