sssd.git/src/responder/common, branch ad_domain_local_groups

DP: Remove old data provider interface

2016-08-16T12:54:50+00:00

Reverse data provider interface is moved to a better location in
NSS responder. All responders now can have an sbus interface
defined per data provider connection. The unused old data provider
interface is removed.

Reviewed-by: Lukáš Slebodník

sbus: add utility function to simplify message and reply handling

2016-08-16T12:39:04+00:00

This patch adds the ability to hook DBusMessage to a talloc context
to remove the need of calling dbus_message_unref(). It also provides
an automatical way to detect error in a reply so the caller does
not need to parse it manually and the whole code around DBusError
can be avoided.

Reviewed-by: Lukáš Slebodník 
Reviewed-by: Jakub Hrozek

rdp: add ability to forward reply to the client request

2016-08-16T12:38:52+00:00

In cases where the InfoPipe servers just as a middle-man between
the DataProvider and a client we can simply forward the reply
reducing amount of coded needed in the InfoPipe.

Reviewed-by: Lukáš Slebodník 
Reviewed-by: Jakub Hrozek

NSS: Do not check local users with disabled local_negative_timeout

2016-08-09T09:30:35+00:00

sssd_nss can set different negative timeout for local users
and groups. However, checking whether user/group is local
is quite expensive operation. We can avoid such operations
if local_negative_timeout is not set.

This fix improve performance(40%) of lookup non-existing
entries in offline mode and with disabled local_negative_timeout.

  sh$ cat pok.sh
  for i in {1..10000}; do
    getent passwd -s sss temp$i
    getent group -s sss temp$i
  done

  #without patch
  sh $time /bin/bash pok.sh
  real    0m41.534s
  user    0m3.580s
  sys     0m14.202s

  #with patch
  sh $time /bin/bash pok.sh
  real    0m26.686s
  user    0m3.292s
  sys     0m13.165s

Resolves:
https://fedorahosted.org/sssd/ticket/3122

Reviewed-by: Petr Cech

RESPONDERS: Pass errno to strerror() when SELINUX_getpeercon() fails

2016-08-04T10:17:33+00:00

Currently ret, which is -1, is passed to strerror() instead of errno.

Signed-off-by: Fabiano Fidêncio 

Related:
https://fedorahosted.org/sssd/ticket/3094

Reviewed-by: Jakub Hrozek

RESPONDERS: Show a bit more info in case of SELINUX_getpeercon() failure

2016-08-04T10:17:29+00:00

Be explicit that it may happen when SELinux is disabled and also suggest
to enable SELinux.

Signed-off-by: Fabiano Fidêncio 

Related:
https://fedorahosted.org/sssd/ticket/3094

Reviewed-by: Jakub Hrozek

RESPONDERS: Decrease debug level for failures in SELINUX_getpeercon()

2016-08-04T10:17:25+00:00

As this is not FATAL and may happen when SELinux is disabled, let's just
decrease the debug level to MINOR_FAILURE

Signed-off-by: Fabiano Fidêncio 

Related:
https://fedorahosted.org/sssd/ticket/3094

Reviewed-by: Jakub Hrozek

Amend debug messages after failure of unlink

2016-07-25T13:49:20+00:00

Some messages did not have errno or name of problematic file.
There was also improper use of negative value.
The function strerror was called with -1 instead of errno

Reviewed-by: Petr Čech

Fix packet size calculation in sss_packet_new

2016-07-07T10:52:01+00:00

Use division instead of modulo while rounding the created packet size up
to a multiple of SSSSRV_PACKET_MEM_SIZE in sss_packet_new. This fixes
potentially packet buffer overflows with certain body sizes.

Reviewed-by: Pavel Březina

SYSDB: Remove useless parameter from sysdb_init()

2016-07-07T08:29:49+00:00

The function sysdb_init() is never used to allow upgrade, so the
allow_upgrade parameter was pointless.

Reviewed-by: Sumit Bose