sssd.git/src/python, branch ad_domain_local_groups

nss-idmap: add sss_nss_getnamebycert()

2016-06-09T14:12:25+00:00

Reviewed-by: Jakub Hrozek 
Reviewed-by: Lukáš Slebodník

libipa_hbac: Move the library to src/lib/ipa_hbac

2016-03-12T20:19:06+00:00

Moving the library to the lib directory will force maintainers to think
twice about changes, because it would be obvious this is a library.

Also don't use includes from sssd source tree paths, but add the util
path to Makefile's CFLAGS so that other projects can copy the
hbac_evaluator.c file verbatim.

Reviewed-by: Lukáš Slebodník

Fix typos reported by lintian

2016-02-23T11:04:42+00:00

Reviewed-by: Pavel Březina

pyhbac: Fix warning Wsign-compare

2016-01-29T08:32:18+00:00

src/python/pyhbac.c: In function ‘HbacRuleElement_repr’:
src/python/pyhbac.c:506:59: error: comparison between
    signed and unsigned integer expressions [-Werror=sign-compare]
     if (strnames == NULL || strgroups == NULL || category == -1) {
                                                           ^
src/python/pyhbac.c: In function ‘HbacRuleElement_to_native’:
src/python/pyhbac.c:614:51: error: comparison between
    signed and unsigned integer expressions [-Werror=sign-compare]
     if (!el->names || !el->groups || el->category == -1) {
                                                   ^

The static function native_category had type of terurn value uint32_t
But it also could return -1 which indicated an error.

It's better to don't mix return code with returned value.

Reviewed-by: Jakub Hrozek

pysss_murmur: Fix warning Wsign-compare

2016-01-29T08:32:13+00:00

src/python/pysss_murmur.c: In function ‘py_murmurhash3’:
src/python/pysss_murmur.c:47:17: error: comparison between
     signed and unsigned integer expressions [-Werror=sign-compare]
         key_len > strlen(key)) {
                 ^

uint32_t murmurhash3(const char *key, int len, uint32_t seed)
The second argument of the function murmurhash3 has type int.
But the code expects to be unsigned integer.

There is code in python wrapper py_murmurhash3
which check boundaries of that argument.
It should be an unsigned "key_len > INT_MAX || key_len < 0".
An exception should be thrown for negative number.

Moreover, the length should be shorter then a length of input string.
The strlen returns size_t which is unsigned and key_len is signed long.
We already checked that value is unsigned so
we can safely cast key_len to size_t

Reviewed-by: Jakub Hrozek

UTIL: Remove python wrapper sss_python_unicode_from_string

2015-02-25T07:38:29+00:00

The function PyUnicode_FromString is available in python >= 2.6

Reviewed-by: Stephen Gallagher

UTIL: Remove python wrapper sss_python_set_check

2015-02-25T07:38:25+00:00

The macro PySet_Check is defined in python >= 2.6

Reviewed-by: Stephen Gallagher

UTIL: Remove python wrapper sss_python_set_add

2015-02-25T07:38:23+00:00

The function PySet_Add is available in python >= 2.6

Reviewed-by: Stephen Gallagher

UTIL: Remove python wrapper sss_python_set_new

2015-02-25T07:38:20+00:00

The function PySet_New is available in python >= 2.6

Reviewed-by: Stephen Gallagher

Fix warning: equality comparison with extraneous parentheses

2015-02-11T19:38:42+00:00

Example of warning:
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
  error: equality comparison with extraneous parentheses
  [-Werror,-Wparentheses-equality]
    if (((wbc_status) == WBC_ERR_SUCCESS)) {
         ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
  note: remove extraneous parentheses around the comparison
  to silence this warning
    if (((wbc_status) == WBC_ERR_SUCCESS)) {
        ~             ^                 ~
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
  note: use '=' to turn this equality comparison into an assignment
    if (((wbc_status) == WBC_ERR_SUCCESS)) {
                      ^~
                      =

The reason is definition of some macros which were used in if conditions.

Reviewed-by: Michal Židek