sssd.git/src/monitor, branch master

sbus: Use constants to make dbus calls

2014-02-24T10:15:06+00:00

This allows us to remove duplicated information, and have the
compiler check that when an method name is changed or removed
the callers are updated.

Reviewed-by: Jakub Hrozek 
Reviewed-by: Sumit Bose 
Reviewed-by: Lukáš Slebodník 
Reviewed-by: Simo Sorce

sbus: Generate constants from interface definitions

2014-02-24T10:15:02+00:00

This is not strictly necessary, but avoids duplicating data
in mulitple places, and makes the interface definitions
benefit dbus callers (a little).

After applying this commit you may need to 'make clean' as
the codegen has changed.

Reviewed-by: Jakub Hrozek 
Reviewed-by: Sumit Bose 
Reviewed-by: Lukáš Slebodník 
Reviewed-by: Simo Sorce

sbus: Rework sbus to use interface metadata and vtables

2014-02-24T10:14:59+00:00

Previous commits added support for interface metadata and
handler vtables. This commit ports sbus_dbus_connection to
use them.

Port the internal uses of dbus to use the new scheme in a
very minimal way. Further cleanup is possible here.

This commit provides basic definitions of the internal
dbus interfaces. The interfaces aren't fully defined, as the
handlers will continue to unpack manually, and often overload
DBus methods with different arguments (which is rather
unorthodox, but not the end of the world).

Reviewed-by: Jakub Hrozek 
Reviewed-by: Sumit Bose 
Reviewed-by: Lukáš Slebodník 
Reviewed-by: Simo Sorce

Update DEBUG* invocations to use new levels

2014-02-12T21:31:02+00:00

Use a script to update DEBUG* macro invocations, which use literal
numbers for levels, to use bitmask macros instead:

grep -rl --include '*.[hc]' DEBUG . |
    while read f; do
        mv "$f"{,.orig}
        perl -e 'use strict;
                 use File::Slurp;
                 my @map=qw"
                    SSSDBG_FATAL_FAILURE
                    SSSDBG_CRIT_FAILURE
                    SSSDBG_OP_FAILURE
                    SSSDBG_MINOR_FAILURE
                    SSSDBG_CONF_SETTINGS
                    SSSDBG_FUNC_DATA
                    SSSDBG_TRACE_FUNC
                    SSSDBG_TRACE_LIBS
                    SSSDBG_TRACE_INTERNAL
                    SSSDBG_TRACE_ALL
                 ";
                 my $text=read_file(\*STDIN);
                 my $repl;
                 $text=~s/
                            ^
                            (
                                .*
                                \b
                                (DEBUG|DEBUG_PAM_DATA|DEBUG_GR_MEM)
                                \s*
                                \(\s*
                            )(
                                [0-9]
                            )(
                                \s*,
                            )
                            (
                                \s*
                            )
                            (
                                .*
                            )
                            $
                         /
                            $repl = $1.$map[$3].$4.$5.$6,
                            length($repl) <= 80
                                ? $repl
                                : $1.$map[$3].$4."\n".(" " x length($1)).$6
                         /xmge;
                 print $text;
        ' < "$f.orig" > "$f"
        rm "$f.orig"
    done

Reviewed-by: Jakub Hrozek 
Reviewed-by: Stephen Gallagher 
Reviewed-by: Simo Sorce

Make DEBUG macro invocations variadic

2014-02-12T21:30:55+00:00

Use a script to update DEBUG macro invocations to use it as a variadic
macro, supplying format string and its arguments directly, instead of
wrapping them in parens.

This script was used to update the code:

grep -rwl --include '*.[hc]' DEBUG . |
    while read f; do
        mv "$f"{,.orig}
        perl -e \
            'use strict;
             use File::Slurp;
             my $text=read_file(\*STDIN);
             $text=~s#(\bDEBUG\s*\([^(]+)\((.*?)\)\s*\)\s*;#$1$2);#gs;
             print $text;' < "$f.orig" > "$f"
        rm "$f.orig"
    done

Reviewed-by: Jakub Hrozek 
Reviewed-by: Stephen Gallagher 
Reviewed-by: Simo Sorce

MONITOR: Incorrect permissions on sssd.conf

2014-02-11T20:47:44+00:00

Print user friendly warning when permissions on sssd.conf are incorrect and
provide hint.

Resolves:
https://fedorahosted.org/sssd/ticket/2208

Reviewed-by: Stephen Gallagher

monitor: syslog when process killed by monitor

2013-12-09T21:08:53+00:00

https://fedorahosted.org/sssd/ticket/2162

monitor: memory-leak bug

2013-12-09T21:08:53+00:00

In case *mt_svc_restart* event can't be created free *svc* directly.

monitor: monitor_kill_service - refactor

2013-12-09T21:08:53+00:00

After freeing *svc* return immediately instead of creating event operating on
*svc* (use-after-free). Also check tevent_add_timer failure and remove unused
sigkill_ev variable.

monitor: use-after-free bugfix

2013-12-09T21:08:53+00:00

*monitor_kill_service* may create timed event which operates on *svc* and
therefore *svc* should not be freed right after call of *monitor_kill_sercice*.
*svc* is supposed to be freed by *mt_svc_restart*.