sssd.git/src/db/sysdb.c, branch jhrozek_sysdb_fqdn

SYSDB: Add a utility function to return a list of qualified names

2016-07-06T15:32:59+00:00

Adds a utility function the LDAP provider can use. This is different
from sss_create_internal_fqname_list in the sense that the LDAP provider
passes in the attribute name that contains the name attribute value.

SYSDB: Check if group attributes differ before saving a group

2016-06-23T11:47:16+00:00

Adds a new function sysdb_entry_attrs_diff() used in group saving code.
This function is used to check if the result of updating a group would
result in actually changing the sysdb entry -- often, we would try to
dump the same data to the cache during update. If that's the case, the
update code now only updates the timestamp cache, avoiding costly
writes.

Reviewed-by: Sumit Bose

SYSDB: If modifyTimestamp is the same, only update the TS cache

2016-06-23T11:47:07+00:00

Resolves:
    https://fedorahosted.org/sssd/ticket/2602

If the entry being saved contains the original modifyTimestamp attribute
and the modifyTimestamp attribute is the same as the one we already
saved to the timestamp cache, only the expire timestamps in the
asynchronous timestamp cache will be bumped and the sysdb code will
avoid writes to the main cache completely. If the modifyTimestamp is
either missing or differs, we assume the entry had changed and do a full
write to the main cache.

Also amends the generic sysdb_set_attrs* and similar functions that
their results is also reflected in the timestamps cache.

Reviewed-by: Sumit Bose

SYSDB: Search the timestamp caches in addition to the sysdb cache

2016-06-23T11:40:11+00:00

When a sysdb entry is searched, the sysdb cache is consulted first
for users or groups. If an entry is found in the sysdb cache, the
attributes from the timestamp cache are merged to return the full and
up-to-date set of attributes.

The merging is done with a single BASE search which is a direct lookup
into the underlying key-value database, so it should be relatively fast.
More complex merging is done only for enumeration by filter which is
currently done only via the IFP back end and should be quite
infrequent, so I hope we can justify a more complex merging there.

Reviewed-by: Sumit Bose

SYSDB: Move sysdb initialization into a new module sysdb_init.c

2016-06-23T11:40:05+00:00

The sysdb initialization was in the sysdb.c module. With adding
initialization of the timestamp cache, this module would become too big
with too many private functions meant only for initialization.

This patch only moves code around, there are no functional changes to
the initialization.

Reviewed-by: Sumit Bose

SYSDB: Add systemtap probes to track sysdb transactions

2016-06-10T16:15:27+00:00

Actually adds marks for sysdb transactions that receive the transaction
nesting level as an argument. The nesting is passed on from probes to
marks along with a human-friendly description.

The transaction commit is decorated with two probes, before and after.
This would allow the caller to distinguish between the time we spend in
the transaction (which might be important, because if a transaction is
active on an ldb context, even the readers are blocked before the
transaction completes) and the time we spend commiting the transaction
(which is important because that's when the disk writes occur)

The probes would be installed into /usr/share/systemtap/tapset on RHEL
and Fedora. This is in line with systemtap's paths which are described
in detail in "man 7 stappaths".

Reviewed-by: Lukáš Slebodník

SYSDB: Track transaction nesting in sysdb_ctx

2016-06-10T16:15:27+00:00

Adds an integer that tracks how deeply nested we are in sysdb
transactions. This will become useful later, because generally we are
only interested in level-0 transactions when probing, so we'll want to
pass the transaction nesting to the systemtap probes.

Reviewed-by: Lukáš Slebodník

sysdb: add sysdb_attrs_add_base64_blob()

2016-06-09T14:12:25+00:00

Reviewed-by: Jakub Hrozek

sysdb: add sysdb_{add,replace,delete}_ulong()

2016-05-31T11:07:02+00:00

As the add_ulong() convenience can add, replace or remove a unsigned
long according to the operation received as its argument, some confusion
can easily happen due to its misleading name.

In order to improve the explicitness of our code, let's introduce
sysdb_add_ulong(), sysdb_replace_ulong() and sysdb_delete_ulong().

These new functions are basically wrappers of add_ulong() (now
sysdb_ldb_msg_ulong_helper()), calling it using the proper flag
according to each function.

Any code previously using add_ulong() is now adapted to use these brand
new functions.

Related: https://fedorahosted.org/sssd/ticket/1656

Signed-off-by: Fabiano Fidêncio 

Reviewed-by: Petr Cech

sysdb: move add_ulong() convenience to sysdb.c

2016-05-31T11:06:57+00:00

Considering that sysdb.c is about utilities around our cache and that
sysdb_ops.c is about operations on objects, seems that add_ulong()
could fit better in sysdb.c.

This move is a suggestion from Jakub Hrozek.

Related: https://fedorahosted.org/sssd/ticket/1656

Signed-off-by: Fabiano Fidêncio 

Reviewed-by: Petr Cech