From 56a029258f75da967f73e7151292d8cdaf3fecdf Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sat, 8 Sep 2007 09:15:08 +0000 Subject: r25024: Fix a whole bunch of Coverity bugs The callers of get_domain_group_from_sid() with some justification expected map->gid to be initialized when get_domain_group_from_sid returned True. (This used to be commit bc8b74dbfec965ede7bf45118d1a863b28d000fd) --- source3/groupdb/mapping.c | 1 + 1 file changed, 1 insertion(+) (limited to 'source3/groupdb') diff --git a/source3/groupdb/mapping.c b/source3/groupdb/mapping.c index e14ad7d5092..0a733dded91 100644 --- a/source3/groupdb/mapping.c +++ b/source3/groupdb/mapping.c @@ -145,6 +145,7 @@ BOOL get_domain_group_from_sid(DOM_SID sid, GROUP_MAP *map) fstrcpy( map->comment, "Ordinary Users" ); sid_copy( &map->sid, &sid ); map->sid_name_use = SID_NAME_DOM_GRP; + map->gid = (gid_t)-1; return True; } -- cgit