From 0f1dffb2f2ce5ace1b3216f578ab115c976624c7 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Mon, 6 Mar 2006 17:47:21 +0000 Subject: r13875: Fix coverity bug #148. Deref of rrec before NULL check. Jeremy. --- source/nmbd/nmbd_winsproxy.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'source/nmbd') diff --git a/source/nmbd/nmbd_winsproxy.c b/source/nmbd/nmbd_winsproxy.c index d6dc6261c84..a31eb1e2a62 100644 --- a/source/nmbd/nmbd_winsproxy.c +++ b/source/nmbd/nmbd_winsproxy.c @@ -49,7 +49,12 @@ static void wins_proxy_name_query_request_success( struct subnet_record *subrec, nb_flags = get_nb_flags( rrec->rdata ); - num_ips = rrec->rdlength / 6; + if (rrec) { + num_ips = rrec->rdlength / 6; + } else { + num_ips = 0; + } + if(num_ips == 0) { DEBUG(0,("wins_proxy_name_query_request_success: Invalid number of IP records (0) \ returned for name %s.\n", nmb_namestr(nmbname) )); @@ -71,7 +76,7 @@ returned for name %s.\n", nmb_namestr(nmbname) )); /* Add the queried name to the original subnet as a WINS_PROXY_NAME. */ - if(rrec == PERMANENT_TTL) { + if(rrec && (rrec == PERMANENT_TTL)) { ttl = lp_max_ttl(); } -- cgit