From 34e8deccf989a43a811cb8e0a00fc82e67867b71 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Sat, 24 May 2014 22:47:30 +1200 Subject: selftest: consitently use the name s4member This avoids a conflict with the Samba3.pm defined member environment, and so spurious failures in make test for the member environment dependent on test ordering. Andrew Bartlett Signed-off-by: Andrew Bartlett Reviewed-by: Andreas Schneider --- selftest/target/Samba4.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'selftest') diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm index c4e8f31bce7..50a4cd559c2 100755 --- a/selftest/target/Samba4.pm +++ b/selftest/target/Samba4.pm @@ -916,7 +916,7 @@ $extra_smbconf_shares return $self->provision_raw_step2($ctx, $ret); } -sub provision_member($$$) +sub provision_s4member($$$) { my ($self, $prefix, $dcvars) = @_; print "PROVISIONING MEMBER..."; @@ -1703,7 +1703,7 @@ sub setup_env($$$) if (not defined($self->{vars}->{dc})) { $self->setup_dc("$path/dc"); } - return $self->setup_member("$path/s4member", $self->{vars}->{dc}); + return $self->setup_s4member("$path/s4member", $self->{vars}->{dc}); } elsif ($envname eq "rodc") { if (not defined($self->{vars}->{dc})) { $self->setup_dc("$path/dc"); @@ -1729,18 +1729,18 @@ sub setup_env($$$) } } -sub setup_member($$$) +sub setup_s4member($$$) { my ($self, $path, $dc_vars) = @_; - my $env = $self->provision_member($path, $dc_vars); + my $env = $self->provision_s4member($path, $dc_vars); if (defined $env) { $self->check_or_start($env, "single"); $self->wait_for_start($env); - $self->{vars}->{member} = $env; + $self->{vars}->{s4member} = $env; } return $env; -- cgit