From 56c764a2d168a8cd3627e7d551e5eb802af48756 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Tue, 9 Feb 2010 12:17:08 -0800 Subject: Fix off-by-one error in working out the limit of the NetServerEnum comment. Jeremy. (cherry picked from commit 9ad6f432f3f5844b4b419e7cbaf3c3e70b052d29) Signed-off-by: Stefan Metzmacher (cherry picked from commit 8cac1af47cad9d40b0ab86cda3674f4420507008) --- source/libsmb/clirap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/libsmb/clirap.c b/source/libsmb/clirap.c index 116e0a91759..ea9e439f1b1 100644 --- a/source/libsmb/clirap.c +++ b/source/libsmb/clirap.c @@ -389,7 +389,7 @@ bool cli_NetServerEnum(struct cli_state *cli, char *workgroup, uint32 stype, comment_offset = (IVAL(p,22) & 0xFFFF)-converter; cmnt = comment_offset?(rdata+comment_offset):""; - if (comment_offset < 0 || comment_offset > (int)rdrcnt) { + if (comment_offset < 0 || comment_offset >= (int)rdrcnt) { TALLOC_FREE(frame); continue; } -- cgit