From 1be60597cd62af2b30a1496d06ea5704e87d3b7d Mon Sep 17 00:00:00 2001
From: Jeremy Allison <jra@samba.org>
Date: Sat, 28 Apr 2001 00:05:11 +0000
Subject: rpcclient/rpcclient.c: Non-void return in void function.
 smbd/sec_ctx.c: Fixed potential memory leak spotted by Kenichi Okuyama@Tokyo
 Research Lab, IBM-Japan, Co. utils/nmblookup.c: gcc warning on Solaris fix.
 Jeremy.

---
 source/smbd/sec_ctx.c    | 4 +++-
 source/utils/nmblookup.c | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/source/smbd/sec_ctx.c b/source/smbd/sec_ctx.c
index f6563ffe96e..6f98e9df6b0 100644
--- a/source/smbd/sec_ctx.c
+++ b/source/smbd/sec_ctx.c
@@ -152,8 +152,10 @@ int get_current_groups(int *p_ngroups, gid_t **p_groups)
 		return -1;
 	}
 
-	if ((ngroups = sys_getgroups(ngroups,groups)) == -1)
+	if ((ngroups = sys_getgroups(ngroups,groups)) == -1) {
+		safe_free(groups);
 		return -1;
+	}
 
 	(*p_ngroups) = ngroups;
 	(*p_groups) = groups;
diff --git a/source/utils/nmblookup.c b/source/utils/nmblookup.c
index 4e85f6ac456..0f978a6cf3f 100644
--- a/source/utils/nmblookup.c
+++ b/source/utils/nmblookup.c
@@ -118,7 +118,7 @@ static void do_node_status(int fd, char *name, int type, struct in_addr ip)
 		for (i=0;i<count;i++) {
 			fstrcpy(cleanname, status[i].name);
 			for (j=0;cleanname[j];j++) {
-				if (!isprint(cleanname[j])) cleanname[j] = '.';
+				if (!isprint((int)cleanname[j])) cleanname[j] = '.';
 			}
 			printf("\t%-15s <%02x> - %s\n",
 			       cleanname,status[i].type,
-- 
cgit