summaryrefslogtreecommitdiffstats
path: root/source
Commit message (Collapse)AuthorAgeFilesLines
...
| * r20690: fix a bug that causes smbd to 'hang' intermittently.Andrew Tridgell2007-01-111-32/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The problem occurs like this: 1) running smbd as a domain member without winbindd 2) client1 connects, during auth smbd-1 calls update_trustdom_cache() 3) smbd-1 takes the trustdom cache timestamp lock, then starts enumerate_domain_trusts 4) enumerate_domain_trusts hangs for some unknown reason 5) other clients connect, all block waiting for read lock on trustdom cache 6) samba is now hung The problem is the lock, and really its just trying to avoid a race where the cure is worse than the problem. A race in updating the trutdom cache is not a big issue. So I've just removed the lock. It is still an open question why enumerate_domain_trusts() can hang. Unfortunately I've not in a position to get a sniff at the site that is affected. I suspect a full fix will involve ensuring that all the rpc code paths have appropriate timeouts.
| * r20687: Implement grace logons for offline authentications in pam_winbind.Günther Deschner2007-01-113-21/+45
| | | | | | | | | | | | | | | | | | In case a user authenticated sucessfully and his password just expired while beeing disconnected, we should allow a user to logon (given a clear warning). We currently forced the user into a password change dialogue in that scenario; this did not make much sense while offline. Guenther
| * r20674: Regenerate NDR parsers after pidl changes. This should fix a couple of Jelmer Vernooij2007-01-118-108/+66
| | | | | | | | coverity warnings.
| * r20668: Also do not install the smbumount man page if we don't build smbumount.Lars Müller2007-01-101-1/+1
| |
| * r20666: Also do not install the smbmnt man page if SMBMOUNT_PROGS is not set.Lars Müller2007-01-101-1/+1
| |
| * r20664: Set the environment variable _before_ calling the shell.Lars Müller2007-01-101-1/+1
| |
| * r20663: Do not install smbmount man page if we didn't called configureLars Müller2007-01-103-3/+6
| | | | | | | | --with-smbmount.
| * r20654: Fix from Karolin Seeger <ks@sernet.de>: Accept "forever", "off" and ↵Volker Lendecke2007-01-101-7/+15
| | | | | | | | | | | | | | | | "never" as key words for -1 as policy values for net sam policy. Volker
| * r20651: Fix "password expires soon" warning message for pam_winbind.Günther Deschner2007-01-101-12/+67
| | | | | | | | | | | | | | | | We were incorrectly calculating the days until the password expires and we also need to look at the info3 pass_must_change_time for expiry calculation. Guenther
| * r20644: Make some functions static, thanks to Michael Adam <ma@sernet.de> ↵Volker Lendecke2007-01-101-3/+3
| | | | | | | | for the hint.
| * r20636: Remove notify leftoverVolker Lendecke2007-01-091-1/+0
| |
| * r20635: Add placeholder to ensure we don't go into theJeremy Allison2007-01-091-0/+11
| | | | | | | | | | | | | | | | | | wcard unlink if bad_path was set. The error returned here is almost certainly incorrect and will need testing properly with smbtorture, but I don't want to forget about this path (yes Volker I know this is currently incorrect :-). Jeremy.
| * r20634: A *LOT* more work is necessary before touching notify remotely ↵Volker Lendecke2007-01-097-621/+38
| | | | | | | | | | | | | | | | | | starts to make sense. Until then, remove it from the tree to keep the diff between 3_0_24 and 3_0 small. Volker
| * r20632: The extended RAW-SAMBA3BADPATH test led me to some wrong assumptions, inVolker Lendecke2007-01-091-53/+59
| | | | | | | | | | | | | | | | particular the NT_STATUS_INVALID_PARAMETER thing was badly wrong. Remove the changes based on it. Using gentest is much more effective in this respect, but it will take a while to figure out the wildcard error handling of W2k3. Volker
| * r20630: Fix some trivial memleaks.Günther Deschner2007-01-091-0/+3
| | | | | | | | Guenther
| * r20628: Looks bigger than it is. This is just re-indenting the if (dirname) ↵Volker Lendecke2007-01-091-40/+38
| | | | | | | | | | | | | | | | that we've taken care of above. Volker
| * r20627: orig_name is not needed anymore, and slightly simplify logic by ↵Volker Lendecke2007-01-091-9/+8
| | | | | | | | | | | | | | | | doing early returns. Volker
| * r20626: Fix a memleak found by the IBM checker -- not on 3.0.24Volker Lendecke2007-01-091-0/+1
| |
| * r20619: bad_path is handled somewhere else, so can_delete does not need it ↵Volker Lendecke2007-01-081-11/+3
| | | | | | | | anymore
| * r20618: Fix a bug in bad_path handling that also exists in 3.0.23: For ↵Volker Lendecke2007-01-081-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reply_unlink under Linux we returned NT_STATUS_NOT_A_DIRECTORY. This is because in the bad_path==True condition lstat(2) returns ENOTDIR and not ENOENT. Not sure if we want to necessarily replicate the INVALID_PARAMETER here, but this is what W2k3 does. Jeremy, I tried to call you, but you were not around. So I'll leave it up to you to merge this. Volker
| * r20617: Do not notify if the delete failedVolker Lendecke2007-01-081-5/+7
| |
| * r20614: Dummy-checkin to trigger the buildVolker Lendecke2007-01-081-4/+5
| |
| * r20612: A checkin I've wanted to do for ages: For bad_path==False ↵Volker Lendecke2007-01-083-50/+21
| | | | | | | | | | | | | | | | | | set_bad_path_error is equivalent to UNIX_ERROR. Expand the last reference. Lets see if I can kill that as well :-) Volker
| * r20611: All but one callers to set_bad_path_error have had the ↵Volker Lendecke2007-01-083-15/+29
| | | | | | | | | | | | | | | | bad_path==True argument being handled further up. Volker
| * r20610: Fix a Solaris warningVolker Lendecke2007-01-081-1/+1
| |
| * r20608: ENOENT->NT_STATUS_OBJECT_NAME_NOT_FOUND is covered in the standard ↵Volker Lendecke2007-01-081-6/+2
| | | | | | | | unix error mapping table
| * r20607: Next micro-step for reply_setatrVolker Lendecke2007-01-081-8/+6
| |
| * r20606: bad_path == True has been covered further up in reply_setatr.Volker Lendecke2007-01-081-1/+2
| | | | | | | | | | | | | | | | I'm checking in micro-steps to make them independently checkable. This code just very severely needs cleanup, but I don't want to break anything. So, be patient with me, please :-) Volker
| * r20605: Simplify logic in reply_setatr slightlyVolker Lendecke2007-01-081-4/+2
| |
| * r20604: Fix two memleaks, Coverity ID 337, merge to 3_0_24Volker Lendecke2007-01-081-0/+2
| |
| * r20603: Slightly simplify logicVolker Lendecke2007-01-081-7/+7
| |
| * r20602: Fix coverity ID 339. SMB_ASSERT does not panic without -DDEVELOPER.Volker Lendecke2007-01-081-1/+4
| | | | | | | | Volker
| * r20597: Survive some of the notify mask tests.Volker Lendecke2007-01-073-10/+24
| |
| * r20589: Re-add lost bad_path handling, sorry.Volker Lendecke2007-01-061-0/+4
| |
| * r20558: Refactor rmdir_internals to use early termination ratherJeremy Allison2007-01-051-55/+56
| | | | | | | | | | | | | | than lots of indented code. Change recursive_rmdir() to return the smbd standards of True on success, False on fail (it was doing the reverse, which was very confusing). Jeremy.
| * r20546: Fix some IBM checker errorsVolker Lendecke2007-01-051-0/+4
| |
| * r20544: Change copy_file() to return NTSTATUS. This is in preparation of turningVolker Lendecke2007-01-052-29/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | close_file() to NTSTATUS as well. I'm not sure I got all the error codes right, but as I've never come across a smb_copy() call in all my Samba work, I'm leaving it at that. If I'm absolutely bored, I will write a thorough torture test. As far as I can see, Samba4 even does not have a libcli implementation for it... :-) Volker
| * r20542: Make close_remove_share_mode retun NTSTATUS. Not that anybody cares ↵Volker Lendecke2007-01-051-4/+16
| | | | | | | | yet...
| * r20541: Fix some obvious glitches in wait_for_aio_completion. Hmmm. It seemsVolker Lendecke2007-01-051-6/+5
| | | | | | | | | | | | reply_close() at its heart is going to be an async call :-) Volker
| * r20536: In the offline PAM session close case the attempt to delete aGünther Deschner2007-01-042-1/+7
| | | | | | | | | | | | non-existing krb5 credential cache should not generate an error. Guenther
| * r20535: Fix make install to work when root doesn't haveJeremy Allison2007-01-041-3/+7
| | | | | | | | | | | | write access into the source tree (like when your directory is nfs mounted for example....). Jeremy.
| * r20532: From Volker...Jeremy Allison2007-01-041-1/+1
| | | | | | | | | | | | | | | | | | | | "smbcli_setattr("") always returns ACCESS_DENIED, test extension to follow. Merge to 3.0.24?" Yep (with slight optimization). Jeremy.
| * r20530: Don't want this call to get inadvertently re-added :-).Jeremy Allison2007-01-041-3/+0
| | | | | | | | Jeremy.
| * r20525: Closing a dir with del-on-close set requires the same as files: ↵Volker Lendecke2007-01-041-0/+12
| | | | | | | | | | | | | | | | | | | | Don't actually unlink/rmdir if another process still has it open. Jeremy, this is a potential merger to 3.0.24. Volker
| * r20524: Simplify logic of close_remove_share_mode().Volker Lendecke2007-01-041-51/+67
| | | | | | | | Volker
| * r20512: Fix typo.Günther Deschner2007-01-031-1/+1
| | | | | | | | Guenther
| * r20507: smbcli_setattr("") always returns ACCESS_DENIED, test extension to ↵Volker Lendecke2007-01-031-0/+9
| | | | | | | | | | | | | | | | follow. Merge to 3.0.24? Volker
| * r20503: And one more 64-bit warningVolker Lendecke2007-01-031-1/+1
| |
| * r20502: Activate RAW-RENAME, my Linux box passes thisVolker Lendecke2007-01-031-1/+1
| |
| * r20501: Check in config.h fix from Michael Adam <ma@sernet.de>Volker Lendecke2007-01-032-0/+9
| |