summaryrefslogtreecommitdiffstats
path: root/source
Commit message (Collapse)AuthorAgeFilesLines
* r20632: The extended RAW-SAMBA3BADPATH test led me to some wrong assumptions, inVolker Lendecke2007-10-101-53/+59
| | | | | | | | particular the NT_STATUS_INVALID_PARAMETER thing was badly wrong. Remove the changes based on it. Using gentest is much more effective in this respect, but it will take a while to figure out the wildcard error handling of W2k3. Volker
* r20630: Fix some trivial memleaks.Günther Deschner2007-10-101-0/+3
| | | | Guenther
* r20628: Looks bigger than it is. This is just re-indenting the if (dirname) ↵Volker Lendecke2007-10-101-40/+38
| | | | | | | | that we've taken care of above. Volker
* r20627: orig_name is not needed anymore, and slightly simplify logic by ↵Volker Lendecke2007-10-101-9/+8
| | | | | | | | doing early returns. Volker
* r20626: Fix a memleak found by the IBM checker -- not on 3.0.24Volker Lendecke2007-10-101-0/+1
|
* r20619: bad_path is handled somewhere else, so can_delete does not need it ↵Volker Lendecke2007-10-101-11/+3
| | | | anymore
* r20618: Fix a bug in bad_path handling that also exists in 3.0.23: For ↵Volker Lendecke2007-10-101-0/+5
| | | | | | | | | | | | | | | reply_unlink under Linux we returned NT_STATUS_NOT_A_DIRECTORY. This is because in the bad_path==True condition lstat(2) returns ENOTDIR and not ENOENT. Not sure if we want to necessarily replicate the INVALID_PARAMETER here, but this is what W2k3 does. Jeremy, I tried to call you, but you were not around. So I'll leave it up to you to merge this. Volker
* r20617: Do not notify if the delete failedVolker Lendecke2007-10-101-5/+7
|
* r20614: Dummy-checkin to trigger the buildVolker Lendecke2007-10-101-4/+5
|
* r20612: A checkin I've wanted to do for ages: For bad_path==False ↵Volker Lendecke2007-10-103-50/+21
| | | | | | | | | set_bad_path_error is equivalent to UNIX_ERROR. Expand the last reference. Lets see if I can kill that as well :-) Volker
* r20611: All but one callers to set_bad_path_error have had the ↵Volker Lendecke2007-10-103-15/+29
| | | | | | | | bad_path==True argument being handled further up. Volker
* r20610: Fix a Solaris warningVolker Lendecke2007-10-101-1/+1
|
* r20608: ENOENT->NT_STATUS_OBJECT_NAME_NOT_FOUND is covered in the standard ↵Volker Lendecke2007-10-101-6/+2
| | | | unix error mapping table
* r20607: Next micro-step for reply_setatrVolker Lendecke2007-10-101-8/+6
|
* r20606: bad_path == True has been covered further up in reply_setatr.Volker Lendecke2007-10-101-1/+2
| | | | | | | | I'm checking in micro-steps to make them independently checkable. This code just very severely needs cleanup, but I don't want to break anything. So, be patient with me, please :-) Volker
* r20605: Simplify logic in reply_setatr slightlyVolker Lendecke2007-10-101-4/+2
|
* r20604: Fix two memleaks, Coverity ID 337, merge to 3_0_24Volker Lendecke2007-10-101-0/+2
|
* r20603: Slightly simplify logicVolker Lendecke2007-10-101-7/+7
|
* r20602: Fix coverity ID 339. SMB_ASSERT does not panic without -DDEVELOPER.Volker Lendecke2007-10-101-1/+4
| | | | Volker
* r20597: Survive some of the notify mask tests.Volker Lendecke2007-10-103-10/+24
|
* r20589: Re-add lost bad_path handling, sorry.Volker Lendecke2007-10-101-0/+4
|
* r20558: Refactor rmdir_internals to use early termination ratherJeremy Allison2007-10-101-55/+56
| | | | | | | than lots of indented code. Change recursive_rmdir() to return the smbd standards of True on success, False on fail (it was doing the reverse, which was very confusing). Jeremy.
* r20546: Fix some IBM checker errorsVolker Lendecke2007-10-101-0/+4
|
* r20544: Change copy_file() to return NTSTATUS. This is in preparation of turningVolker Lendecke2007-10-102-29/+41
| | | | | | | | | | | | | close_file() to NTSTATUS as well. I'm not sure I got all the error codes right, but as I've never come across a smb_copy() call in all my Samba work, I'm leaving it at that. If I'm absolutely bored, I will write a thorough torture test. As far as I can see, Samba4 even does not have a libcli implementation for it... :-) Volker
* r20542: Make close_remove_share_mode retun NTSTATUS. Not that anybody cares ↵Volker Lendecke2007-10-101-4/+16
| | | | yet...
* r20541: Fix some obvious glitches in wait_for_aio_completion. Hmmm. It seemsVolker Lendecke2007-10-101-6/+5
| | | | | | reply_close() at its heart is going to be an async call :-) Volker
* r20536: In the offline PAM session close case the attempt to delete aGünther Deschner2007-10-102-1/+7
| | | | | | non-existing krb5 credential cache should not generate an error. Guenther
* r20535: Fix make install to work when root doesn't haveJeremy Allison2007-10-101-3/+7
| | | | | | write access into the source tree (like when your directory is nfs mounted for example....). Jeremy.
* r20532: From Volker...Jeremy Allison2007-10-101-1/+1
| | | | | | | | | | "smbcli_setattr("") always returns ACCESS_DENIED, test extension to follow. Merge to 3.0.24?" Yep (with slight optimization). Jeremy.
* r20530: Don't want this call to get inadvertently re-added :-).Jeremy Allison2007-10-101-3/+0
| | | | Jeremy.
* r20525: Closing a dir with del-on-close set requires the same as files: ↵Volker Lendecke2007-10-101-0/+12
| | | | | | | | | | Don't actually unlink/rmdir if another process still has it open. Jeremy, this is a potential merger to 3.0.24. Volker
* r20524: Simplify logic of close_remove_share_mode().Volker Lendecke2007-10-101-51/+67
| | | | Volker
* r20512: Fix typo.Günther Deschner2007-10-101-1/+1
| | | | Guenther
* r20507: smbcli_setattr("") always returns ACCESS_DENIED, test extension to ↵Volker Lendecke2007-10-101-0/+9
| | | | | | | | follow. Merge to 3.0.24? Volker
* r20503: And one more 64-bit warningVolker Lendecke2007-10-101-1/+1
|
* r20502: Activate RAW-RENAME, my Linux box passes thisVolker Lendecke2007-10-101-1/+1
|
* r20501: Check in config.h fix from Michael Adam <ma@sernet.de>Volker Lendecke2007-10-102-0/+9
|
* r20500: Fix compiler warnings.James Peach2007-10-101-7/+7
|
* r20499: Activate RAW-OPEN in the build farmVolker Lendecke2007-10-101-1/+1
|
* r20498: Two 64-bit warningsVolker Lendecke2007-10-102-3/+5
|
* r20496: Some changes to make Samba3 the RAW-OPEN test. Checking in to both ↵Volker Lendecke2007-10-102-7/+14
| | | | | | | | | | | | | | | | | | | | | | 3_0 and 3_0_24 because I was explicitly asked to, although this needs close review. Jeremy, I'm sure you will check this thoroughly :-) In reply_open_and_X the separate "size" variable kills the calculation of the SPARSE flag returned to the client in the attrib field. In getpathinfo we do it correctly, and RAW-OPEN (correctly) complains about the difference. Add the "set the write time" to mknew and create. For trans2open we were missing the "ofun == 0" -> NT_STATUS_OBJECT_NAME_COLLISION case, and we dropped the status returned in favor of ACCESS_DENIED once too many. Last change is a fix to trans2open: We were returning the attributes given by the client, not the attributes of the new file. Volker
* r20489: Missed patch ofthe forest_name patch for lookupnameGerald Carter2007-10-101-4/+8
|
* r20488: When joined to a child domain in a multi-domain/single domain tree,Gerald Carter2007-10-103-6/+89
| | | | | | | the child domain cannot always resolve SIDs in sibling domains. Windows tries to contact a DC in its own domain and then the root domain in the forest. This async changes makes winbindd's name2sid() call do the same.
* r20487: Remove the unused dn2ad_canonical() callGerald Carter2007-10-102-19/+0
|
* r20486: Always upper case the "host/<sAMAccoutnName>" entry in the keytab fileGerald Carter2007-10-101-1/+6
| | | | so apps will know which one to look for,
* r20485: Add select with a 10 second timeout when reading DSN update responses.Gerald Carter2007-10-101-5/+19
|
* r20482: Make us survive and activate RAW-CLOSEVolker Lendecke2007-10-102-2/+2
|
* r20479: Both remaining calls of can_delete called it with ↵Volker Lendecke2007-10-101-26/+19
| | | | | | | | check_is_at_open==False, remove that parameter. Volker
* r20478: Make us survive & activate RAW-UNLINKVolker Lendecke2007-10-103-2/+5
|
* r20470: Jeremy, another one to check:Volker Lendecke2007-10-102-23/+20
| | | | | | | | | | | | | | | The only error path of can_delete() that we're interested in ntcreate&x is the one of can_delete_file_in_directory(), so call that directly. The only other one where we might get a NT_STATUS_ACCESS_DENIED is from the lstat in can_delete, but this is covered later in the open_directory and open_file_ntcreate calls. open_directory does a stat() in the open case which also covers the (potential) symlink, and open_file_ntcreate does the open(2) itself, so this should also work. This makes can_delete() static to reply.c. Volker