Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | String handling parinoia fixes. | Andrew Bartlett | 2003-03-15 | 12 | -166/+236 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch enables the compile-time checking of strings assable by means of sizeof(). (Original code had the configure check reversed). This is extended to all safe_strcpy() users, push_string and pull_string, as well as the cli and srv derivitives. There is an attempt to cap strings at the end of the cli buffer, and clobber_region() of the speified length (when not -1 :-). Becouse of the way they are declared, the 'overmalloc a string' users of safe_strcpy() have been changed to use overmalloc_safe_strcpy() (which skips some of the checks). This whole ball of mud worked fine, until I pulled out my 'fix' for our statcache. When jeremy fixes that, we should be able to get back to testing this stuff. This patch also includes a 'marker' of the last caller to clobber_region (ie, the function that called pstrcpy() that called clobber_region) to assist in debugging problems that may have smashed the stack. This is printed at smb_panic() time. (Original idea and patch by metze). It also removes some unsused functions, and #if 0's some others that are unused but probably should be used in the near future. For now, this patch gives us some confidence on one class of trivial parsing error in our code. Andrew Bartlett | ||||
* | Fix off-by-one bug in safe_strcpy size paramater. | Andrew Bartlett | 2003-03-15 | 1 | -1/+1 |
| | |||||
* | Truncate the machinename manually, so as not to generate level 0 debugs for | Andrew Bartlett | 2003-03-15 | 1 | -10/+12 |
| | | | | | | an expected situation. Andrew Bartlett | ||||
* | specify the size of these buffers | Andrew Bartlett | 2003-03-15 | 1 | -2/+2 |
| | |||||
* | If the server went away, don't segfault by attempting to FD_SET -1. | Andrew Bartlett | 2003-03-15 | 1 | -0/+3 |
| | | | | Andrew Bartlett | ||||
* | Specify buffer sizes | Andrew Bartlett | 2003-03-15 | 1 | -2/+2 |
| | |||||
* | Be parinoid, malloc an extra SAFETY_MARGIN on the client's inbuf and outbuf. | Andrew Bartlett | 2003-03-15 | 1 | -2/+2 |
| | | | | Andrew Bartlett | ||||
* | client-side smbpasswd fixes - use pstrcpy_base to avoid clobber_region bugs | Andrew Bartlett | 2003-03-15 | 1 | -6/+6 |
| | | | | Andrew Bartlett | ||||
* | Add const, and a signed/unsigned fix. | Andrew Bartlett | 2003-03-15 | 1 | -3/+3 |
| | |||||
* | If it's an fstring, use fstrcpy(). | Andrew Bartlett | 2003-03-15 | 1 | -8/+8 |
| | | | | Andrew Bartlett | ||||
* | Clean up the VFS module loading logic by making the parameter an P_LIST, | Andrew Bartlett | 2003-03-15 | 2 | -59/+36 |
| | | | | | | rather than a runtime-parsed string. Andrew Bartlett | ||||
* | Found by my new checking code (yet to be commited): | Andrew Bartlett | 2003-03-15 | 1 | -1/+1 |
| | | | | | | Allow a service longer than 4 characters in CORE tcon. Andrew Bartlett | ||||
* | strictly, you can't #if on somthing that may or may not be defined. | Andrew Bartlett | 2003-03-15 | 1 | -1/+1 |
| | | | | Andrew Bartlett | ||||
* | Now that mimir has done the grunt work, I'll fix up the comment | Andrew Bartlett | 2003-03-15 | 1 | -4/+1 |
| | |||||
* | fix WinXP & Win2K3 remote_arch and check pointer in ntlmssp code before ↵ | Gerald Carter | 2003-03-14 | 3 | -19/+37 |
| | | | | dereferencing | ||||
* | We haven't implemented The Singing Contexts so far. | Rafal Szczesniak | 2003-03-14 | 1 | -1/+1 |
| | | | | | | | Who knows what .NET server brings, though ...? ;-) Rafal | ||||
* | Extending code to work both in case of domain membership | Rafal Szczesniak | 2003-03-14 | 1 | -1/+1 |
| | | | | | | | | | and domain controller respecting interdomain trust relationships. In the latter case we need to find DC of remote domain instead of ours. In the former 'domain' is our domain name. Rafal | ||||
* | Fresh meat in trusted domains code: | Rafal Szczesniak | 2003-03-14 | 4 | -59/+201 |
| | | | | | | | | | | | | | | | - packing/unpacking utility functions for trusted domain password struct; can be used to prepare buffer to store in secrets.tdb or (soon) passdb backend - similiar functions for DOM_SID - respectively modified secrets_(fetch|store) routines - new auth mapping code utilising introduced is_trusted_domain function - added tdb (un)packing of single bytes Rafal | ||||
* | /tmp/newfun.msg | Rafal Szczesniak | 2003-03-14 | 2 | -5/+63 |
| | |||||
* | Found by metze with the clobber-region check - if it's a pstring, use pstrcpy(). | Andrew Bartlett | 2003-03-14 | 1 | -1/+1 |
| | | | | Andrew Bartlett | ||||
* | Add examples of ComfyChair | Martin Pool | 2003-03-14 | 1 | -0/+33 |
| | |||||
* | Merge from Subversion | Martin Pool | 2003-03-14 | 1 | -2/+2 |
| | | | | * Better report formatting | ||||
* | Add bin/libbigballofmud.a non-shared library. A bit easier to link to | Martin Pool | 2003-03-13 | 1 | -0/+4 |
| | | | | for testing than the .so. (http://www.laputan.org/mud/mud.html) | ||||
* | In Valgrind 1.9.4, the headers have moved to <valgrind/valgrind.h>, | Martin Pool | 2003-03-13 | 1 | -3/+7 |
| | | | | | etc. So check for that as well as the old names when including macros and conditionally defining -DVALGRIND. | ||||
* | In Valgrind 1.9.4, the headers have moved to <valgrind/valgrind.h>, | Martin Pool | 2003-03-13 | 1 | -1/+4 |
| | | | | etc. So check for that as well as the old names. | ||||
* | Added chainlock, chainunlock, lock_bystring and unlock_bystring methods. | Tim Potter | 2003-03-13 | 1 | -1/+81 |
| | |||||
* | Fixed crash bug when calling tdb_unlockkeys() with no locked keys. | Tim Potter | 2003-03-13 | 1 | -0/+2 |
| | | | | woot! | ||||
* | show which files we fail to create in the casetable test | Andrew Tridgell | 2003-03-13 | 1 | -2/+5 |
| | |||||
* | fixed the unmarshalling of the queryaliasmem SAMR call | Andrew Tridgell | 2003-03-13 | 1 | -2/+6 |
| | |||||
* | win2000 can take much longer than the specified time to respond to a | Andrew Tridgell | 2003-03-13 | 1 | -1/+1 |
| | | | | | lock - so to make the torture tests valid I give it a grace time of 10 seconds instead of 2 | ||||
* | Change size parameters from signed to unsigned to fix up warnings. | Jeremy Allison | 2003-03-12 | 5 | -96/+191 |
| | | | | Jeremy. | ||||
* | fixed a strcat noticed by metze | Andrew Tridgell | 2003-03-12 | 1 | -1/+1 |
| | |||||
* | Ensure we count the length correctly in mangle_map. | Jeremy Allison | 2003-03-12 | 1 | -6/+15 |
| | | | | Jeremy. | ||||
* | adding some initiaial code to sert %a to Win2K3 (using Native LanMan string ↵ | Gerald Carter | 2003-03-12 | 3 | -1/+6 |
| | | | | from .NET RC2) | ||||
* | Add const | Andrew Bartlett | 2003-03-12 | 1 | -2/+2 |
| | |||||
* | - Fix a double-free (I can't say I understand the code, but it matches the ↵ | Andrew Bartlett | 2003-03-12 | 1 | -6/+5 |
| | | | | | | | | | | other cases and keeps valgrind quiet). - Add static Andrew Bartlett | ||||
* | Patch from Ken Cross <kcross@nssolutions.com> to take a username in the form | Andrew Bartlett | 2003-03-12 | 1 | -0/+11 |
| | | | | | | of user@realm for kerberos logins. Andrew Bartlett | ||||
* | Update for new version of ComfyChair: some methods are renamed to be | Martin Pool | 2003-03-12 | 1 | -9/+14 |
| | | | | | | | more consistent, and it now looks at command-line arguments to work out what to do. Run this program to get a quick demonstration of what ComfyChair does. | ||||
* | New import of ComfyChair, many changes | Martin Pool | 2003-03-12 | 1 | -75/+139 |
| | |||||
* | Import Samba Testing Framework code from private CVS module. | Martin Pool | 2003-03-12 | 4 | -0/+472 |
| | |||||
* | Import design notes by martin and tpot from ComfyChair and stf modules. | Martin Pool | 2003-03-12 | 1 | -0/+175 |
| | |||||
* | Import ComfyChair framework from trunk. | Martin Pool | 2003-03-12 | 1 | -0/+266 |
| | |||||
* | Start importing the Python testing framework that Tim and I have been | Martin Pool | 2003-03-12 | 1 | -0/+3 |
| | | | | working on into the main Samba tree. | ||||
* | Update usage message. | Martin Pool | 2003-03-12 | 1 | -1/+2 |
| | |||||
* | Add example of string overflow which is now caught in developer mode. | Martin Pool | 2003-03-12 | 1 | -0/+16 |
| | |||||
* | We use unsigned now, so use %u. | Jeremy Allison | 2003-03-11 | 1 | -1/+1 |
| | | | | Jeremy. | ||||
* | Fix up zero termination. Spotted by Sebastian Krahmer <krahmer@suse.de>. | Jeremy Allison | 2003-03-11 | 1 | -1/+2 |
| | | | | Jeremy. | ||||
* | This patch attemptes to clean up winbindd's mutex locking. | Andrew Bartlett | 2003-03-11 | 3 | -68/+46 |
| | | | | | | | | | | | | | | | | | | | | | | | | | The current locking scheme in winbind is a complete mess - indeed, the next step should be to push the locking into cli_full_connection(), but I'll leave it for now. This patch works on the noted behaviour that 2 parts of the connection process need protection - and independent protection. Tim Potter did some work on this a little while back, verifying the second case. The two cases are: - between connect() and first session setup - during the auth2 phase of the netlogon pipe setup. I've removed the counter on the lock, as I fail to see what it gains us. This patch also adds 'anonymous fallback' to our winbindd -> DC connection. If the authenticated connection fails (wbinfo -A specifed) - say that account isn't trusted by a trusted DC - then we try an anonymous. Both tpot and mbp like the patch. Andrew Bartlett | ||||
* | security=domain and domain logons = yes should be a BDC (of sorts). | Andrew Bartlett | 2003-03-11 | 1 | -2/+5 |
| | | | | | | Matches 2.2 Andrew Bartlett | ||||
* | Some further tought on the server role issue - try not to break it compeatly. | Andrew Bartlett | 2003-03-11 | 1 | -3/+6 |
| | | | | Andrew Bartlett |