summaryrefslogtreecommitdiffstats
path: root/source
Commit message (Collapse)AuthorAgeFilesLines
...
* r23524: Fix bug 2319.Simo Sorce2007-06-161-13/+60
| | | | | | Got report this is all ok form a tester. Close a loong standing bug preventing people to freely use any character in their password when printing via cups were involved.
* r23518: Remove the silly assumption that string_replace requires a pstring.Volker Lendecke2007-06-162-23/+47
| | | | | | | | Jeremy, I am always very confused about the different length arguments in convert_string and friends. Can you take a look at the change in string_replace and verify it's ok? Thanks! While at it, remove the pstring limit for strhasupper and strhaslower.
* r23517: After Jeremy has given is ack on irc:Volker Lendecke2007-06-161-179/+61
| | | | | | | | Change rename_internals to open the file/directory and then call rename_internals_fsp. Two reasons: Remove code duplication and remove a race condition. The race condition was due to the fact that in can_rename the share mode check closed the file and then after that did the rename.
* r23516: Fix bug found & fixed by Doug Rudoff (doug_rudoff@isilon.com)Jeremy Allison2007-06-161-0/+6
| | | | | | | - when cleaning up invalid locks make sure we mark the lck struct as modified so it'll get saved back correctly (that was the original intent). Jeremy.
* r23515: Ensure status isn't used uninitialized.Jeremy Allison2007-06-161-1/+1
| | | | Jeremy.
* r23514: Remove unused function ads_get_dn_from_extended_dn().Jeremy Allison2007-06-161-29/+0
| | | | Jeremy.
* r23513: Fix one more use of VALUE_PREFIX.Jeremy Allison2007-06-151-1/+1
| | | | Jeremy.
* r23512: Fix conflict in #define for SECDESC_PREFIX. Ensure allJeremy Allison2007-06-152-7/+7
| | | | | | reg #defines use "REG_" prefix. Michael - please check gcc warnings on compiles. Jeremy.
* r23511: Merge branches/SAMBA_3_0@23510James Peach2007-06-1533-113/+120
| | | | | Tidy calls to smb_panic by removing trailing newlines. Print the failed expression in SMB_ASSERT.
* r23509: This activates the global options from the registry in loadparm. Michael Adam2007-06-155-12/+305
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The global options are stored as values in the subkey "global" of the SMBCONF registry key. The activation is accomplished in smb.conf though a new special semantic of the "include" parameter: "include = registry" triggers the processing of the registry global options exactly at the position of the include statement. Options read from the registry take the same precedence as parameters loaded from a file via include. Need to reload the registry globals is detected by watching the tdb sequence number. Registry shares are automatically activated when the registry globals are processed. So a "registry only" configuration can be realized by an smb.conf that looks as follows: ================================ [global] include = registry ================================ The global options and registry shares can be conveniently edited with the "net conf" utility. Caveat: A possible pitfall consists in using "include = registry" together with the "lock directory" directive in the registry. This problem will be addressed in the next time. Note on the code: Processing of the registry options is accomplished by a function process_registry_globals() in loadparm.c The current version is only an interim solution: It is handcoded instead of using the infrastructure of reg_api.c. The reason for this is that using reg_api still has too large linker dependencies, bloating virtually all targets by PASSDB_OBJ, SMBLDAP_OBJ, GROUPDB_OBJ and LDB stuff. A version of process_registry_globals that uses reg_api is included but commented out. The goal is to eventually refactor and restructure the registry code so that one can use the reg_api to access only the registry tdb and not link all the dynamic backends with all their linking implications.
* r23508: Fix sync_file() to return NTSTATUS and return thisJeremy Allison2007-06-153-13/+69
| | | | | on failure in the write path. Jeremy.
* r23507: Split one general function normalize_dbkey from reg_db.c into util_reg.cMichael Adam2007-06-152-7/+7
| | | | | | (To be used in other place in subsequent commit.) Michael
* r23504: Use tdb_wrap_open (instead of usual tdb_open) in reg_db.Michael Adam2007-06-151-27/+22
| | | | | | | This eliminates the need of maintaining reg_db's own reference counter for the tdb. Maybe as a next step... Michael
* r23501: Move notify_rename before rename_internals_fsp and call it from there.Volker Lendecke2007-06-141-42/+44
|
* r23500: Two changes to survive the now activated test for rename_internals_fsp:Volker Lendecke2007-06-143-6/+17
| | | | | With the target being open we have to return NT_STATUS_ACCESS_DENIED and root_fid != 0 leads to NT_STATUS_INVALID_PARAMETER
* r23499: merge libaddns build defaults from SAMBA_3_0Gerald Carter2007-06-141-19/+4
|
* r23498: remove libmsrpc files (still exists in SAMBA_3_0 but not built by ↵Gerald Carter2007-06-149-7099/+0
| | | | default)
* r23496: Fix logic error in getgrnam_recv() that brokeGerald Carter2007-06-141-1/+1
| | | | getgrnam() for machine and domain local groups.
* r23495: Replace literal occurrences of libsmb/errormap.o by $(ERRORMAP_OBJ).Michael Adam2007-06-141-2/+2
|
* r23494: Synchronize some occurrences of BINARY_PREREQS and bin/.dummy.Michael Adam2007-06-141-8/+13
| | | | | | | Further reduce the diff between 3_0 and 3_0_26 by some reformatting and rearrangements. Michael
* r23489: (Re-)Add tdbtorture as a build target to 3_0_26.Michael Adam2007-06-142-1/+13
| | | | | | Add the tdbtorture test to the test script in 3_0 and 3_0_26. Michael
* r23486: Ok, this time with a hopefully successful make test in the right place:Volker Lendecke2007-06-142-22/+33
| | | | Remove two local variables
* r23485: This checkin consists mostly of refactorings in preparation of theMichael Adam2007-06-1410-679/+872
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | activation of global registry options in loadparm.c, mainly to extract functionality from net_conf.c to be made availabel elsewhere and to minimize linker dependencies. In detail: * move functions registry_push/pull_value from lib/util_reg.c to new file lib/util_reg_api.c * create a fake user token consisting of builtin administrators sid and se_disk_operators privilege by hand instead of using get_root_nt_token() to minimize linker deps for bin/net. + new function registry_create_admin_token() in new lib/util_reg_smbconf.c + move dup_nt_token from auth/token_util.c to new file lib/util_nttoken.c + adapt net_conf.c and Makefile.in accordingly. * split lib/profiles.c into two parts: new file lib/profiles_basic.c takes all the low level mask manipulation and format conversion functions (se_priv, privset, luid). the privs array is completely hidden from profiles.c by adding some access-functions. some mask-functions are not static anymore. Generally, SID- and LUID-related stuff that has more dependencies is kept in lib/profiles.c * Move initialization of regdb from net_conf.c into a function registry_init_regdb() in lib/util_reg_smbconf.c. Michael
* r23483: Revert 23482, I must have run 'make test' in the wrong subdir.Volker Lendecke2007-06-141-14/+18
|
* r23482: Slightly simplify the rename code: Remove two local variables that areVolker Lendecke2007-06-141-18/+14
| | | | not really needed.
* r23479: Merge branches/SAMBA_3_0@23478James Peach2007-06-142-9/+51
| | | | | | | | Change the handling of the developer CFLAGS so that they are always emited to the Makefile in the DEVELOPER_CFLAGS variable. This makes it easy to turn developer mode on and off without waiting for configure to run. The developer flags are only added to CFLAGS for the --enable-developer and --enable-krb5developer cases.
* r23477: Build farm fix: Use int rather than MIT's krb5_int32 when setting ↵Gerald Carter2007-06-131-1/+1
| | | | context flags.
* r23476: Merge branches/SAMBA_3_0@23475James Peach2007-06-131-2/+2
| | | | | Fix the prototype for sys_broken_setgroups and log *BSD group list truncation a bit more verbosely.
* r23474: Here's a small patch that disables the libkrb5.so replay cache Gerald Carter2007-06-134-42/+68
| | | | | | | | | | | | | | | | | | when verifying a ticket from winbindd_pam.c. I've found during multiple, fast, automated SSH logins (such as from a cron script) that the replay cache in MIT's krb5 lib will occasionally fail the krb5_rd_req() as a replay attack. There seems to be a small window during which the MIT krb5 libs could reproduce identical time stamps for ctime and cusec in the authenticator since Unix systems only give back milli-seconds rather than the micro-seconds needed by the authenticator. Checked against MIT 1.5.1. Have not researched how Heimdal does it. My thinking is that if someone can spoof the KDC and TDS services we are pretty hopeless anyways.
* r23473: Merge Merge branches/SAMBA_3_0@23470James Peach2007-06-131-2/+8
| | | | | | Fix supplementary group list truncation for *BSD. We need to pass the correct group list length and only truncate to NGROUPS_MAX if it is too long.
* r23471: Here's a rough patch for expanding domain group membershipGerald Carter2007-06-133-155/+351
| | | | | | | | | | | | in the winbindd_getgrnam() call. Couple of comments: * Adds "winbind expand groups" parameter which defines the max depth winbindd will expand group members. The default is the current behavior of one level of expansion. * The entire getrgnam() interface should be async. I haven't done that. * Refactors the domain users hack in fill_grent_mem() into its own function.
* r23469: Fix a commentVolker Lendecke2007-06-131-1/+1
|
* r23468: Open registry.tdb with sequence number.Michael Adam2007-06-131-3/+15
| | | | | | | | | Add a function to retrieve the registry db sequence number. This is in preparation of loadparm integration of registry global smb.conf options: this will allow to detect changes in order to trigger reload. Michael
* r23467: Next little simplification: In rename_internals it's a bit pointless toVolker Lendecke2007-06-131-38/+13
| | | | | | first ask for existence of a file when we do the open_file_ntcreate in can_rename later on anyway. That also gets us the right error message in case the file is not there automatically.
* r23466: Fix RAW-NOTIFY: by using delete on close the notify is triggered deepVolker Lendecke2007-06-131-6/+0
| | | | inside close_file() already.
* r23465: There was this diff between reg_printing in 3_0 and 3_0_26:Michael Adam2007-06-131-1/+4
| | | | | | | | | | | before writing to secdesc_buf->sd, 3_0 checked secdesc_buf->sd while 3_0_26 checked secdesc_buf->sd_size. This patch makes both revisions check _both_ befor writing. Jerry / Jeremy : please check if this is correct! Michael
* r23464: Merge r19913 from 3_0:Michael Adam2007-06-131-1/+1
| | | | Fix a const warning.
* r23463: Merge r19853 and r19858 from 3_0:Michael Adam2007-06-131-1/+6
| | | | fix a memleak, add a const, update a link
* r23462: Merge r20209 from 3_0:Michael Adam2007-06-131-4/+7
| | | | Fix two memleaks.
* r23461: More or less merge r21977 from 3_0:Michael Adam2007-06-131-4/+2
| | | | | | little cosmetic change to remove a local var that's not really needed Michael
* r23457: After Jeremy's ack:Volker Lendecke2007-06-131-24/+29
| | | | | | | | | | | | | | The attached patch removes a little race condition for people with real kernel oplock support, and reduces some code paths. It changes reply_unlink to open_file_ntcreate, set_delete_on_close and close_file. The race condition happens if we break the oplock in can_delete via open_file_ntcreate, we close the file, someone else gets a batch oplock and we try to unlink. It reduces code paths by calling SMB_VFS_UNLINK in 2 fewer places.
* r23454: Merge r20018 from 3_0:Michael Adam2007-06-121-2/+4
| | | | Fix a memleak in reg_createkey
* r23453: fetch_reg_keys_specific and fetch_reg_values_specific are nowMichael Adam2007-06-123-111/+138
| | | | | | | | | only used in rpc_server/srv_winreg_nt.c. By moving them to a module of their own, this patch reduces the diff between the registry code of 3_0 and 3_0_26 even more. Michael
* r23452: Merge r22135 and r22496 from 3_0:Michael Adam2007-06-127-351/+1518
| | | | | | | | | | | | | | | | | | | * Refactor the code in registry/ essentially by moving functions around and creating a new reg_frontend_hilvl.c to minimize the linker dependencies for parts of the registry code. This initial refactoring allows to link registry code to e.g. "bin/net" * Add the "net conf" utility: It gives convenient local acces to the HKLM\Software\Samba\smconf key in the registry, where the samba registry shares are stored. * make reg_enumvalue return WERR_NO_MORE_ITEMS instead of WERR_BAD_FILE when all items have been successfully enumerated. Besides seeming the reasonable code to return, this is what I have seen from w2k3, w2k, wxp. (r22496) Michael
* r23451: Merge r20626 from 3_0:Michael Adam2007-06-121-0/+1
| | | | | | Fix a memleak found by the IBM checker. Michael
* r23450: max_params_return is complete fiction when getting a changenotifyJeremy Allison2007-06-122-18/+6
| | | | | | request. Ignore it. Should fix bug #4689 but more tests and valgrinding will follow. Jeremy.
* r23448: Doh ! Don't call winbind_child_died() *before* theJeremy Allison2007-06-121-7/+6
| | | | | kill call as that sets pid = 0 ! :-). Jeremy.
* r23447: Add kill signal to child dead path. After talkingJeremy Allison2007-06-121-0/+3
| | | | | to Jerry add to 3.0.25b. Jeremy.
* r23446: Restore Jeremy's original formatting, just fix the comment.Volker Lendecke2007-06-121-21/+17
|
* r23445: Fix suggested by Volker. Don't call rename_open_filesJeremy Allison2007-06-121-2/+0
| | | | | if the name wasn't changed. Jeremy.