summaryrefslogtreecommitdiffstats
path: root/source
Commit message (Collapse)AuthorAgeFilesLines
* Fix for CVE-2009-2906.v3-0-testJeremy Allison2009-10-012-4/+17
| | | | | | | | | Summary: Specially crafted SMB requests on authenticated SMB connections can send smbd into a 100% CPU loop, causing a DoS on the Samba server. (cherry picked from commit dff54f716bdd76e3d167dc96bba6e168ef58cadd)
* Fix for CVE-2009-2813.Karolin Seeger2009-10-012-2/+16
| | | | | | | | | | | | | | | | =========================================================== == Subject: Misconfigured /etc/passwd file may share folders unexpectedly == == CVE ID#: CVE-2009-2813 == == Versions: All versions of Samba later than 3.0.11 == == Summary: If a user in /etc/passwd is misconfigured to have == an empty home directory then connecting to the home == share of this user will use the root of the filesystem == as the home directory. =========================================================== (cherry picked from commit c1a4a99f8cc5803682a94060efee1adf330c4f02)
* mount.cifs: don't leak passwords with verbose optionJeff Layton2009-10-011-20/+34
| | | | | | | | | | | | | | | | | | | | | | | When running mount.cifs with the --verbose option, it'll print out the option string that it passes to the kernel...including the mount password if there is one. Print a placeholder string instead to help ensure that this info can't be used for nefarious purposes. Also, the --verbose option printed the option string before it was completely assembled anyway. This patch should also make sure that the complete option string is printed out. Finally, strndup passwords passed in on the command line to ensure that they aren't shown by --verbose as well. Passwords used this way can never be truly kept private from other users on the machine of course, but it's simple enough to do it this way for completeness sake. Reported-by: Ronald Volgers <r.c.volgers@student.utwente.nl> Signed-off-by: Jeff Layton <jlayton@redhat.com> Acked-by: Steve French <sfrench@us.ibm.com> Part 2/2 of a fix for CVE-2009-2948. (cherry picked from commit 1c2a816df9fd9e3a3839a679a72b3041b0217dc3)
* mount.cifs: check access of credential files before openingJeff Layton2009-10-011-0/+11
| | | | | | | | | | | | | | | | It's possible for an unprivileged user to pass a setuid mount.cifs a credential or password file to which he does not have access. This can cause mount.cifs to open the file on his behalf and possibly leak the info in the first few lines of the file. Check the access permissions of the file before opening it. Reported-by: Ronald Volgers <r.c.volgers@student.utwente.nl> Signed-off-by: Jeff Layton <jlayton@redhat.com> Acked-by: Steve French <sfrench@us.ibm.com> Part 1/2 of a fix for CVE-2009-2948. (cherry picked from commit 87fe29ca3239492126a99e1562db673ea7ca208b)
* Raise version number up to 3.0.37.Karolin Seeger2009-10-011-1/+1
| | | | | Karolin (cherry picked from commit 4e6a1f8a6b1382504699b94e24809704dd3952bb)
* Makefile.in: Fix installation of cifs.upcall.Karolin Seeger2009-08-041-3/+3
| | | | | | INSTALLPERMS_BIN does not exist. Karolin
* VERSION: Raise version number up to 3.0.36.Karolin Seeger2009-06-291-1/+1
| | | | Karolin
* VERSION: Raise version number to 3.0.35.Karolin Seeger2009-06-291-1/+1
| | | | | Karolin (cherry picked from commit 857b6fb063b9968134cc664430ff5d33a992da4a)
* Fix bug #6488.Jeremy Allison2009-06-291-0/+2
| | | | (cherry picked from commit 689b313404971bb884566710b1468b9bd4091caa)
* Workaround for KB932762Volker Lendecke2009-06-271-1/+3
|
* Add comment explaining the previous fix. (and fix the previous patch :-).Jeremy Allison2009-04-221-1/+8
| | | | | By-hand merge error :-). Jeremy.
* Fix bug #6279 - winbindd crash. Cope with LDAP libraries returning ↵Jeremy Allison2009-04-221-0/+4
| | | | | | LDAP_SUCCESS but not returning a result. Jeremy
* prevent segmentation fault on joining a very long domain name in samba-3.0.32Bhaskar Jain (bhajain)2009-03-201-1/+1
| | | | | For a detailed explanation, see http://lists.samba.org/archive/samba-technical/2009-March/063626.html
* Get the sense of the integer wrap test the right way around. Sorry.Jeremy Allison2009-03-051-1/+1
| | | | Jeremy.
* Now we're allowing a lower bound for auth_len, ensure weJeremy Allison2009-03-051-1/+5
| | | | | also check for an upper one (integer wrap). Jeremy.
* Complete the fix for bug 6100Volker Lendecke2009-03-051-1/+1
| | | | | | | | | | | | | | | | | | According to [MS-RPCE].pdf, section 2.2.2.11: ---- A client or a server that (during composing of a PDU) has allocated more space for the authentication token than the security provider fills in SHOULD fill in the rest of the allocated space with zero octets. These zero octets are still considered to belong to the authentication token part of the PDU.<36> ---- RPC implementations are allowed to send padding bytes at the end of an auth footer. Windows 7 makes use of this. Thanks to Nick Meier <nmeier@microsoft.com> Volker
* Fix bug in processing of open modes in POSIX open.Jeremy Allison2009-02-251-0/+2
| | | | | | | | | | Was missing case of "If file exists open. If file doesn't exist error." Damn damn damn. CIFSFS client will have to have fallback cases for this error for a long time. Make test for open modes more robust against other bits. Jeremy.
* Fix guest mountsSteve French2009-02-241-1/+3
| | | | | | | | | guest session setup, login (user id) as anonymous. This patch is for samba bugzilla bug 4640. Signed-off-by: Shirish Pargaonkar <shirishp@us.ibm.com> Acked-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <sfrench@samba.org>
* Fix mount.cifs handling of -V option (to display version)Steve French2009-02-241-196/+228
| | | | | | | Also sync with current mount.cifs Acked-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <sfrench@samba.org>
* prefer gssapi header files from subdirectoryBjörn Jacke2009-02-242-6/+6
| | | | | | this fixes some compile time noise on FreeBSD 7 (cherry picked from commit 1bfdbb093f7c5e434ea3e653d389e1ccec578af6) (cherry picked from commit de96e1a82d6e92c00a0ab3020db8d7c0284aadb1)
* Attempt to fix bug #6099. According to MicrosoftJeremy Allison2009-02-152-26/+83
| | | | | | | | | | Windows 7 looks at the negotiate_flags returned in this structure *even if the call fails with access denied ! So in order to allow Win7 to connect to a Samba NT style PDC we set the flags before we know if it's an error or not. Jeremy.
* Noted by Vericode analysis. Correctly use chroot().Jeremy Allison2009-02-131-2/+9
| | | | Jeremy.
* Fix bug #6098 - When the DNS server is invalid, the ads_find_dc() does not ↵Yasuma Takeda2009-02-111-2/+2
| | | | | | | | | | | work correctly with "security = domain" 1. If DNS server is invalid, the get_sorted_dc_list() is called with realm(FQDN) and it fails. 2. On the next step, the get_sorted_dc_list() is called with realm(FQDN) again. I think "again" is wrong place. On the 2nd step, get_sorted_dc_list() should be called with realm(WORKGROUP).
* Fix bug #5906 - Winbindd crash on 'getent group' (INTERNAL ERROR: Signal 11).Jeremy Allison2009-02-111-2/+2
| | | | | Was missed in the last maintenence release. Jeremy.
* mount.cifs: add fakemount (-f) and nomtab (-n) flags to mount.cifsShirish Pargaonkar2009-02-061-5/+10
| | | | ...so that these options work correctly when passed in by mount(8).
* Don't try and delete a default ACL from a file.Günter Kukkukk2009-02-051-4/+8
|
* umount.cifs: clean-up entries in /etc/mtab after unmountShirish Pargaonkar2009-02-051-1/+33
| | | | | | | | This patch removes the remaining entry in /etc/mtab after a filesystem is unmounted by canonicalizing the mountpoint supplied on the command line. Please refer to bug 4370 in samba bugzilla.
* Fix bug #6085 - In vfs_default.c change utime( ) call.Miguel Suarez2009-02-031-1/+1
|
* Probably fixes a crash during name resolution when log level >= 10Ted Percival2009-02-031-1/+1
| | | | | and libc segfaults if printf is passed NULL for a "%s" arg (eg. Solaris).
* Adjust regex to match variable names including underscoresLars Müller2009-02-021-1/+1
| | | | | This is required to get the CIFSUPCALL_PROGS setting extracted from config.log.
* Conditional install of the cifs.upcall man pageLars Müller2009-02-021-0/+1
| | | | | Only install the cifs.upcall man page if CIFSUPCALL_PROGS was set while configure.
* build: don't install the cifs.upcall binary twice.Günther Deschner2009-02-021-1/+1
| | | | Guenther
* libreplace: fix detection of netinet/ip.h on solaris 8Michael Adam2009-01-271-1/+5
| | | | | | (The test needs to additionally include <netinet/in_systm.h>.) Michael
* libreplace: fix bug #6066 - netinet/ip.h present but cannot be compiledMichael Adam2009-01-271-1/+4
| | | | | | under solaris Michael
* Apply same logic fix for #4308 Excel save operation corrupts file ACLsJeremy Allison2009-01-221-45/+34
| | | | | to NFSv4 ACL code as this uses the same flawed logic as posix_acls.c. Jeremy.
* Fix logic error in try_chown - we shouldn't arbitrarily chownJeremy Allison2009-01-221-6/+9
| | | | | to ourselves unless that was passed in. Jeremy.
* Second part of the attemt to fix #4308 - Excel save operation corrupts file ↵Jeremy Allison2009-01-221-124/+140
| | | | | | | | ACLs. If the chown succeeds then the ACL set should also. Ensure this is the case (refactor some of this code to make it simpler to read also). Jeremy.
* Another attempt to fix bug #4308 - Excel save operation corrupts file ACLs.Jeremy Allison2009-01-221-27/+0
| | | | | | | | | | | | | | | | | | | | Simo is completely correct. We should be doing the chown *first*, and fail the ACL set if this fails. The long standing assumption I made when writing the initial POSIX ACL code was that Windows didn't control who could chown a file in the same was as POSIX. In POSIX only root can do this whereas I wasn't sure who could do this in Windows at the time (I didn't understand the privilege model). So the assumption was that setting the ACL was more important (early tests showed many failed ACL set's due to inability to chown). But now we have privileges in smbd, and we must always fail an ACL set when we can't chown first. The key that Simo noticed is that the CREATOR_OWNER bits in the ACL incoming are relative to the *new* owner, not the old one. This is why the old user owner disappears on ACL set - their access was set via the USER_OBJ in the creator POSIX ACL and when the ownership changes they lose their access. Patch is simple - just ensure we do the chown first before evaluating the incoming ACL re-read the owners. We already have code to do this it just wasn't rigorously being applied. Jeremy.
* Fix bug #6035 - Possible race between fcntl F_SETLKW and alarm delivery.Jeremy Allison2009-01-141-1/+1
| | | | Jeremy.
* VERSION: Raise version number up to 3.0.34.Karolin Seeger2009-01-141-1/+1
| | | | Karolin
* Fix bug #6019 File corruption in Clustered SMB/NFS environment managed via CTDBJeremy Allison2009-01-132-4/+4
| | | | Jeremy.
* s3:libsmb: handle the smb signing states the same in the krb5 and ntlmssp casesStefan Metzmacher2009-01-121-16/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | SMB signing works the same regardless of the used auth mech. We need to start with the temp signing ("BSRSPYL ") and the session setup response with NT_STATUS_OK is the first signed packet. Now we set the krb5 session key if we got the NT_STATUS_OK from the server and then recheck the packet. All this is needed to make the fallback from krb5 to ntlmssp possible. This commit also resets the cli->vuid value to 0, if the krb5 auth didn't succeed. Otherwise the server handles NTLMSSP packets as krb5 packets. The restructuring of the SMB signing code is needed to make sure the krb5 code only starts the signing engine on success. Otherwise the NTLMSSP fallback could not initialize the signing engine (again). metze (cherry picked from commit 7d9fd64f38aa5821b38c1223cf87979fc87bfb71) (cherry picked from commit 8e29070ccd0b5103af2e6da75644169f46700313) (cherry picked from commit 38b297f99ec166e5c40ba33774222b37b45b4fec) (a little bit modified to compile in v3-0)
* VERSION: Set vendor suffix to "test" according to the other branches.Karolin Seeger2009-01-121-1/+1
| | | | Karolin
* Fix null pointer refrence in event context in backport from v3-3-testBo Yang2009-01-111-2/+6
| | | | Signed-off-by: Bo Yang <boyang@novell.com>
* Fix logic bug introduce in backport of ccache_regain_all_now, sync withJeremy Allison2009-01-101-16/+23
| | | | | 3.3 implementation. Jeremy.
* Backport of the clean event context after fork andBo Yang2009-01-106-164/+452
| | | | krb5 refresh chain fixes.
* Don't set child->requests to NULL in parent after forkBo Yang2009-01-101-1/+0
|
* Fix race condition in alarm lock processing noticed by Richard Sharpe ↵Jeremy Allison2009-01-081-1/+1
| | | | | | | | | | | | | | | <realrichardsharpe@gmail.com>. "It seems to me that if the lock is already held by another process when we enter this code, there is a race between the timeout and the granting. If the lock is subsequently granted, the process releasing the lock will signal the wait variable (or whatever) and our process will be scheduled. However, if the timeout occurs before we are scheduled, the timeout will be delivered first. We will have the lock but will forget we have the lock, and never release it." Jeremy.
* s3/swat: Fix creation of the first share using SWAT.Volker Lendecke2009-01-061-1/+1
| | | | | | This fixes bug #5965. (cherry picked from commit f76614169f1e0a932cf2895702cfa9e8a5735875) (cherry picked from commit 148437fcd0896591ebbf6c2808723575d025123f)
* Happy New Year!Stefan Metzmacher2009-01-021-1/+1
| | | | metze