summaryrefslogtreecommitdiffstats
path: root/source
Commit message (Collapse)AuthorAgeFilesLines
...
* Revert "Fix a memleak in svcctl_init_keys()"Volker Lendecke2008-06-181-10/+1
| | | | | | | | This reverts commit b1afb31f3cadd4749bf6e3eb5d8935588bf8ebfc. This one is very strange: I need to investigate why valgrind showed it as leaking, and why in my initial tests this did not fail. (cherry picked from commit 24730f5981efb920811e7929a9483bd72bb0984c)
* Fix Bug #5548 (segfauls in handle_include with %m macro expansion).Michael Adam2008-06-181-1/+4
| | | | | | | | | | In alloc_sub_basic, when expanding '%m', substitute "" instead of NULL for remote_machine when this is NULL. Else a NULL string is returned. Michael (cherry picked from commit c65b456c6a145d15b7fd27a2a3440a0709fc3277) (cherry picked from commit ffaed197d8cb261e2765b2de6cad17cac7d49672)
* Fix a brown paper bag segfault in clitarVolker Lendecke2008-06-182-2/+2
| | | | | | | Thanks to "No Body is Perfect" from gmail, whoever that is :-) Volker (cherry picked from commit 679d8dfa390601f777bfb43c02cd921eae5edcf4)
* Fix a memleak in svcctl_init_keys()Volker Lendecke2008-06-171-1/+10
| | | | (cherry picked from commit 675bb53398ba29c53d2dcf3c7122cf4770c2f938)
* Fix a segfault in wbcLookupSidVolker Lendecke2008-06-171-19/+29
| | | | | | | | | | | | | | If the BAIL_ON_WBC_ERROR directly after wbcRequestResponse kicks in, *domain and *name have not been initialized yet. So the cleanup routine in the done: part of the routine (which did not check for domain!=NULL etc) would access uninitialized memory. Jerry, please check! Thanks, Volker (cherry picked from commit 3d7e0cc40b1992f4555807acec4f00450e30e2de)
* Fix a segfault in wbcLookupRidsVolker Lendecke2008-06-171-16/+21
| | | | | | | | | | | | The done: part could access uninitialized memory if intermediate BAIL_ON_WBC_ERROR fire. Jerry, please check! Thanks, Volker (cherry picked from commit 31f4c33dcc744e81be54389756378e25aa2bb75e)
* Replace a very unusual variable declaration by a more conventional oneVolker Lendecke2008-06-171-1/+1
| | | | (cherry picked from commit b37030644e32249706d431ad93881d540f351c50)
* Fix a memleak in wbcAuthenticateUserEx()Volker Lendecke2008-06-171-0/+2
| | | | (cherry picked from commit 72b381689af9cae83ab08532cffd0188f2da4807)
* Revert "Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails"Volker Lendecke2008-06-171-1/+0
| | | | | This reverts commit 6bcfa82ff15531c64e0db27dcc58e5847c513aa6. (cherry picked from commit 6f3183d0c4880dcf243239cd1ed018b9d10a4249)
* Revert "Fix a memleak caused by a crappy get_sorted_dc_list() API"Volker Lendecke2008-06-171-14/+1
| | | | | This reverts commit ba10b9c077272c521504b3a638bba73446efc61c. (cherry picked from commit 4b3690a730895f6a19b14ee09ca0a2a131c3ba21)
* More correct fix (hopefully :-) for any memory leaks.Jeremy Allison2008-06-171-1/+17
| | | | | | | | | | | Jerry promised to check :-). Vl also please review. Jeremy. Okay -- I have to admit that this is the better fix. With my fixes I got a double-free when using security=domain. Sorry... Volker (cherry picked from commit 3b0d688b1b16c9054340d08986d0fa91f7fff9ad)
* net_vampire: fix samsync_process_database(). Final fix for Bug #5542.Günther Deschner2008-06-171-1/+1
| | | | | | | Turns out the password hashes are not rid encrypted in the samsync reply. Guenther (cherry picked from commit 55259f408b7bc356367d872a38a54174d364fd2b)
* net_vampire: fix build warning.Günther Deschner2008-06-171-1/+0
| | | | | | Guenther (cherry picked from commit eb4232fec05cd87ea85a781b84a3fbe85f469703) (cherry picked from commit 28b85a92160c7880253725cd247e064020f8be41)
* netapi: Fix Bug #5545 (libnetapi_init without $USER)Günther Deschner2008-06-171-2/+6
| | | | | | | | Based on patch from Erik van Pienbroek. Guenther (cherry picked from commit 71f4cf773022525ba617f09c495dbff97f8eb2d5) (cherry picked from commit 7602a4dbfb1b2ae9963f017be62c999af0c2e043)
* net: Fix several typos in comments.Karolin Seeger2008-06-161-372/+372
| | | | | | | | | | | | -argc -> argv (where argv is meant) -destoyed -> destroyed -compleation -> completion -aquired -> acquired -Unify spelling of some words like rpc-server -> RPC server. -Add missing punctuation marks. Karolin (cherry picked from commit 7c22fc6ebaa1a83213cbb7c08bea108264f89486)
* Fix a handle leak for error returns in ldb_try_load_dsoVolker Lendecke2008-06-161-1/+7
| | | | | Coverity ID 464 (cherry picked from commit 496d44d2f21661c85bf07e8eb7cae6298fefd900)
* Fix group parsing in libwbclient's copy_group_entry()Volker Lendecke2008-06-161-4/+6
| | | | | | | | This (also) fixes a flaw pointed out by the IBM checker. When verifying that I found out that the parsing was not working as I would have expected it to. Jerry, please check! (cherry picked from commit c2c7790155ab02e1e351caf2bed192ce72913663)
* Fix an uninitialized variable found by the IBM checkerVolker Lendecke2008-06-161-5/+5
| | | | | | | | | | BAIL_ON_PTR_ERROR jumps to done: which will access extra_data before it's initialized. Stefan, please check! Volker (cherry picked from commit b59636f78d351ed6d52c4a9fdccdb7850388526c)
* Fix bug 5500 -- thanks to mathion at thorrovydeti.com for reportingVolker Lendecke2008-06-161-0/+2
| | | | (cherry picked from commit 996c3ce6f0dbe79b0679ae30afd873c24fe5b1eb)
* Fix a crash in _winreg_QueryValueVolker Lendecke2008-06-131-0/+4
| | | | | | | | | | | | Coverity ID 474, value_length and type are both unique, not ref pointers and can thus be NULL. Karolin, please merge this to -stable. Thanks, Volker (cherry picked from commit 999533c0ccced59141d8baff5bc248d63e2a966f)
* net: Fix bug #5542 (samsync contains empty passwords).Günther Deschner2008-06-133-2/+28
| | | | | Guenther (cherry picked from commit 1a22e975dd1255f3557c1cd873d877aa35822afc)
* samsync: add samsync_fix_delta_array()Günther Deschner2008-06-132-0/+189
| | | | | | | This code is vastly based on samba4 code. Guenther (cherry picked from commit 5b68be96996a710988b1fd1c176cd5dff0f2c6af)
* Fix typos.Christoph Zauner2008-06-121-3/+3
| | | | (cherry picked from commit b2390aa738f6384016600dffb8065bd0bcda6ef1)
* Add -brtl to the AIX linker flagsVolker Lendecke2008-06-121-1/+3
| | | | | Thanks to William Jojo (cherry picked from commit 74b195b54416d9e3eb46079a71eed31a15c7293a)
* AIX build fixes from William Jojo -- thanksVolker Lendecke2008-06-122-2/+3
| | | | (cherry picked from commit cb91a47576e820390bc62195702aaae93a2feba6)
* Fix max_fd calculation in event_loop_onceVolker Lendecke2008-06-121-1/+1
| | | | | | | | | | For some bugs I really wonder how they can go undetected for so long. Fix a bug reported by Mathias Dietz. No samba bugzilla entry, but still 100% needed for 3-2-stable. Volker (cherry picked from commit 82c994dabc47bb4755c883a1f3651bb5d65cf2c5)
* pam_winbind: Update cached creds during password change.Günther Deschner2008-06-111-0/+4
| | | | | | | | Fix is from Bo Yang @ Novell. Thanks! (cherry picked from commit e4eb9d347d14de8c9ba73b07f26fe8fd4f17eab5) (cherry picked from commit 49178f979f14ced834dda3104044bb8a84d4ebdb)
* Correctly find a [u]int32_t replacementVolker Lendecke2008-06-111-6/+15
| | | | (cherry picked from commit 346375cda557a675f8f882ca2ae8edffec725a72)
* Fix some scary FC9 warningsVolker Lendecke2008-06-111-39/+41
| | | | (cherry picked from commit 6b0fed09ea34409d1c61bae9121bdb38d4c68d62)
* Don't reset password last set time just because the expired flagJim McDonough2008-06-101-1/+9
| | | | | | | | is set to 0. If the account wasn't expired but autolocked, using "net user /dom <username> /active:y" would clear this, incorrectly setting the current time as the new "password last set" time. (cherry picked from commit 2089c692cfe5a4f9bbed1e658c6f73c310dbff57)
* shrink ldbtoolsVolker Lendecke2008-06-091-20/+11
| | | | | Thanks to Björn Jacke for noticing :-) (cherry picked from commit 8faee1cee829d749835a66d219170ccfd85151d0)
* Fix the compile on NetBSD -- missing prototypesVolker Lendecke2008-06-091-0/+39
| | | | (cherry picked from commit 11236d266e3703eb3aca4b96e2ed9da76614ec12)
* Fix the compile on NetBSD -- readlink and read are macros thereVolker Lendecke2008-06-092-10/+10
| | | | (cherry picked from commit 435b80a9a2e9324cc20594d922b3d8d6418c27af)
* libreplace: only include AC_USE_SYSTEM_EXTENSIONS fallback if requiredStefan Metzmacher2008-06-091-1/+2
| | | | | | | | | This fixes ./autogen.sh with autoconf-2.62 metze (cherry picked from commit 72bb01dda4d425528e28cd96e249595dc6c1952f) (cherry picked from commit 85111dc2b60ca38027adf129a074641c752cb104) (cherry picked from commit 24f0c35571b26187c13af933604fe40afed1da34)
* libreplace: fix warnings with autoconf-2.62 rename ac_ => libreplace_cv_Stefan Metzmacher2008-06-091-4/+4
| | | | | | | | | AC_CACHE_VAL() variables must contain _cv_ to be cached. metze (cherry picked from commit 67e43860b4973a458676b36785570bb4a66e046a) (cherry picked from commit d786bfc48e20ed7e695a988da6ed56a573afdadc) (cherry picked from commit c402acd63a31bace402b361760a7d73f95db3717)
* configure: we require autoconf 2.54Stefan Metzmacher2008-06-091-2/+2
| | | | | | | | I've tested with autoconf from 2.53 to 2.62. metze (cherry picked from commit a268a6d251e58c27262e11fcd85b8281dfaddd8b) (cherry picked from commit 21bbd421d4bd2c16f4d8ab94a6a9e3388be4fb82)
* configure: fix warnings with autoconf-2.62 rename SMB_BUILD_ => samba_cv_Stefan Metzmacher2008-06-091-3/+3
| | | | | | | | AC_CACHE_VAL() variables must contain _cv_ to be cached. metze (cherry picked from commit 89663ab4d10586b96807c56de53fd60d2488093c) (cherry picked from commit 74c644a2bed45d48215914da8002913254a7f54c)
* configure: fix warnings with autoconf-2.62 rename samba_stat_hires => ↵Stefan Metzmacher2008-06-091-6/+6
| | | | | | | | | | samba_cv_stat_hires AC_CACHE_VAL() variables must contain _cv_ to be cached. metze (cherry picked from commit 426b1e36e262ae47ea62e36e1df8a76c930394bc) (cherry picked from commit 84a8a7d9e028aa223617a8cb7aa31d5fabd7636e)
* configure: fix warnings with autoconf-2.62 rename smb_krb5_ => smb_krb5_cv_Stefan Metzmacher2008-06-091-21/+21
| | | | | | | | AC_CACHE_VAL() variables must contain _cv_ to be cached. metze (cherry picked from commit 38a03d61ecd35a70905b895b839a994e974cbaf1) (cherry picked from commit a7a8abdbac00693a0437d3b3cb1e4e9784a03e51)
* netdomjoin-gui: enable NetGetJoinInformation() call after successfull joining.Günther Deschner2008-06-091-3/+3
| | | | | | | | | Now that libnetjoin reloads configuration after joining, we can rely on the NetGetJoinInformation() output and use it for displaying the new domain name and type. Guenther (cherry picked from commit cc1b8de2632e87002cac86838f2a77ab9771ce2c)
* netdomjoin-gui: fix more gtk runtime warnings.Günther Deschner2008-06-091-0/+4
| | | | | Guenther (cherry picked from commit 521ea68719524eeef827875e018bb8cba2a92e87)
* netdomjoin-gui: disable annoying "reboot now" dialog.Günther Deschner2008-06-091-0/+4
| | | | | Guenther (cherry picked from commit 8f0c5f1bedaae7a86ca671cdb2ba798079ec1d84)
* netdomjoin-gui: some minor fixes + hunting down typecast bugs.Günther Deschner2008-06-091-11/+25
| | | | | Guenther (cherry picked from commit 0fa6c8c6a3efd026154e8af54ba73b3d3de1affa)
* Bugfix noticed by Herb. On using the again: tag as aJeremy Allison2008-06-091-0/+15
| | | | | | | | | | | | | | | | | | | | | | goto target we were not reinitializing the array counts. From Herb: This is in the file nsswitch/winbindd_cm.c (samba-3.0.30) line 1236 We have a label again: where we keep trying to find the name of the DC from the list of IPs returned by get_dcs. If we fail to figure out the name we do a goto again at the end of the function. The problem is we don't reset the num_dcs, num_addrs, etc and free the memory in the various arrays. This seems wrong to me. I have a winbindd core where I have 9 IPs returned for the DCs but at the time of the crash num_dcs is 87 and if I look through the array dcs it keeps repeating entries from the same group of 9 Jerry, Volker and Guenther please check. Jeremy. (cherry picked from commit 0b2062a499c69c86cc03130542aaf3e92265b65d)
* pam_winbind: fix pam_sm_chauthtok for storing modified cached creds.Günther Deschner2008-06-091-1/+16
| | | | | | | Thanks to Bo Yang for pointing this out. Guenther (cherry picked from commit 516a067016955938988ab37c777102a14b41e100)
* libnetjoin: add libnet_join_rollback().Günther Deschner2008-06-091-1/+30
| | | | | | | | This is required now if the join verify failed and we already modified the local configuration. Guenther (cherry picked from commit 2870fe50af5163e30330f5a3ef21d0b7eea85ee5)
* libnetjoin: First store configuration and then verify the join.Günther Deschner2008-06-091-4/+11
| | | | | | | Jerry, this fixes the issues while joining with "config backend = registry". Guenther (cherry picked from commit b3d47f099286778252c6df6bf2c1fee0c4e26560)
* Manually port Steven Dannenman fix for using the correct machine domain whenGerald W. Carter2008-06-092-6/+6
| | | | | | | | | | | | | looking up trust credentials in our tdb. commit fd0ae47046d37ec8297396a2733209c4d999ea91 Author: Steven Danneman <sdanneman@isilon.com> Date: Thu May 8 13:34:49 2008 -0700 Use machine account and machine password from our domain when contacting trusted domains. (cherry picked from commit 69b37ae60757075a0712149c5f97f17ee22c2e41) (cherry picked from commit 8a64988fc45aff15359caf16f28ff1712bbe6d5f)
* Manually merge Steven Danneman's patch for SPNEGO auth to a trustedGerald W. Carter2008-06-092-25/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Win2008 domain (merged from v3-0-test). commit 8dc4e979776aae0ecaa74b51dc1eac78a7631405 Author: Steven Danneman <sdanneman@isilon.com> Date: Wed May 7 13:34:26 2008 -0700 spnego SPN fix when contacting trusted domains cli_session_setup_spnego() was not taking into consideration the situation where we're connecting to a trusted domain, specifically one (like W2K8) which doesn't return a SPN in the NegTokenInit. This caused two problems: 1) When guessing the SPN using kerberos_get_default_realm_from_ccache() we were always using our default realm, not the realm of the domain we're connecting to. 2) When falling back on NTLMSSP for authentication we were passing the name of the domain we're connecting to for use in our credentials when we should be passing our own workgroup name. The fix for both was to split the single "domain" parameter into "user_domain" and "dest_realm" parameters. We use the "user_domain" parameter to pass into the NTLM call, and we used "dest_realm" to create an SPN if none was returned in the NegTokenInit2 packet. If no "dest_realm" is provided we assume we're connecting to our own domain and use the credentials cache to build the SPN. Since we have a reasonable guess at the SPN, I removed the check that defaults us directly to NTLM when negHint is empty. (cherry picked from b78b14c88e8354aadf9ba7644bdb1c29245fe419) (cherry picked from commit f1e6b40bbc8ce249e2f2a85a1d57ed6b8141e3bb)
* Revert "build: add symbol versioning when we build with gnu ld"Karolin Seeger2008-06-096-69/+16
| | | | | | | | | | | | This reverts commit cb5492978b6b157f529806afb2f5fc6202888129. For more information, please have a look at the discussion on samba-technical starting with [1]. [1] http://lists.samba.org/archive/samba-technical/2008-June/059511.html Karolin (cherry picked from commit 1e5aeb96f92fef8056ec9010e125f4d0d31dd90e)