summaryrefslogtreecommitdiffstats
path: root/source4
Commit message (Collapse)AuthorAgeFilesLines
...
* Remove NT_STATUS_IS_ERR_RETURN macro from the codebase.Garming Sam2014-03-051-1/+3
| | | | | | | | | | Following the current coding guidelines, it is considered bad practice to return from within a macro and change control flow as they look like normal function calls. Change-Id: I39b07b3a799331a5faa968629aa95b836cb78600 Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Remove NT_STATUS_IS_OK_RETURN macro from the codebase.Garming Sam2014-03-051-1/+3
| | | | | | | | | | Following the current coding guidelines, it is considered bad practice to return from within a macro and change control flow as they look like normal function calls. Change-Id: I27e7597f4078f0a6c96b5dadd12454fffe33e6b2 Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Remove the remaining uses of the macro NT_STATUS_HAVE_NO_MEMORY_AND_FREE in ↵Garming Sam2014-03-052-20/+40
| | | | | | | | | | | | | the codebase. Following the current coding guidelines, it is considered bad practice to return from within a macro and change control flow as they look like normal function calls. Change-Id: Id1b540cde127395a7b27385a7c0fe79f3a145c73 Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Remove a number of NT_STATUS_HAVE_NO_MEMORY_AND_FREE macros from the codebase.Garming Sam2014-03-0513-114/+456
| | | | | | | | | | | Following the current coding guidelines, it is considered bad practice to return from within a macro and change control flow as they look like normal function calls. Change-Id: I133eb5a699757ae57b87d3bd3ebbcf5b556b0268 Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* winbind4: Remove unused winbind_get_idmap irpc operationVolker Lendecke2014-03-052-94/+2
| | | | | | | Change-Id: Ia5e62d30b277f8a7074d451cfb8675eee8e9d21f Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* auth4: Remove unused wbc_contextVolker Lendecke2014-03-053-42/+1
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Change-Id: I07d9f7d8028429564d91da39f8d1e73cc13a646c Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* ntvfs_unixuid: No wbc_context requiredVolker Lendecke2014-03-051-8/+0
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Change-Id: I46f5d719005f3ac940482773404702368bbcfa4f Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* ntvfs_posix: No wbc_context requiredVolker Lendecke2014-03-052-8/+0
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Change-Id: Ibce7b25740cc14b0a60ad856f6b18c33115ea6fa Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* dcesrv_unixinfo: No wbc_context requiredVolker Lendecke2014-03-051-32/+4
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Change-Id: I58f01cf754e6f9a7715c0319a43ec87d8e5df194 Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* unixuid: Use the tevent_context from the ntvfs_contextVolker Lendecke2014-03-051-3/+1
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Change-Id: I4edb0ee4cefdc2f1b309202c9ec70c7c7bbac0b8 Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* pvfs: Use the tevent_context from the ntvfs_contextVolker Lendecke2014-03-052-6/+7
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Change-Id: Idb3ad8047d5161dd06800df611ea2a9cac84ecaa Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* auth4: Do not generate just a temporary wbc_contextVolker Lendecke2014-03-051-10/+1
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Change-Id: I16e116d7f1fdaf165e1239c10723c51f3828126d Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* auth4: auth_session_info_fill_unix only needs a tevent_contextVolker Lendecke2014-03-052-3/+4
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Change-Id: Id453d68f57bd1dd15aa5778b317d258a6132d3d6 Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* auth4: security_token_to_unix_token only needs a tevent_contextVolker Lendecke2014-03-052-4/+4
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Change-Id: I27e5b38fcd3ac899c55c0632ea5d92fad686d9b1 Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libwbclient4: Remove unused composite-based functionsVolker Lendecke2014-03-052-158/+0
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Change-Id: Iff6169e35f7a82e31c42df7b2d30d122b5f67451 Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* source4: Use wbc_xids_to_sidsVolker Lendecke2014-03-053-24/+5
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Change-Id: Ib1b1a7fcd881510e3fb4e5da29391e3d9392fa17 Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libwbclient4: Add wbc_xids_to_sidsVolker Lendecke2014-03-051-0/+215
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Change-Id: Ibb67f6aabd9a3fbd023ff9ec1a34d82ae599177c Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* source4: Use wbc_sids_to_xidsVolker Lendecke2014-03-054-29/+8
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Change-Id: I86ea6587c436247ce66207c517f9c8d567ecac1d Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libwbclient4: Add wbc_sids_to_xidsVolker Lendecke2014-03-053-1/+173
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Change-Id: I79f4b87a14e7074970bd024626e5838a4461cc2e Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* bug #10471: Don't respond with NXDOMAIN to records that exist with another typeKai Blin2014-03-041-6/+8
| | | | | | | | | | DNS queries for records with the wrong type need to trigger an empty response with RCODE_OK instead of returning NXDOMAIN. This adds a test and fixes bug #10471 Signed-off-by: Kai Blin <kai@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* torture: Fix a torture crash with -O3Volker Lendecke2014-02-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When compiled with -O3, smbtorture can crash after the following valgrind trace: ==16944== Conditional jump or move depends on uninitialised value(s) ==16944== at 0x57FFAC3: ndr_push_unique_ptr (ndr_basic.c:730) ==16944== by 0x58CB855: ndr_push_spoolss_SetPrinterInfo (ndr_spoolss.c:7939) ==16944== by 0x58E2F95: ndr_push_spoolss_SetPrinter (ndr_spoolss.c:24724) ==16944== by 0x417C78C: dcerpc_binding_handle_call_send (binding_handle.c:410) ==16944== by 0x417C986: dcerpc_binding_handle_call (binding_handle.c:547) ==16944== by 0x522059C: dcerpc_spoolss_SetPrinter_r (ndr_spoolss_c.c:1722) ==16944== by 0x2853BD: test_sd_set_level (spoolss.c:1248) ==16944== by 0x28F146: test_PrinterInfo_SD (spoolss.c:1962) ==16944== by 0x2A3C31: test_EnumPrinters_old (spoolss.c:6589) ==16944== by 0x41F6D66: internal_torture_run_test.part.0 (torture.c:442) ==16944== by 0x41F711F: torture_run_tcase_restricted (torture.c:758) ==16944== by 0x2018E8: run_matching.isra.1 (smbtorture.c:103) ==16944== by 0x20176B: run_matching.isra.1 (smbtorture.c:95) ==16944== by 0x20176B: run_matching.isra.1 (smbtorture.c:95) ==16944== by 0x201C12: torture_run_named_tests (smbtorture.c:143) ==16944== by 0x202F5B: main (smbtorture.c:661) My assumption is that with optimization gcc makes use of the fact that the structures that this patch moves go out of scope. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Fri Feb 28 21:27:11 CET 2014 on sn-devel-104
* torture: Fix a buffer overrunVolker Lendecke2014-02-281-2/+2
| | | | | | | | | | | In test_EnumPrinterDrivers we go up to driver level 8. In C, this means we are accessing the 9th entry in the following lines: ctx->driver_count[level] = count; ctx->drivers[level] = info; Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* s4: tidy up vfs smb2 in regards to using share_string_optionGarming Sam2014-02-241-21/+21
| | | | | | | | | | | Change-Id: Ieae6b5ddc2cd9983489c374605e4740371e81883 Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Kamen Mazdrashki <kamenim@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Feb 24 19:16:48 CET 2014 on sn-devel-104
* s4: tidy up vfs cifs in regards to using share_string_optionGarming Sam2014-02-241-21/+22
| | | | | | | | Change-Id: I014bce667d3f875a913dbccf269b514f7ffbab7b Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
* s4: tidy up some null checks in ntvfsGarming Sam2014-02-242-4/+4
| | | | | | | | Change-Id: I629a299bea10b063de4525020a4c6b838260cd67 Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
* heimdal: Use krb5_free_default_realm() for free()Santosh Kumar Pradhan2014-02-211-3/+3
| | | | | | | | | | The resource allocated by krb5_default_default_realm() should be free()'d by krb5_free_default_realm() instead of plain free() for better readability. Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* kdc: Free the resource which is not used anymoreSantosh Kumar Pradhan2014-02-211-0/+1
| | | | | | | | | | | In samba_kdc_firstkey() routine, krb5_get_default_realm() allocates memory for "realm" but never used afterwards. Free() the leaked memory. CID: 1107223 Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* heimdal_build: only enable libintl functions if everything was foundChristian Ambach2014-02-201-1/+2
| | | | | | | | | | | | | | do not rely on intl.h being available but also on the functions being usable This should fix the build on HP-UX Bug: https://bugzilla.samba.org/show_bug.cgi?id=9911 Signed-off-by: Christian Ambach <ambi@samba.org> Change-Id: I5dd88d2d5216b778624778455cca99b32d0be58f Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Feb 20 01:28:24 CET 2014 on sn-devel-104
* lib/param: handle non-constant strings properly by passing in a memory contextGarming Sam2014-02-203-5/+5
| | | | | | | Signed-off-by: Garming Sam <garming@catalyst.net.nz> Change-Id: Ic6bb1c709defd2b0f35fc7b877da0badca385776 Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Nadezhda Ivanova <nivanova@samba.org>
* s4: pass down a memory context when performing share_string_option, to allow ↵Garming Sam2014-02-2017-72/+151
| | | | | | | | | substitutions Signed-off-by: Garming Sam <garming@catalyst.net.nz> Change-Id: I24b36db3ac11834c3268b2da929e214c10268b16 Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Nadezhda Ivanova <nivanova@samba.org>
* Define the winbindd socket directory when building wbclientGarming Sam2014-02-191-0/+1
| | | | | | | | | | Change-Id: I2a730e41f45cff0f4836fbc8f993947e3a30aa18 Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Wed Feb 19 16:25:42 CET 2014 on sn-devel-104
* Revert "libwbclient4: Add wbc_sids_to_xids"Volker Lendecke2014-02-183-173/+1
| | | | | | | This reverts commit fefc59619b58cb0c38bf7e6ac2ebcc25a5ebbd6c. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "source4: Use wbc_sids_to_xids"Volker Lendecke2014-02-184-8/+29
| | | | | | | This reverts commit de7122ddc356697777cce95d22b3fab7697b30db. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "libwbclient4: Add wbc_xids_to_sids"Volker Lendecke2014-02-181-215/+0
| | | | | | | This reverts commit f275ce4e4367478b488810491c7bcd993c37caf1. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "source4: Use wbc_xids_to_sids"Volker Lendecke2014-02-183-5/+24
| | | | | | | This reverts commit d0932a1ae089fda0d41be21a9916caeca7c0c233. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "libwbclient4: Remove unused composite-based functions"Volker Lendecke2014-02-182-0/+158
| | | | | | | This reverts commit ba5f02739cb454d2312f73f643f2c119e090ac5e. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "auth4: security_token_to_unix_token only needs a tevent_context"Volker Lendecke2014-02-182-4/+4
| | | | | | | This reverts commit 1de725c2926b526200032c4f46132c17533986c7. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "auth4: auth_session_info_fill_unix only needs a tevent_context"Volker Lendecke2014-02-182-4/+3
| | | | | | | This reverts commit 75d7c4609c1c743f84ca9f2d0666aece9e5200d4. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "auth4: Do not generate just a temporary wbc_context"Volker Lendecke2014-02-181-1/+10
| | | | | | | This reverts commit 5124a9e1183de990ca3146cd355152094495a779. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "pvfs: Use the tevent_context from the ntvfs_context"Volker Lendecke2014-02-182-7/+6
| | | | | | | This reverts commit 15700a9f6e5393cecf78052f510e015300c5bd85. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "unixuid: Use the tevent_context from the ntvfs_context"Volker Lendecke2014-02-181-1/+3
| | | | | | | This reverts commit 25e83a9b3e72cdb84c09ef8ada4784efd110f09a. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "dcesrv_unixinfo: No wbc_context required"Volker Lendecke2014-02-181-4/+32
| | | | | | | This reverts commit 5a4252789b54b6b270b3083f6e0732ba1fdd774b. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "ntvfs_posix: No wbc_context required"Volker Lendecke2014-02-182-0/+8
| | | | | | | This reverts commit 55dd08c4e80827ffc4fe423f3e67aec499af06df. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "ntvfs_unixuid: No wbc_context required"Volker Lendecke2014-02-181-0/+8
| | | | | | | This reverts commit f35f88d741f1f896268649238d4ddbda4abb1585. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "auth4: Remove unused wbc_context"Volker Lendecke2014-02-183-1/+42
| | | | | | | This reverts commit 6b04558c5e0547a807ac0fcb5eeb1085cfe602ac. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Revert "winbind4: Remove unused winbind_get_idmap irpc operation"Volker Lendecke2014-02-182-2/+94
| | | | | | | This reverts commit 41ff0f4454ef23d0ac3e31560d78a2b966769fea. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4:pyrpc: let dcerpc_interface_new() use py_dcerpc_interface_init_helper()Stefan Metzmacher2014-02-171-74/+26
| | | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Feb 17 21:39:30 CET 2014 on sn-devel-104
* s4:pyrpc: fix talloc hierachy in py_dcerpc_interface_init_helper()Stefan Metzmacher2014-02-171-35/+76
| | | | | | | | | | | | | | The tevent_context is cached under the connection, so we need to make sure it stays arround as long as the connection. Otherwise it will segfault while dereferencing the tevent_context on deallocation if a secondary connection is arround. This completes commit 4cc3388c034fa43c855fba802a30bbd2e78122be, which only fixed it in dcerpc_interface_new(). Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s4:librpc/rpc: make dcerpc_pipe->binding constStefan Metzmacher2014-02-133-8/+14
| | | | | | | | This should not be changed after the connection is ready for requests. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:librpc/rpc: pass dcerpc_binding arround as 'const'Stefan Metzmacher2014-02-134-13/+13
| | | | | | | This should only be modified by the owner. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
generated by cgit (git 2.34.1) at 2025-09-02 14:38:01 +0000