summaryrefslogtreecommitdiffstats
path: root/source3
Commit message (Collapse)AuthorAgeFilesLines
* s3: Fix Coverity ID 2140, DEADCODEVolker Lendecke2011-03-161-1/+1
| | | | | | | This routine was never executed after f0dcc90f because "netname" was always NULL. Jeremy, please check!
* s3: Fix Coverity ID 2144, DEADCODEVolker Lendecke2011-03-161-1/+1
| | | | | | We could never have assigned the real value in line 481. Andreas, please check!
* s3: Fix Coverity ID 2147, FORWARD_NULLVolker Lendecke2011-03-161-1/+1
| | | | How could this ever have worked???
* s3: Fix Coverity ID 1402: PASS_BY_VALUEVolker Lendecke2011-03-161-11/+11
| | | | | | | There's no point in passing GROUP_MAP on the stack Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Mar 16 21:58:08 CET 2011 on sn-devel-104
* s3: Fix Coverity ID 2213, PASS_BY_VALUEVolker Lendecke2011-03-161-6/+6
| | | | | | There's little point to pass a copy of this structure on the stack. Günther, please check!
* s3: Fix Coverity ID 1012, CHECKED_RETURNVolker Lendecke2011-03-161-6/+5
| | | | | This is probably more or less taste. Removing the necessity for a comment is a good thing though IMO.
* s3: Fix Coverity ID 1013, CHECKED_RETURNVolker Lendecke2011-03-161-6/+5
| | | | | This is probably more or less taste. Removing the necessity for a comment is a good thing though IMO.
* s3: Fix Coverity ID 1017, CHECKED_RETURNVolker Lendecke2011-03-161-1/+3
| | | | Günther, please check!
* s3: Fix Coverity ID 1018, CHECKED_RETURNVolker Lendecke2011-03-161-3/+5
|
* s3: Fix Coverity ID 1034, CHECKED_RETURNVolker Lendecke2011-03-161-3/+1
| | | | In all other places we check the result of secrets_init.
* s3: Fix Coverity ID 2100, BAD_SIZEOFVolker Lendecke2011-03-161-1/+1
| | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Mar 16 18:52:18 CET 2011 on sn-devel-104
* s3: Fix Coverity ID 2317: Uninitialized readVolker Lendecke2011-03-161-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
* s3: Fix Coverity ID 2318: Uninitialized readVolker Lendecke2011-03-161-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
* s3: Fix Coverity ID 2319: Uninitialized readVolker Lendecke2011-03-161-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
* s3-packet: only include packet.h where needed.Günther Deschner2011-03-163-1/+2
| | | | Guenther
* s3-interfaces: only include interfaces.h where needed.Günther Deschner2011-03-165-1/+4
| | | | Guenther
* s3-msdfs: avoid global inclusion of msdfs.h.Günther Deschner2011-03-165-1/+5
| | | | Guenther
* s3-printing: fix memory leak in print_cups.cDavid Disseldorp2011-03-161-16/+9
| | | | | | | | | | As found by valgrind, tmp_pcap_cache is not freed following printer list tdb update. Signed-off-by: Andreas Schneider <asn@samba.org> Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed Mar 16 16:37:58 CET 2011 on sn-devel-104
* s3-printing: remove duplicate cups response processing codeDavid Disseldorp2011-03-161-147/+94
| | | | | | | | There is currently a lot of duplicate code included for processing responses to CUPS_GET_PRINTERS and CUPS_GET_CLASSES requests. This change splits this code into a separate function. Signed-off-by: Andreas Schneider <asn@samba.org>
* s3-printing: use printcap IDL for IPCDavid Disseldorp2011-03-163-132/+109
| | | | | | | | | Use printcap IDL for marshalling and unmarshalling messages between cups child and parent smbd processes. This simplifies the IPC and ensures the parent is notified of cups errors encountered by the child. https://bugzilla.samba.org/show_bug.cgi?id=7994 Signed-off-by: Andreas Schneider <asn@samba.org>
* s3-build: stop including ldap and lber headers everywhere in the code.Günther Deschner2011-03-168-51/+67
| | | | | | | | | | Instead use new header smb_ldap.h where all LDAP API related things are handled, while smbldap.h only deals with our smbldap_X() API. Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Mar 16 10:54:51 CET 2011 on sn-devel-104
* s3-includes: avoid global include of gssapi headers.Günther Deschner2011-03-163-12/+20
| | | | Guenther
* s3-libsmb: move smb encryption structs into own header.Günther Deschner2011-03-167-28/+67
| | | | Guenther
* libcli/security: move display_sec headers to own header file and add toGünther Deschner2011-03-165-10/+4
| | | | | | security.h grouping header. Guenther
* s3: Fix a cut&paste error in pdb_ads_connectVolker Lendecke2011-03-161-1/+1
| | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Mar 16 08:22:28 CET 2011 on sn-devel-104
* s3: Use jenkins hash for str_checksum, fix bug 8010Volker Lendecke2011-03-161-11/+2
| | | | | | | | | | | | From the bugreport: I have a folder with ~90 photos: IMG_XXXX.JPG where XXXX is a four digit number, almost consecutive (photos from camera for one day). Current implementation gives about 30 different checksums for this set of files. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Mar 16 01:15:41 CET 2011 on sn-devel-104
* s3-build: try to silence annoying "Ignoring invalid value 'vlp' for ↵Günther Deschner2011-03-152-5/+6
| | | | | | | | | | | parameter 'printing'" warning on the buildfarm. Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Mar 15 23:38:43 CET 2011 on sn-devel-104
* s3-libsmb: only include rap client when needed.Günther Deschner2011-03-1520-180/+226
| | | | Guenther
* s3-build: share smbtorture4 build rules with s3-waf build.Günther Deschner2011-03-153-20/+33
| | | | | | | Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Mar 15 16:10:17 CET 2011 on sn-devel-104
* s3: Fix Coverity ID 2278: Uninitialized readVolker Lendecke2011-03-151-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
* s3: Fix Coverity ID 2279: Uninitialized readVolker Lendecke2011-03-151-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
* s3: Fix Coverity ID 2280: Uninitialized readVolker Lendecke2011-03-151-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
* s3: Fix Coverity ID 2281: Uninitialized readVolker Lendecke2011-03-151-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
* s3: Fix Coverity ID 2282: Uninitialized readVolker Lendecke2011-03-151-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
* s3: Fix Coverity ID 2283: Uninitialized readVolker Lendecke2011-03-151-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_OpenKey.
* s3: Fix Coverity ID 2284: Uninitialized readVolker Lendecke2011-03-151-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_DeleteValue.
* s3: Fix Coverity ID 2285: Uninitialized readVolker Lendecke2011-03-151-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_DeleteValue.
* s3: Fix Coverity ID 2286: Uninitialized readVolker Lendecke2011-03-151-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
* s3: Fix Coverity ID 2287: Uninitialized readVolker Lendecke2011-03-151-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_CreateKey.
* s3: Fix Coverity ID 2288: Uninitialized readVolker Lendecke2011-03-151-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue.
* s3: Fix Coverity ID 2289: Uninitialized readVolker Lendecke2011-03-151-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_OpenKey.
* s3: Fix Coverity ID 2290: Uninitialized readVolker Lendecke2011-03-151-1/+1
| | | | | We passed the structure including the uninitialized elements to dcerpc_winreg_DeleteKey.
* s3: Read uidNumber/gidNumber in pdb_ads_sid_to_idVolker Lendecke2011-03-151-29/+45
| | | | | | | Question: How shall we allocate those? Something like the rid allocator? Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Tue Mar 15 09:59:55 CET 2011 on sn-devel-104
* s3: Remove some unused codeVolker Lendecke2011-03-152-43/+0
|
* s3: "hex_encode" does the same as "binary_string"Volker Lendecke2011-03-151-1/+1
|
* s3-waf: enable public_headers_allow_brokenAndrew Tridgell2011-03-151-0/+3
|
* s3-waf: enable public header building in s3Andrew Tridgell2011-03-151-0/+7
|
* Re-enable base.tcondev test for S3, now we pass it correctly.Jeremy Allison2011-03-151-1/+0
| | | | | Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Tue Mar 15 00:59:37 CET 2011 on sn-devel-104
* Fix bug #8005 - smbtorture4 BASE-TCONDEV fails when tested on SambaJeremy Allison2011-03-141-2/+6
| | | | | | | | | | | When pulling non-aligned ucs2 strings, we neglected to add in the pad byte to the buffer length we've eaten. This caused the device string in TCONX (which seems to be one of the few places that uses non-aligned ucs2 strings) to be incorrectly read. Volker please check. Jeremy.
* s3: Change tldap_entry_attributes to the "array,count" conventionVolker Lendecke2011-03-143-5/+7
| | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Mon Mar 14 22:02:35 CET 2011 on sn-devel-104