| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of reading the registry directly with tdb and activating the
configure options by hand.
This eliminates the need for repeating checks done in loadparm.
For instance it disables registry shares without path in the server
as is the case with text based shares.
Michael
(cherry picked from commit 077bcc11257697b243916fbb02cd72b3a122b9ba)
(cherry picked from commit 502bfe9352d36ee909d7210a9d0ec0b6c7db5149)
|
|
|
|
|
| |
This reverts commit c8cc6da0ab4441ce7b22cf00eed05290e91530c4.
(cherry picked from commit c7d5e046d8fa4097fc16a3dee10e95b83a8c8e55)
|
|
|
|
|
|
| |
Always add back the real original owner of the directory in the ACE List after
we steal its ACE for the Administrators group.
(cherry picked from commit 5d8f374ad75e06354ac27f34e3f44b3d459ac2ef)
|
|
|
|
|
|
|
| |
When adding arbitrary aces to an nt_ace_list we need to make sure we
are not actually adding a duplicate.
add_or_replace_ace() takes care of doing the right thing.
(cherry picked from commit 89dfbdba515b5be32f535a112a7f1019884aa651)
|
|
|
|
|
|
| |
Guenther
(cherry picked from commit da92e54236293460e307edd52ca7f1e20c6f23ef)
(cherry picked from commit 3e9ee3fa54b514987f40a477b3049b18e87390e9)
|
|
|
|
| |
(cherry picked from commit c8cc6da0ab4441ce7b22cf00eed05290e91530c4)
|
|
|
|
|
|
|
|
| |
smbd to
access a freed structure.
Jeremy.
(cherry picked from commit e023058f5b774ddbb61e8187aa7dbd2e6e25804d)
|
|
|
|
|
|
|
|
| |
What a difference a name makes... :-). Just because something is missnamed
SAMR_ACCESS_OPEN_DOMAIN, when it should actually be SAMR_ACCESS_LOOKUP_DOMAIN,
don't automatically use it for a security check in _samr_OpenDomain().
Jeremy.
(cherry picked from commit 1994a8a5db5c3abd6292b81aa975e7b8fe8311d0)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The second r/o opener of a file is supposed to get a level2 oplock. The first
opener due to the protection in process_oplock_break_message() has been forced
to break to no oplock. The second opener according to locking.tdb gets a level2
oplock. Further down in open_file_ntcreate we try to set this level2 oplock in
the kernel, and the non-clustered Linux kernel disallows this. The rules for
the kernel leases are a bit baroque, but the attempt to do the SETLEASE
correctly fails and we end up with no oplock for any client.
In the clustered case however the linux kernel on the second opening node has
not seen the open fd of the first node, it is only the cluster fs that has this
information. If the cluster fs does not have the very same notion of leases as
the local kernel has, we can end up with a WRLCK style kernel lease for the
second opener where locking.tdb only indicates a level2 oplock. Getting a
kernel oplock break signal with just a level2 oplock in locking.tdb is
something smbd is not prepared for. For example after sending out the break in
response to the kernel signal we set a timeout, waiting for a reply.
More work needs to be done to make level2 kernel oplocks real for us. This
patch addresses a real problem we have right now without them.
(cherry picked from commit 17962ba589f24b7d2a67474978d06e33adad56c2)
|
|
|
|
| |
(cherry picked from commit fb8707e2c2d1657294b0660064e1b16590d1ca6c)
|
|
|
|
|
|
|
|
|
|
|
|
| |
parameter "msdfs root = yes"
This was broken by the refactoring around create_file().
MSDFS pathname processing must be done FIRST.
MSDFS pathnames containing IPv6 addresses can
be confused with NTFS stream names (they contain
":" characters.
Jeremy.
(cherry picked from commit b8251a7e01304afce96cb0bee15a1fee2bd57490)
|
|
|
|
| |
(cherry picked from commit 130baafc7c36333cf29a19921f4736beb53a15e9)
|
|
|
|
|
|
| |
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit 574a6a8c350a4bab3f42f3f9cfb382db721d69b5)
(cherry picked from commit 7e6d6eeff3e082d7223264c17cb27c2ab89df9aa)
|
|
|
|
|
|
| |
This removes all oplock dependence on locking.tdb
(cherry picked from commit 9d2d07503a17971a63153ecc13fdddb763e614b8)
(cherry picked from commit f922e22d907d4a99e91f00f001c05b2b35d73a26)
|
|
|
|
|
| |
(cherry picked from commit 651fa0964a6c49a071c28cdb1e4891b1d95d5b09)
(cherry picked from commit 4e091804b86ae9b8318b985d39e826366681e21b)
|
|
|
|
|
|
|
| |
handle_trans() can talloc_free "conn" if the client requests
close_on_completion. "state" is a talloc_child of conn, so it will be gone when
we later free state->data et al.
(cherry picked from commit e9457c598e25ededb48b73d7dc5ab0f6295ea399)
|
|
|
|
| |
(cherry picked from commit 4996d89d19655ab6f0d4656ea72d6bad52ba7d6d)
|
|
|
|
| |
(cherry picked from commit d5bec253f7494dd74cce3acf59ddd417900e5ad3)
|
|
|
|
|
|
|
| |
if "hide dot files" is set. Thanks to Barry Kelly <bkelly.ie@gmail.com>
for pointing this one out.
Jeremy.
(cherry picked from commit 286d6a404cca02a0d3662f6aa2ddd69d3dcbc17a)
|
|
|
|
|
| |
This fixes a "defined but not used" compile warning.
(cherry picked from commit 1aa65f485b60a80766581e7d3f31565f340aa528)
|
|
|
|
|
|
|
|
|
|
| |
too.
Otherwise we'll confuse the client signing engine, when we reply an error to each transs2.
metze
(cherry picked from commit 7716ad68a8d859ac3651c4eb559b6e45d98566db)
(cherry picked from commit 1d11417c71ebcb80851c8b77e9f3102ee9b592f8)
|
|
|
|
|
|
|
|
| |
sbuf as invalid (if not already read via stat()). Still trying
to find the build farm RAW-STREAM errors and it's happening
in a openX call....
Jeremy.
(cherry picked from commit 940c84fcc75085ee4f1180d4d2a8e718142e4eb6)
|
|
|
|
| |
(cherry picked from commit 55b7bf7338c13701944169df02ab8e9def6d43a1)
|
|
|
|
|
|
|
| |
Looks like the pathname parsing for POSIX paths got
broken when the code for doing Windows streams parsing got added.
Jeremy.
(cherry picked from commit 8d8c25a34241c1b4a1d40d7ad02bd1e1baa605be)
|
|
|
|
|
|
| |
metze
(cherry picked from commit 450252d2a1981fb04eb62eb095c1b762a96f7727)
(cherry picked from commit 3ccc0bd5ea15da6b4daa53d9dcfb6a283330493d)
|
|
|
|
|
|
|
|
|
|
| |
This code path can't really happen anymore, because
launchd support was removed with commit e5a951325a6cac8567af3a66de6d2df577508ae4.
But it's confusing to have that code there...
metze
(cherry picked from commit 445b37f4f35ff4256c46dbacc2d3b3a1e47e62b2)
(cherry picked from commit a527e24b80abf5aeaafdd67db21b5b021d1effe0)
|
|
|
|
| |
(cherry picked from commit 1f9bfa0673d47adcd62ceee5605788cc11201f3c)
|
|
|
|
| |
(cherry picked from commit 15ff8c88fbf1f417e8a0b0e0c25524d692d63a37)
|
|
|
|
| |
(cherry picked from commit 2d5e98e7e5a737dde360ab3490fff786fa0703b6)
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
| |
[MS-SMB] 3.3.5.1 Receiving Any Message says that the seqnum
is incremented by only for ntcancel requests for any other
request it's by incremented by 2, even if it doesn't expect
a response.
metze
|
|
|
|
|
| |
Confirmed by reporters.
Jeremy.
|
|
|
|
| |
This eliminates the last direct caller of create_file_unixpath
|
|
|
|
|
| |
if admin user.
Jeremy.
|
|
|
|
| |
Jeremy
|
|
|
|
|
|
|
| |
We need to store the "force group" uid separately from the
conn->server_info token as we need to apply it separately also.
Volker PLEASE CHECK !
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Why?? :-)
Another one of the little micro-optimizations that I just came across: If you
allocate a variable in a sub-block like the "fstring sharename" in
write_file(), gcc even with -O3 will allocate this variable unconditionally on
the stack at the beginning of the routine. So with eliminating this fstring we
cut 256 bytes of stack in a very hot code path writing to a file. It might make
us a bit more cache-friendly.
This would probably not be worth a second look if it involved larger code
changes, but this one was just too simple to let it pass :-)
|
|
|
|
|
| |
delete file (directory fix).
Jeremy.
|
|
|
|
| |
Guenther
|
|
|
|
|
|
|
| |
Inside a directory, keep a file open and then renaming
the directory should fail with ACCESS_DENIED.
Jeremy.
|
|
|
|
|
|
|
|
|
| |
failure if we have a pending modtime and the containing directory
of the file has been renamed (there is no POSIX "update time by
fd" call). This can't happen on Windows as the rename will fail
if there are open files beneath it. Will add a torture test
for this.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
| |
Was missing case of "If file exists open. If file doesn't exist error."
Damn damn damn. CIFSFS client will have to have fallback cases
for this error for a long time.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
Fixes the new RAW-STREAMS torture test.
Jeremy.
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
This allows sendfile implementations that are atomic to avoid having
to send zeros or kill the client connection on a short read (usually
the file was truncated).
|
| |
|
| |
|