summaryrefslogtreecommitdiffstats
path: root/source3/printing
Commit message (Collapse)AuthorAgeFilesLines
...
* s3-printing: add missing carriage return to debug strDavid Disseldorp2012-11-291-1/+1
| | | | Reviewed-by: Andreas Schneider <asn@samba.org>
* s3: Remove some calls to procid_selfVolker Lendecke2012-10-191-3/+3
| | | | | | | | | The goal is to have procid_self handling completely in the messaging_context. Signed-off-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri Oct 19 20:39:56 CEST 2012 on sn-devel-104
* s3fs-printing: Simplify the comment and location handling.Andreas Schneider2012-10-111-13/+17
| | | | | Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Oct 11 18:49:15 CEST 2012 on sn-devel-104
* s3fs-printing: Fix RAW printing for normal users.Andreas Schneider2012-10-081-1/+1
| | | | | | | This fixes bug #8769. Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Oct 8 16:11:51 CEST 2012 on sn-devel-104
* s3fs-smbd: Move housekeeping to the background process.Andreas Schneider2012-10-011-0/+9
| | | | | | | | | | | | | | | | If you add 200 printers using lpadmin. Then you wait for the printcap cache to expire. As soon as this expires we notify all deamons that they should reload the printers. This mean we need to create the default registry keys for each printer. If you do e.g. a 'smbclient -L' during that time you will get a lot of timeouts. This lets the housekeeping function of the printcap cache do the task of creating the default registry keys in background queue process. When it is done with the task it will tell all smbd childs to reload the printers and the 200 printers appear. Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Oct 1 20:28:23 CEST 2012 on sn-devel-104
* s3-printing: Increase debug level for info that the db is empty.Andreas Schneider2012-09-201-1/+2
| | | | | Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Sep 20 12:01:48 CEST 2012 on sn-devel-104
* s3-printing: fix bug 9123 lprng job tracking errorsDavid Disseldorp2012-08-292-3/+3
| | | | | | | | | | | | The lprng printing back-end is truncating the print job filename in the lpq output, which means that Samba is not able to determine the back-end job ID for a newly submitted print job. Remove the unneeded spoolss job ID from the print job file name to ensure the job filename is not truncated. Also log these warnings at a higher log level. Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Wed Aug 29 14:25:13 CEST 2012 on sn-devel-104
* Correctly check for errors in strlower_m() returns.Jeremy Allison2012-08-092-3/+5
|
* Fix incorrect use of server as a talloc context.Jeremy Allison2012-07-241-1/+1
|
* Use ippGet/ippSet (accessors) for IPP API.Jiri Popelka2012-07-202-176/+259
| | | | | | | | | | | | | | CUPS 1.6 makes various structures private and introduces these ippGet and ippSet functions for all of the fields in these structures. http://www.cups.org/str.php?L3928 We define our own accessors when CUPS < 1.6. Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Jul 20 22:35:55 CEST 2012 on sn-devel-104
* loadparm: make the source3/ lp_ functions take an explicit TALLOC_CTX *.Rusty Russell2012-07-1811-79/+86
| | | | | | | | | | They use talloc_tos() internally: hoist that up to the callers, some of whom don't want to us talloc_tos(). A simple patch, but hits a lot of files. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* nt_printing_tdb_migrate(): fix stackframe leak.Rusty Russell2012-07-181-0/+1
| | | | | Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* s3-printing: Remove deprecated lp_printer_admin().Andreas Schneider2012-07-031-11/+0
|
* s3-printing: fix broken print_job_get_name() returnDavid Disseldorp2012-06-271-1/+2
| | | | | Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Wed Jun 27 04:04:56 CEST 2012 on sn-devel-104
* s3-printing: use euid for vlp job trackingDavid Disseldorp2012-06-261-1/+2
| | | | | vlp can be called by print_run_command as root with euids set appropriately, vlp should use this to track the job owner.
* s3-printing: fill print_generic sysjob id on job submissionDavid Disseldorp2012-06-261-57/+88
| | | | | | | | | Change the generic print backend to fill the printing backend job identifier (sysjob) on submission of a new job. This is needed to ensure correct mapping of spoolss jobs and entries in the backend print queue. This and the last 13 commits attempt to address bug 8719.
* s3-printing: pass lpq command to job_submitDavid Disseldorp2012-06-264-4/+34
| | | | | | | | | | | Currently the generic print backend does not fill the printing backend job identifier (sysjob) on submission of a new job. The sysjob identifier is required to correctly map jobs in the printer queue to corresponding spoolss print jobs. Passing the lpq command to job_submit allows the generic print backend to check the printer queue for the new job following submission. This behaviour will come in a later commit.
* s3-printing: remove unused print_job_fname()David Disseldorp2012-06-261-16/+1
|
* s3-printing: pass a talloc ctx to unpack_pjobDavid Disseldorp2012-06-261-17/+21
| | | | Rather than allocating the devicemode on a null context.
* s3-printing: return talloced print jobsDavid Disseldorp2012-06-261-95/+196
| | | | | | | | | print_job_find() currently returns print jobs to callers via a statically allocated variable, this is particularly messy as the device mode is talloced under the static variable. This change adds or passes a talloc context to all callers, giving them ownership of the returned print job.
* s3-printing: clean up print_job_pause/resume interfaceDavid Disseldorp2012-06-261-19/+28
| | | | | Currently both return a bool and sometimes set a werr pointer argument, always return werror instead.
* s3-printing: fix potential print db refcount leakDavid Disseldorp2012-06-261-1/+1
|
* s3-spoolss: remove duplicate "." in smbd spooler pathDavid Disseldorp2012-06-261-3/+8
|
* s3-printing: remove print_parse_jobid()David Disseldorp2012-06-261-19/+0
| | | | With all callers fixed, it is now safe to remove.
* s3-printing: remove redundant variable setDavid Disseldorp2012-06-261-3/+0
|
* s3-printing: remove print_parse_jobid() calls from printing.cDavid Disseldorp2012-06-261-21/+27
| | | | | In all cases the spoolss layer job id can be determinded from the printing subsystem allocated job identifier (sysjob).
* s3-printing: rename queue->job sysjobDavid Disseldorp2012-06-264-26/+26
| | | | | | | | | | | | | | | Print jobs maintain two job identifiers, the jobid allocated by the spoolss layer (pj->jobid), and the job identifier defined by the printing backend (pj->sysjob). Printer job queues currently only contain a single job identifier variable (queue->job), the variable is sometimes representative of the spoolss layer job identifier, and more often representative of the printing backend id. This change renames the queue job identifier from queue->job to queue->sysjob, in preparation for a change to only store the printing backend identifier.
* s3-printing: remove print_parse_jobid() from print_cups.cDavid Disseldorp2012-06-261-11/+1
| | | | | | The spoolss print job identifier is now passed to the cups layer via struct printjob, therefore it is no longer necessary to parse the job filename to determine it.
* s3-printing: store print jobid as part of struct printjobDavid Disseldorp2012-06-261-12/+17
| | | | | | | Printing code in some places relies upon the spool-file format to retrieve the print jobid. By storing the jobid as part of struct printjob, and hence in the printing TDB, we can move away from this ugly behaviour.
* s3:printing: fix use of a non-existent word (existant)Michael Adam2012-06-121-1/+1
|
* s3:printing: let print_spool_open() take a uint64_t vuidStefan Metzmacher2012-06-061-1/+1
| | | | metze
* s3:printing: use smbd/smbd.h instead of just smbd/proto.h in queue_process.cStefan Metzmacher2012-06-061-1/+1
| | | | | | This fixes compiler warnings regarding incomplete types. metze
* s3:printing: add print_spool_rap_jobid()Stefan Metzmacher2012-06-061-0/+9
| | | | metze
* s3:printing: make struct print_file_data private to printspoolss.cStefan Metzmacher2012-06-061-0/+9
| | | | metze
* Forward port of Richard Sharpe's <realrichardsharpe@gmail.com> fix for bug ↵Jeremy Allison2012-05-311-1/+6
| | | | #8970 - Possible memory leaks in the samba master process.
* s3:smbd/msdfs: let create_conn_struct() also fake the 'smbd_server_connection'Stefan Metzmacher2012-05-241-3/+12
| | | | metze
* build: Remove SMB_OFF_T, replace with off_tAndrew Bartlett2012-04-062-4/+4
| | | | | | | | | Now that we always require a 64 bit off_t, we no longer need SMB_OFF_T. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Fri Apr 6 01:47:43 CEST 2012 on sn-devel-104
* lib/util: Remove obsolete sys_getpid() and sys_fork().Jelmer Vernooij2012-03-245-14/+14
| | | | | | | | | The performance of these is minimal (these days) and they can return invalid results when used as part of applications that do not use sys_fork(). Autobuild-User: Jelmer Vernooij <jelmer@samba.org> Autobuild-Date: Sat Mar 24 21:55:41 CET 2012 on sn-devel-104
* s3-printing: Make printer a const char *.Andreas Schneider2012-03-141-2/+6
|
* change low FDs are handled in SambaAndrew Bartlett2012-03-041-3/+0
| | | | | | | | | | | We now only close fds 0, 1, 2 when we are a forked daemon, and take care not to close a file descriptor that we might need for foreground stdin monitoring. This should fix stdout logging in the lsa and epmapper deamons (ie in make test). Andrew Bartlett
* Fix a bunch of "unused variable" warnings.Jeremy Allison2012-02-181-5/+0
| | | | | Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Feb 18 06:22:40 CET 2012 on sn-devel-104
* s3-printing: fix crash in printer_list_set_printer()David Disseldorp2012-02-151-1/+1
| | | | | | | | | | | | | | | | The printer list database format was recently changed to accommodate for the printcap location field. One of the tdb_pack calls is not provided with a location string argument, this causes a crash on some platforms. https://bugzilla.samba.org/show_bug.cgi?id=8762 Signed-off-by: Günther Deschner <gd@samba.org> Signed-off-by: Jim McDonough <jmcd@samba.org> Signed-off-by: Lars Müller <lars@samba.org> Autobuild-User: David Disseldorp <ddiss@samba.org> Autobuild-Date: Wed Feb 15 19:34:38 CET 2012 on sn-devel-104
* s3: files_struct->mode is only written, remove itVolker Lendecke2012-02-141-1/+0
| | | | | Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Tue Feb 14 19:14:29 CET 2012 on sn-devel-104
* s3-printing: Add new printers to registry.Björn Baumbach2012-02-091-2/+17
| | | | | | | | | This fixes bug #8554, #8612 and #8748. Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Thu Feb 9 16:39:04 CET 2012 on sn-devel-104
* Finally remove all malloc()'s from the substitute code. Now totallyJeremy Allison2012-01-271-3/+1
| | | | | | | talloc() based. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Jan 27 03:43:21 CET 2012 on sn-devel-104
* WERROR type variable being incorrectly checked with a NT_STATUS_IS_XDavid Disseldorp2012-01-231-1/+1
| | | | type macro.
* s3-spoolss: prefix print$ path on driver file deletionDavid Disseldorp2012-01-201-44/+37
| | | | | | | | | Driver file paths stored in the registry do not include the server path prefix. delete_driver_files() incorrectly assumes such a prefix. https://bugzilla.samba.org/show_bug.cgi?id=8697 Signed-off-by: Andreas Schneider <asn@samba.org>
* s3: Add a "lock_order" argument to db_openVolker Lendecke2012-01-181-1/+1
| | | | | | | This will be used to enforce a lock hierarchy between the databases. We have seen deadlocks between locking.tdb, brlock.tdb, serverid.tdb and notify*.tdb. These should be fixed by refusing a dbwrap_fetch_locked that does not follow a defined lock hierarchy.
* s3:printing: avoid messaging_event_context() in print_queue_housekeeping()Stefan Metzmacher2012-01-171-6/+21
| | | | metze
* s3:printing/spoolssd: avoid using server_messaging_context()Stefan Metzmacher2011-12-161-1/+1
| | | | | | | metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri Dec 16 16:29:41 CET 2011 on sn-devel-104