summaryrefslogtreecommitdiffstats
path: root/source3/libsmb
Commit message (Collapse)AuthorAgeFilesLines
* pylibsmb: Avoid a segfault if no credentials are passed to libsmb.Conn()Volker Lendecke2013-04-091-5/+5
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Autobuild-User(master): Richard Sharpe <sharpe@samba.org> Autobuild-Date(master): Tue Apr 9 18:30:06 CEST 2013 on sn-devel-104
* libsmbclient: Fix cli_session_setup_guest_sendVolker Lendecke2013-04-031-1/+1
| | | | | | | | | | | | | | This worked fine so far, but for the wrong reason: We only ever called this through the sync wrapper. The tevent_req_nterror in the NT_STATUS_OK case does not call tevent_req_finish. So the tevent_loop_poll did call into the core send/receive smb code. This is a fix for the case when smb1cli_req_chain_submit fails for some reason. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Apr 3 18:39:30 CEST 2013 on sn-devel-104
* s3:libsmb: let cli_read_andx_create() accept any lengthStefan Metzmacher2013-03-201-7/+0
| | | | | | | It's up to the server to decide the allowed length. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: make use of SMB_CAP_LEGACY_CLIENT_MASK instead of SMB_CAP_CLIENT_MASKStefan Metzmacher2013-03-201-2/+6
| | | | | | | | This should allow smbclient to keep using large reads against older Samba versions (<= 3.6.x) and other servers that may also require this. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:pylibsmb: make sure we get tevent debug messagesStefan Metzmacher2013-02-281-1/+8
| | | | | | | | | | Pair-Programmed-With: Michael Adam <obnox@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Feb 28 14:34:24 CET 2013 on sn-devel-104
* s3-libsmb: Don't leak memory on error.Andreas Schneider2013-02-221-0/+1
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* libsmb: Fix possible null pointer dereference.Andreas Schneider2013-02-221-2/+2
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s3:libsmb: s/struct event_context/struct tevent_contextStefan Metzmacher2013-02-1913-175/+175
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3:libsmb: make use of samba_tevent_context_init()Stefan Metzmacher2013-02-1913-77/+77
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3: use generate_random_password() instead of generate_random_str()Stefan Metzmacher2013-02-041-3/+4
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3-libsmb: Remove check if array is NULL.Andreas Schneider2012-12-211-1/+2
| | | | | | | | | | rdata is an array with data. rdlength defines how big rdata is. So if rdlength is not set we have a big problem. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-libsmb: Fix a possible null pointer dereference.Andreas Schneider2012-12-211-1/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-libsmb: Fix possible comparsion problems.Andreas Schneider2012-12-121-7/+21
| | | | | | | | | This makes the code also easier to understand. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* Clean up client timeout definitions [rev. 2]Scott Lovenberg2012-12-061-1/+2
| | | | | | | | | | The definitions for default client timeout values have been moved to client.h. When initializing a client struct we use this value instead of the old hardcoded value. The timeout value remains 20 seconds. Signed-off-by: Scott Lovenberg <scott.lovenberg@gmail.com> Reviewed by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Dec 6 03:25:58 CET 2012 on sn-devel-104
* s3:libsmb: add cli_{query,set}_security_descriptor() which take sec_info flagsStefan Metzmacher2012-12-022-16/+49
| | | | | | | | In order to set and get security_descriptors it's important to specify the sec_info flags. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3:libsmb: use smbXcli_conn_remote_name() in smb2_tcon_send()Stefan Metzmacher2012-09-291-4/+2
| | | | | | | metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Sat Sep 29 11:52:43 CEST 2012 on sn-devel-104
* s3:libsmb: make cli_echo* protocol independentStefan Metzmacher2012-09-291-32/+23
| | | | metze
* Fix bug #9213 - Bad ASN.1 NegTokenInit packet can cause invalid free.Jeremy Allison2012-09-261-0/+4
| | | | | | | | Not the correct fix for the specific issue, but a general fix to make sure this can never happen again. Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Sep 26 04:07:57 CEST 2012 on sn-devel-104
* s3-pylibsmb: Use Py_RETURN_NONEVolker Lendecke2012-09-241-9/+4
| | | | | Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Sep 24 08:09:53 CEST 2012 on sn-devel-104
* s3-pylibsmb: Add get_oplock_breakVolker Lendecke2012-09-231-0/+120
| | | | | Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Sun Sep 23 18:01:28 CEST 2012 on sn-devel-104
* s3-pylibsmb: Factor out py_tevent_cond_signalVolker Lendecke2012-09-231-3/+9
|
* s3-pylibsmb: Reduce the number of warningsVolker Lendecke2012-09-231-14/+32
|
* s3: Convert cli_oplock_break_waiter to smbXcliVolker Lendecke2012-09-231-5/+18
|
* s3: Add "readdir" to pylibsmbVolker Lendecke2012-09-231-0/+72
|
* s3: Fix some nonempty line endingsVolker Lendecke2012-09-231-4/+4
|
* s3-pylibsmb: move py_tevent_req_wait_exc up in the fileChristian Ambach2012-09-231-19/+19
| | | | | | | this is needed to be able to use it in other functions and spares the prototype Pair-Programmed-With: Volker Lendecke <vl@samba.org>
* s3-pylibsmb: Factor out py_tevent_cond_waitVolker Lendecke2012-09-231-14/+19
|
* s3:libsmb fix a double free errorChristian Ambach2012-09-171-1/+0
| | | | | | | t refers to self->thread_state that is freed a few lines below Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Mon Sep 17 22:04:13 CEST 2012 on sn-devel-104
* s3:libsmb fix a potential crashChristian Ambach2012-09-161-9/+12
| | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Sun Sep 16 22:31:38 CEST 2012 on sn-devel-104
* Avoid overriding default ccache for ads operations.Simo Sorce2012-09-122-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | Avoid overriding default ccache for ads operations. Nowadays various samba components may need to use GSSAPI and a default cred cache to perform their tasks. This code was completely overriding the whole process default ccache name, thus altering the current credentials and sometimes hijacking them (or getting preemptively hijaked). By using gss_krb5_import_cred we can instead use a private ccache (necessary sometimes to use a different set of credentials fromt he default cifs/fqdn@realm one, for example when contacting foreign DCs using trust credentials) that does not affect the rest of the process. For the kerberos versions which don't have gss_krb5_import_cred we fallback to temp override of KRB5CCNAME and gss_acquire_cred. Signed-off-by: Alexander Bokovoy <ab@samba.org> Signed-off-by: Günther Deschner <gd@samba.org> Autobuild-User(master): Alexander Bokovoy <ab@samba.org> Autobuild-Date(master): Wed Sep 12 21:18:09 CEST 2012 on sn-devel-104
* s3: Fix memleaks in pylibsmb.cVolker Lendecke2012-09-041-2/+2
| | | | | | Cut&Paste errors from the read&x routine Signed-off-by: Jeremy Allison <jra@samba.org>
* s3:libsmb correctly set isFsctl for snapshot listChristian Ambach2012-08-301-1/+1
| | | | | | | | | FSCTL_GET_SHADOW_COPY_DATA is a FSCTL, so set the isFsctl marker otherwise smbclient allinfo will not report snapshots any more with the changes made for Bug #8311 Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Thu Aug 30 18:57:24 CEST 2012 on sn-devel-104
* Fix bug in SMB_FIND_INFO_STANDARD parsing found by Volker.Jeremy Allison2012-08-221-1/+3
| | | | | | | | | The function align_string() is now broken as base_ptr no longer points at the start of the SMB data packet, but at the start of the returned TRANS2 data area. Replace it with a check for FLAGS2_UNICODE_STRINGS and a call to ucs2_align().
* s3-libsmb: Add a python wrapperVolker Lendecke2012-08-161-0/+671
| | | | | | Please note that this is not finished and only for internal use. Signed-off-by: Stefan Metzmacher <metze@samba.org>
* Check error returns from strupper_m() (in all reasonable places).Jeremy Allison2012-08-095-8/+23
|
* Fix missing ads_destroy in error path.Jeremy Allison2012-08-091-0/+1
|
* s3:libsmb: add EXTENDED_SIGNATURE support in cli_tcon_andx*()Stefan Metzmacher2012-08-041-0/+5
| | | | metze
* s3:libsmb: add a optional_support helper variableStefan Metzmacher2012-08-011-1/+6
| | | | metze
* s3:libsmb: add a tcon_flags helper variableStefan Metzmacher2012-08-011-1/+4
| | | | metze
* s3:libsmb: remove unused cli_state->user_session_keyStefan Metzmacher2012-08-012-21/+0
| | | | metze
* s3:libsmb: make use of smb1cli_session_set_session_key()Stefan Metzmacher2012-08-011-0/+24
| | | | metze
* s3: Fix Coverity ID 710791 Resource leakVolker Lendecke2012-07-311-0/+1
| | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Jul 31 13:34:53 CEST 2012 on sn-devel-104
* s3-libsmbclient: Add missing talloc_stackframe() callsAndrew Bartlett2012-07-291-0/+16
| | | | | | | | | | These caused a panic with the new assertion on the talloc stackframe being in place. Andrew Bartlett Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sun Jul 29 05:21:24 CEST 2012 on sn-devel-104
* lib/param: Rename "socket address" to "nbt client socket address" to clarify ↵Andrew Bartlett2012-07-271-2/+2
| | | | | | | | | | | | | role This parameter is only used in our NBT client code and in nmbd as a fallback when we fail to select a better interface from "interfaces" to use directly. Andrew Bartlett Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Jul 27 12:16:25 CEST 2012 on sn-devel-104
* libcli/smb: pass smbXcli_session to smb2cli_tcon_set_values()Stefan Metzmacher2012-07-251-0/+1
| | | | metze
* libcli/smb: there's no PID field in the SMB2/3 header anymoreStefan Metzmacher2012-07-251-2/+0
| | | | | | It's a reserved field... metze
* libcli/smb: pass smbXcli_tcon to smb2cli_req_create/send()Stefan Metzmacher2012-07-251-7/+2
| | | | metze
* s3:libsmb: remove unused tcon specific elements from cli_state->smb2Stefan Metzmacher2012-07-251-11/+13
| | | | metze
* s3:libsmb: remove cli_state->smb2.tidStefan Metzmacher2012-07-251-4/+9
| | | | metze
* libcli/smb: pass smbXcli_tcon to smb2cli_ioctl*()Stefan Metzmacher2012-07-241-1/+1
| | | | metze