summaryrefslogtreecommitdiffstats
path: root/source3/libsmb/clireadwrite.c
Commit message (Collapse)AuthorAgeFilesLines
* s3: remove unused variableBjörn Jacke2010-01-261-2/+0
|
* Second part of bug fix for 6606.Volker Lendecke2009-09-141-0/+6
| | | | s3:libsmb: Fix bug 6606 -- short reads in smbclient were not handled
* s3:libsmb: Fix bug 6606 -- short reads in smbclient were not handledVolker Lendecke2009-09-141-4/+118
|
* s3:libsmb: Convert (state->received) to (state->received != 0)Volker Lendecke2009-09-051-1/+1
| | | | This confused me for a second, this should not happen a second time :-)
* Fix Red Hat bugzilla bug : https://bugzilla.redhat.com/show_bug.cgi?id=516165Jeremy Allison2009-08-191-1/+1
| | | | | | | | | | nautilus fails to copy files from an SMB share. This is a show-stopper for 3.4.1 (I'll open a Samba.org bug). Although gnome-vfs is doing *incredibly* stupid things by asking for a read size of 65535 - this translates on the wire to a 65534 byte read followed by a 1 byte read. Please send this back to the gnome developers that they will ge horrid on the wire performance for this. Jeremy.
* s3: return proper error code in cli_smb_req_sendBo Yang2009-05-131-4/+16
| | | | Signed-off-by: Bo Yang <boyang@samba.org>
* Clean up assignments to iov_base, ensure it's always cast to void *. This ↵Jeremy Allison2009-05-121-2/+2
| | | | | | should quieten some warnings with picky compilers on the buildfarm. Jeremy.
* Get medieval on our ass about SMB1 file descriptors being 16 bits, not an int.Jeremy Allison2009-04-301-6/+6
| | | | | | | Convert all uses of cli_open(), cli_nt_createXXX to NTSTATUS versions. This is smaller than it looks, it just fixes a lot of old code. Next up, ensure all cli_XX functions return NTSTATUS. Jeremy.
* Convert cli_push to tevent_reqVolker Lendecke2009-04-081-69/+58
| | | | | | | | Metze, please check! Thanks, Volker
* Convert cli_pull to tevent_reqVolker Lendecke2009-04-081-45/+40
|
* Streamline cli_push sync wrapperVolker Lendecke2009-04-061-9/+18
|
* Convert cli_write_andx to tevent_reqVolker Lendecke2009-04-061-37/+88
|
* Streamline cli_pull sync wrapperVolker Lendecke2009-04-061-9/+18
|
* Convert cli_read_andx to tevent_reqVolker Lendecke2009-04-061-108/+150
|
* Revert "s3:libsmb: add an option to cli_push to let the caller provide the ↵Stefan Metzmacher2009-03-121-25/+8
| | | | | | | | | | | | | buffers" This reverts commit 9579a6f193f570e4ce2af80f4aac7c2f25ae5b22. It's confusing to have a boolean to alter the behavior of cli_push and as the new feature isn't used yet I revert it. We can readd a extra function later. metze
* s3:libsmb: add an option to cli_push to let the caller provide the buffersStefan Metzmacher2009-03-101-8/+25
| | | | metze
* s3:libsmb: only treat a return 0 as end of fileStefan Metzmacher2009-03-101-4/+1
| | | | metze
* s3:libsmb: fix a lot of cli_push() bugsStefan Metzmacher2009-03-101-95/+107
| | | | | | | | | | | | There were the following problems: 1.) if window_size was a multiple of the chunk_size, we silently dropped the last truncated chunk. 2.) if window_size was 0 pushed only the first chunk to the server and silently dropped the rest. 3.) we had only transferred state->num_reqs writes, even if there would be more data to send. metze
* Next step disentangling async_req from NTSTATUSVolker Lendecke2009-02-021-1/+1
| | | | Now I need to document this :-)
* Split up async_req into a generic and a NTSTATUS specific partVolker Lendecke2009-02-011-16/+16
|
* Add a macro async_req_setup()Volker Lendecke2009-01-181-25/+9
| | | | This streamlines setting up a multi-step async request a bit
* struct async_req doesn't really need to carry an event_contextVolker Lendecke2009-01-031-5/+5
|
* Add async cli_write_andx and cli_pullVolker Lendecke2008-12-191-0/+406
|
* Pass "bytes_alignment" up through cli_request_sendVolker Lendecke2008-12-191-1/+1
| | | | This parameter makes smb_spice_chain add padding before the bytes field
* Factor out cli_write_max_bufsizeVolker Lendecke2008-12-191-25/+36
|
* For read&x replies, check the offsetVolker Lendecke2008-12-131-0/+19
|
* Simplify async programming a bit with helper routinesVolker Lendecke2008-12-081-6/+5
| | | | Introduce async_req_is_error() and async_req_simple_recv()
* Use {u,}int64_t instead of SMB_BIG_{U,}INT.Jelmer Vernooij2008-10-141-3/+3
|
* Remove cli_request_get()Volker Lendecke2008-08-281-4/+8
| | | | | req->private_data==NULL at this point is definitely a bug. (This used to be commit ce3dc9f616cafc1289a94ac7cae0beca967d836e)
* Add cli_pull_replyVolker Lendecke2008-08-281-5/+12
| | | | | | Along the lines of cli_request_send this abstracts away the smb-level buffer handling when parsing replies we got from the server. (This used to be commit 253134d3aaa359fdfb665709dd5686f69af7f8fd)
* Remove cli->event_ctx, pass it explicitlyVolker Lendecke2008-08-281-9/+24
| | | | | | Storing the event_context as permanent state in struct cli_state creates more complex code than necessary IMO. (This used to be commit debb37f703075008e5ea7d34d214cfa4d0f8f916)
* Refactoring: Add the routine cli_request_send()Volker Lendecke2008-08-281-46/+25
| | | | | | cli_request_send() is supposed to bundle all generic SMB-header handling. This makes cli_request_new static to async_smb.c. (This used to be commit 7e73dd4e7622db64d30d48ba106892e0895fc188)
* Revert "Protect against short read&x replies"Volker Lendecke2008-08-231-4/+0
| | | | | | | | | This reverts commit 4ed73cbbbeff4b554cc8d28252b756241396b3a1. ... how did this end up here?? Volker (This used to be commit 7dd9fd0956bd1c46105d1072c4774972933ab9ec)
* Protect against short read&x repliesVolker Lendecke2008-08-231-0/+4
| | | | (This used to be commit 4ed73cbbbeff4b554cc8d28252b756241396b3a1)
* cli_request_new() already gave use the req, remove a pointless function callVolker Lendecke2008-08-011-2/+0
| | | | (This used to be commit 08e97bd369ebe3ab1fd92433b168585faea92c68)
* Security fix for CVE-2008-1105: Boundary failure when parsing SMB responsesJeremy Allison2008-05-281-100/+0
| | | | | | can result in a buffer overrun. Jeremy. (This used to be commit 23b825e9d2c74c5b940cf4d3aa56c18692259972)
* Fix bug #5479, print spool shares require max_xmit toJeremy Allison2008-05-211-1/+6
| | | | | | be adhered to. Jeremy. (This used to be commit 478a359edead0677281a3ca4e64db6521941b0f3)
* Fix bug 5399Volker Lendecke2008-04-191-5/+0
| | | | | | | Thanks to Jason Mader! Volker (This used to be commit 36740f4959194cfaa98b1e37eed08f22edbda1e4)
* Fix bug #5326 - OS/2 servers give strange "high word" replies for print jobs.Jeremy Allison2008-03-281-1/+3
| | | | | Jeremy. (This used to be commit d090d25cb702965b3d5e4635a26a06f2b62d235d)
* More ssize_t->SMB_OFF_TVolker Lendecke2008-03-281-5/+5
| | | | (This used to be commit 8dd6458049d1b9d6849730ac19c39b049a68f302)
* On Solaris, size_t seems to be only 32 bit.Volker Lendecke2008-03-211-5/+7
| | | | | | | Fix bug 5341, thanks a lot to Karoly Vegh for testing it! Volker (This used to be commit 19eb8c9316b10b1277121e90d0d3ef50ee562118)
* !NT_STATUS_IS_OK != NT_STATUS_IS_ERRVolker Lendecke2008-03-191-1/+1
| | | | | | When reading from a pipe, Windows return STATUS_BUFFER_OVERFLOW which is *not* an error. (This used to be commit 24018d882d1b1cfece47c533fe5bbca91de124cc)
* Fix bug 5334Volker Lendecke2008-03-181-0/+8
| | | | | I did not test with a zero length file :-) (This used to be commit 7d7a73944c2dcf078f7bc8de65d575f32f9aa851)
* Correctly calculate the max read sizeVolker Lendecke2008-03-081-1/+1
| | | | (This used to be commit f556c9e162e2bc0d16710e994a00edc33a146cd5)
* Convert cli_read to use cli_pullVolker Lendecke2008-03-061-163/+15
| | | | (This used to be commit d69b20111a849152a7d9108763207c813bf9068b)
* Add async cli_pull supportVolker Lendecke2008-03-061-0/+425
| | | | | | | | | | | | | This is the big (and potentially controversial) one. It took a phone call to explain to metze what is going on inside cli_pull_read_done, but I would really like everybody to understand this function. It is a very good and reasonably complex example of async programming. If we want more asynchronism in s3, this is what we will have to deal with :-) Make use of it in the smbclient "get" command. Volker (This used to be commit 76f9b360ee1d973630d82d401eeddce858189301)
* Fix bug found by Derrell - windows returns an read returnJeremy Allison2008-01-161-21/+28
| | | | | | | offset of zero if return size is zero. Should fix testread libsmbclient code. Jeremy. (This used to be commit df3c4648399f8d62ff6fe0013be8b89abc18f0f0)
* Windows insists on write sizes < max_xmit on signed connections.Jeremy Allison2008-01-141-3/+6
| | | | | Jeremy. (This used to be commit ef9b278b6289a9ecdd6b103927058f64fbb7eb97)
* Add SMB encryption. Still fixing client decrypt butJeremy Allison2007-12-261-14/+17
| | | | | | negotiation works. Jeremy. (This used to be commit d78045601af787731f0737b8627450018902b104)
* Ensure we don't use massive writes in pipe mode.Jeremy Allison2007-11-061-2/+3
| | | | | Jeremy. (This used to be commit 47640fb20e42f226e7ea104076fd52547bfe1abb)