summaryrefslogtreecommitdiffstats
path: root/source3/libsmb/clireadwrite.c
Commit message (Collapse)AuthorAgeFilesLines
* Revert "s3:libsmb: add an option to cli_push to let the caller provide the ↵Stefan Metzmacher2009-03-121-25/+8
| | | | | | | | | | | | | buffers" This reverts commit 9579a6f193f570e4ce2af80f4aac7c2f25ae5b22. It's confusing to have a boolean to alter the behavior of cli_push and as the new feature isn't used yet I revert it. We can readd a extra function later. metze
* s3:libsmb: add an option to cli_push to let the caller provide the buffersStefan Metzmacher2009-03-101-8/+25
| | | | metze
* s3:libsmb: only treat a return 0 as end of fileStefan Metzmacher2009-03-101-4/+1
| | | | metze
* s3:libsmb: fix a lot of cli_push() bugsStefan Metzmacher2009-03-101-95/+107
| | | | | | | | | | | | There were the following problems: 1.) if window_size was a multiple of the chunk_size, we silently dropped the last truncated chunk. 2.) if window_size was 0 pushed only the first chunk to the server and silently dropped the rest. 3.) we had only transferred state->num_reqs writes, even if there would be more data to send. metze
* Next step disentangling async_req from NTSTATUSVolker Lendecke2009-02-021-1/+1
| | | | Now I need to document this :-)
* Split up async_req into a generic and a NTSTATUS specific partVolker Lendecke2009-02-011-16/+16
|
* Add a macro async_req_setup()Volker Lendecke2009-01-181-25/+9
| | | | This streamlines setting up a multi-step async request a bit
* struct async_req doesn't really need to carry an event_contextVolker Lendecke2009-01-031-5/+5
|
* Add async cli_write_andx and cli_pullVolker Lendecke2008-12-191-0/+406
|
* Pass "bytes_alignment" up through cli_request_sendVolker Lendecke2008-12-191-1/+1
| | | | This parameter makes smb_spice_chain add padding before the bytes field
* Factor out cli_write_max_bufsizeVolker Lendecke2008-12-191-25/+36
|
* For read&x replies, check the offsetVolker Lendecke2008-12-131-0/+19
|
* Simplify async programming a bit with helper routinesVolker Lendecke2008-12-081-6/+5
| | | | Introduce async_req_is_error() and async_req_simple_recv()
* Use {u,}int64_t instead of SMB_BIG_{U,}INT.Jelmer Vernooij2008-10-141-3/+3
|
* Remove cli_request_get()Volker Lendecke2008-08-281-4/+8
| | | | | req->private_data==NULL at this point is definitely a bug. (This used to be commit ce3dc9f616cafc1289a94ac7cae0beca967d836e)
* Add cli_pull_replyVolker Lendecke2008-08-281-5/+12
| | | | | | Along the lines of cli_request_send this abstracts away the smb-level buffer handling when parsing replies we got from the server. (This used to be commit 253134d3aaa359fdfb665709dd5686f69af7f8fd)
* Remove cli->event_ctx, pass it explicitlyVolker Lendecke2008-08-281-9/+24
| | | | | | Storing the event_context as permanent state in struct cli_state creates more complex code than necessary IMO. (This used to be commit debb37f703075008e5ea7d34d214cfa4d0f8f916)
* Refactoring: Add the routine cli_request_send()Volker Lendecke2008-08-281-46/+25
| | | | | | cli_request_send() is supposed to bundle all generic SMB-header handling. This makes cli_request_new static to async_smb.c. (This used to be commit 7e73dd4e7622db64d30d48ba106892e0895fc188)
* Revert "Protect against short read&x replies"Volker Lendecke2008-08-231-4/+0
| | | | | | | | | This reverts commit 4ed73cbbbeff4b554cc8d28252b756241396b3a1. ... how did this end up here?? Volker (This used to be commit 7dd9fd0956bd1c46105d1072c4774972933ab9ec)
* Protect against short read&x repliesVolker Lendecke2008-08-231-0/+4
| | | | (This used to be commit 4ed73cbbbeff4b554cc8d28252b756241396b3a1)
* cli_request_new() already gave use the req, remove a pointless function callVolker Lendecke2008-08-011-2/+0
| | | | (This used to be commit 08e97bd369ebe3ab1fd92433b168585faea92c68)
* Security fix for CVE-2008-1105: Boundary failure when parsing SMB responsesJeremy Allison2008-05-281-100/+0
| | | | | | can result in a buffer overrun. Jeremy. (This used to be commit 23b825e9d2c74c5b940cf4d3aa56c18692259972)
* Fix bug #5479, print spool shares require max_xmit toJeremy Allison2008-05-211-1/+6
| | | | | | be adhered to. Jeremy. (This used to be commit 478a359edead0677281a3ca4e64db6521941b0f3)
* Fix bug 5399Volker Lendecke2008-04-191-5/+0
| | | | | | | Thanks to Jason Mader! Volker (This used to be commit 36740f4959194cfaa98b1e37eed08f22edbda1e4)
* Fix bug #5326 - OS/2 servers give strange "high word" replies for print jobs.Jeremy Allison2008-03-281-1/+3
| | | | | Jeremy. (This used to be commit d090d25cb702965b3d5e4635a26a06f2b62d235d)
* More ssize_t->SMB_OFF_TVolker Lendecke2008-03-281-5/+5
| | | | (This used to be commit 8dd6458049d1b9d6849730ac19c39b049a68f302)
* On Solaris, size_t seems to be only 32 bit.Volker Lendecke2008-03-211-5/+7
| | | | | | | Fix bug 5341, thanks a lot to Karoly Vegh for testing it! Volker (This used to be commit 19eb8c9316b10b1277121e90d0d3ef50ee562118)
* !NT_STATUS_IS_OK != NT_STATUS_IS_ERRVolker Lendecke2008-03-191-1/+1
| | | | | | When reading from a pipe, Windows return STATUS_BUFFER_OVERFLOW which is *not* an error. (This used to be commit 24018d882d1b1cfece47c533fe5bbca91de124cc)
* Fix bug 5334Volker Lendecke2008-03-181-0/+8
| | | | | I did not test with a zero length file :-) (This used to be commit 7d7a73944c2dcf078f7bc8de65d575f32f9aa851)
* Correctly calculate the max read sizeVolker Lendecke2008-03-081-1/+1
| | | | (This used to be commit f556c9e162e2bc0d16710e994a00edc33a146cd5)
* Convert cli_read to use cli_pullVolker Lendecke2008-03-061-163/+15
| | | | (This used to be commit d69b20111a849152a7d9108763207c813bf9068b)
* Add async cli_pull supportVolker Lendecke2008-03-061-0/+425
| | | | | | | | | | | | | This is the big (and potentially controversial) one. It took a phone call to explain to metze what is going on inside cli_pull_read_done, but I would really like everybody to understand this function. It is a very good and reasonably complex example of async programming. If we want more asynchronism in s3, this is what we will have to deal with :-) Make use of it in the smbclient "get" command. Volker (This used to be commit 76f9b360ee1d973630d82d401eeddce858189301)
* Fix bug found by Derrell - windows returns an read returnJeremy Allison2008-01-161-21/+28
| | | | | | | offset of zero if return size is zero. Should fix testread libsmbclient code. Jeremy. (This used to be commit df3c4648399f8d62ff6fe0013be8b89abc18f0f0)
* Windows insists on write sizes < max_xmit on signed connections.Jeremy Allison2008-01-141-3/+6
| | | | | Jeremy. (This used to be commit ef9b278b6289a9ecdd6b103927058f64fbb7eb97)
* Add SMB encryption. Still fixing client decrypt butJeremy Allison2007-12-261-14/+17
| | | | | | negotiation works. Jeremy. (This used to be commit d78045601af787731f0737b8627450018902b104)
* Ensure we don't use massive writes in pipe mode.Jeremy Allison2007-11-061-2/+3
| | | | | Jeremy. (This used to be commit 47640fb20e42f226e7ea104076fd52547bfe1abb)
* Change the client library to write directly out ofJeremy Allison2007-11-021-32/+74
| | | | | | | | the incoming buffer in the non-signed case. Speeds up writes by over 10% or so. Complete the server recvfile implementation. Jeremy. (This used to be commit 81ca5853b2475f123faab3b550f0a7b24ae3c208)
* Our userlevel SMBwriteX call is non-standard in that itJeremy Allison2007-10-301-8/+10
| | | | | | | | | | sometimes uses a 12-word write and doesn't include a pad byte (as Windows does). Fix this so that we are identical to Windows clients. This will make recvfile processing much easier to detect (as we can just read a standard writeX header length to decide). Jeremy. (This used to be commit 3d3d1b806aef3617abaac46daf230ed32076e2ce)
* RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison2007-10-181-7/+7
| | | | | | | | bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
* [GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.Gerald (Jerry) Carter2007-10-101-8/+6
| | | | (This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
* r23784: use the GPLv3 boilerplate as recommended by the FSF and the license textAndrew Tridgell2007-10-101-2/+1
| | | | (This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
* r23779: Change from v2 or later to v3 or later.Jeremy Allison2007-10-101-1/+1
| | | | | Jeremy. (This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
* r23148: Fix old old bug in cli_smbwrite() (not incrementingJeremy Allison2007-10-101-1/+1
| | | | | | data being sent). Patch from mnix@wanm.com.au. Jeremy. (This used to be commit 2524d85465ba5406e684199c10f59e685ab860b5)
* r22920: Add in the UNIX capability for 24-bit readX, as discussedJeremy Allison2007-10-101-10/+40
| | | | | | | with the Apple guys and Linux kernel guys. Still looking at how to do writeX as there's no recvfile(). Jeremy. (This used to be commit a53268fb2082de586e2df250d8ddfcff53379102)
* r22391: Looks bigger than it is. Make "inbuf" availableJeremy Allison2007-10-101-5/+5
| | | | | | | | to all callers of smb_setlen (via set_message() calls). This will allow the server to reflect back the correct encryption context. Jeremy. (This used to be commit 2d80a96120a5fe2fe726f00746d36d85044c4bdb)
* r17333: Some C++ warningsVolker Lendecke2007-10-101-2/+2
| | | | (This used to be commit be9aaffdaccae06c8c035eaf31862e34b7cfbe38)
* r15162: Patch for bug #3668. Windows has a bug with LARGE_READXJeremy Allison2007-10-101-1/+5
| | | | | | where if you ask for exactly 64k bytes it returns 0. Jeremy. (This used to be commit dcef65acb5bc08ea4b61ef490a518b7e668ff2ee)
* r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison2007-10-101-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy. (This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
* r13119: Fix for #1779 from William Jojo <jojowil@hvcc.edu>Jeremy Allison2007-10-101-4/+6
| | | | | Jeremy. (This used to be commit 103cac7dd314117b15e27fd263a64beeb36ed6e6)
* r10656: BIG merge from trunk. Features not copied overGerald Carter2007-10-101-6/+6
| | | | | | | | * \PIPE\unixinfo * winbindd's {group,alias}membership new functions * winbindd's lookupsids() functionality * swat (trunk changes to be reverted as per discussion with Deryck) (This used to be commit 939c3cb5d78e3a2236209b296aa8aba8bdce32d3)
generated by cgit (git 2.34.1) at 2025-08-29 20:41:49 +0000