| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Guenther
(cherry picked from commit b5bec1a6d73f5939b306e157937d027a7286163c)
(cherry picked from commit c7d5e0a19057b6ad7301a390fc766bb438967eb2)
|
|
|
|
|
|
|
|
| |
What a difference a name makes... :-). Just because something is missnamed
SAMR_ACCESS_OPEN_DOMAIN, when it should actually be SAMR_ACCESS_LOOKUP_DOMAIN,
don't automatically use it for a security check in _samr_OpenDomain().
Jeremy.
(cherry picked from commit 1994a8a5db5c3abd6292b81aa975e7b8fe8311d0)
|
|
|
|
|
|
| |
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit 574a6a8c350a4bab3f42f3f9cfb382db721d69b5)
(cherry picked from commit 7e6d6eeff3e082d7223264c17cb27c2ab89df9aa)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove ads_memfree(), which was only ever a wrapper around
SAFE_FREE, used only to free the DN from ads_get_ds().
This actually makes libgpo more consistant, as it mixed a talloc and a
malloc based string on the same element.
Andrew Bartlett
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit 20501876735fc4656083747ba8aa0de9da8fb820)
(cherry picked from commit 6673ad24d48ad44fa76497f0327b13e82721d0a1)
|
|
|
|
|
|
| |
Guenther
(cherry picked from commit 5cdf75e679a45dcc3dad56e54f5c9f7d7ea23200)
(cherry picked from commit 7cf7c00663a41de202d695fb1f8dab7c3906e165)
|
|
|
|
|
|
| |
Guenther
(cherry picked from commit e18f57fd36102212a3662823c58408da01d067ed)
(cherry picked from commit 2a0f4fd1b4fa58f5cf89595e93053abc6101817d)
|
|
|
|
|
|
| |
Guenther
(cherry picked from commit e4802bfcad0402fce1e942e22d5533b3c14ada80)
(cherry picked from commit 32c7e6c9e5a2a02b6972293c9d5233f4797899c8)
|
|
|
|
|
|
| |
Guenther
(cherry picked from commit af78240cbe68282190980cd6c367a8fc2a4438a6)
(cherry picked from commit c9bee2d4f982f677ced90ba18dc6326560139ed0)
|
|
|
|
|
|
|
|
| |
when filled in.
Guenther
(cherry picked from commit 264b28ec0962c355ee90f9ac67fcf07cd84c5c7b)
(cherry picked from commit 7c553eb319de84a3510d348d3f927d11253aaacf)
|
|
|
|
|
|
|
|
|
|
|
|
| |
libnet_samsync_delta().
We absolutely need to avoid messing with the sync_context as that breaks the
stream of replication data coming from the DC (only replicates ~350 instead of
~4000 groups).
Guenther
(cherry picked from commit e3f7057b0942793543c215ab45176c4280bd7d51)
(cherry picked from commit 16cba3ec22ca424db0f98185e179c718794bc563)
|
|
|
|
|
|
| |
Guenther
(cherry picked from commit 531af136f9dd5c6050f78948837294aed02de440)
(cherry picked from commit 91216ffa95b4ed53e54b11665e96b911cb4e4ab5)
|
|
|
|
| |
Michael
|
|
|
|
| |
Guenther
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
lp_use_kerberos_keytab parameter.
The first is "kerberos method" and replaces the "use kerberos keytab"
with an enum. Valid options are:
secrets only - use only the secrets for ticket verification (default)
system keytab - use only the system keytab for ticket verification
dedicated keytab - use a dedicated keytab for ticket verification.
secrets and keytab - use the secrets.tdb first, then the system keytab
For existing installs:
"use kerberos keytab = yes" corresponds to secrets and keytab
"use kerberos keytab = no" corresponds to secrets only
The major difference between "system keytab" and "dedicated keytab" is
that the latter method relies on kerberos to find the correct keytab
entry instead of filtering based on expected principals.
The second parameter is "dedicated keytab file", which is the keytab
to use when in "dedicated keytab" mode. This keytab is only used in
ads_verify_ticket.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
version.h changes rather frequently. Since it is included via includes.h,
this means each C file will be a cache miss. This applies to the following
situations:
* When building a new package with a new Samba version
* building in a git branch after calling mkversion.sh
after a new commit (i.e. virtually always)
This patch improves the situation in the following way:
* remove inlude "version.h" from includes.h
* Use samba_version_string() instead of SAMBA_VERSION_STRING
in files that use no other macro from version.h instead of
SAMBA_VERSION_STRING.
* explicitly include "version.h" in those files that use more
macros from "version.h" than just SAMBA_VERSION_STRING.
Michael
|
|
|
|
| |
Guenther
|
|
|
|
| |
Jeremy
|
|
|
|
|
| |
attribute warn_unused_result. Start to fix these.
Jeremy.
|
|
|
|
| |
metze
|
|
|
|
|
|
|
|
| |
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(similar to commit feef594d275881466e2c3f59c0ff54609a9cc53b)
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Cooper S. Blake" <the_analogkid@yahoo.com>.
"I believe I have found two bugs in the 3.2 code and one bug that
carried on to the 3.3 branch. In the 3.2 code, everything is
located in the utils/net_rpc_samsync.c file. What I believe is the
first problem is that fetch_database() is calling
samsync_fix_delta_array() with rid_crypt set to true, which means
the password hashes are unencrypted from the RID encryption.
However, I believe this call is redundant, and the corresponding
call for samdump has rid_crypt set to false. So I think the
rid_crypt param should be false in fetch_database().
If you follow the code, it makes its way to sam_account_from_delta()
where the password hashes are decrypted a second time by calling
sam_pwd_hash(). I believe this is what is scrambling my passwords.
These methods were refactored somewhere in the 3.3 branch. Now the
net_rpc_samsync.c class calls rpc_vampire_internals, which calls
libnet/libnet_samsync.c, which calls samsync_fix_delta_array() with
rid_crypt always set to false. I think that's correct. But the
second bug has carried through in the sam_account_from_delta()
function:
208 if (memcmp(r->ntpassword.hash, zero_buf, 16) != 0) {
209 sam_pwd_hash(r->rid, r->ntpassword.hash, lm_passwd, 0);
210 pdb_set_lanman_passwd(account, lm_passwd, PDB_CHANGED);
211 }
212
213 if (memcmp(r->lmpassword.hash, zero_buf, 16) != 0) {
214 sam_pwd_hash(r->rid, r->lmpassword.hash, nt_passwd, 0);
215 pdb_set_nt_passwd(account, nt_passwd, PDB_CHANGED);
If you look closely you'll see that the nt hash is going into the
lm_passwd variable and the decrypted value is being set in the lanman
hash, and the lanman hash is being decrypted and put into the nt hash
field. So the LanMan and NT hashes look like they're being put in
the opposite fields."
Fix this by removing the rid_crypt parameter.
Jeremy.
|
|
|
|
| |
Samba 4.
|
|
|
|
| |
Guenther
|
|
|
|
| |
Guenther
|