summaryrefslogtreecommitdiffstats
path: root/source3/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* gencache: unify a DEBUG message in gencache_iterate_fn()Michael Adam2013-02-191-1/+1
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* gencache: unify a DEBUG message in gencache_iterate_blobs_fn()Michael Adam2013-02-191-1/+2
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* gencache: unify a DEBUG message in gencache_del()Michael Adam2013-02-191-1/+1
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:dbrwap_ctdb: ZERO_STRUCT(rec) just to be sure in ↵Michael Adam2013-02-041-0/+1
| | | | | | | traverse_persistent_callback_read() Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:dbwrap_ctdb: ZERO_STRUCT(rec) just to be sure in traverse_read_callback()Michael Adam2013-02-041-0/+2
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:dbwrap_ctdb: add "db_context" to "db_record"Stefan Metzmacher2013-02-041-2/+5
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3:dbwrap_ctdb: setup result->name in db_open_ctdb()Stefan Metzmacher2013-02-041-0/+7
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* smbd: Fix a typoVolker Lendecke2013-01-301-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* Avoid a very small memleak on talloc_tos()Volker Lendecke2013-01-251-4/+1
| | | | | | | | | | "fname" did leak on talloc_tos(). Not really a bad memleak, but as I just came across it I thought I might just fix it Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Jan 25 00:54:01 CET 2013 on sn-devel-104
* Fix bug #9586 - smbd[29175]: disk_free: sys_popen() failed" message logged ↵Jeremy Allison2013-01-241-1/+1
| | | | | | | | | | | | | in /var/log/message many times. Ensure when reading lines from an interruptible pipe source we ignore EINTR. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Thu Jan 24 10:45:48 CET 2013 on sn-devel-104
* dbwrap: Use INCOMPATIBLE_HASH for dbwrap_watchers.tdbVolker Lendecke2013-01-111-3/+4
| | | | Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3-lib: Use new strict directory create function in create_pipe_sock().Andreas Schneider2013-01-091-44/+6
| | | | | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Jan 9 10:55:23 CET 2013 on sn-devel-104
* s3-prefork: Directly fail if tevent_req_is_unix_error() fails.Andreas Schneider2012-12-211-1/+3
| | | | | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Fri Dec 21 15:38:19 CET 2012 on sn-devel-104
* s3-lib: Cleanup transfer_file_internal() a bit.Andreas Schneider2012-12-211-2/+6
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-lib: Make it clear that we want to fall trough here.Andreas Schneider2012-12-211-0/+2
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-netapi: Add missing break in NetUserSetInfo_r().Andreas Schneider2012-12-211-0/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-lib: Fix push_ucs2() for-loop.Andreas Schneider2012-12-211-2/+2
| | | | | | | | | | | | ret is a bool and size is what we are looking for here, else the statement can never be true. Jeremy please check! Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-tldap: Fix dead code in tldap_sasl_bind_send().Andreas Schneider2012-12-211-1/+1
| | | | | | | | | dn can't be NULL cause it is set to "" in that case. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-eventlog: Make sure the eventlog directory exists.Andreas Schneider2012-12-211-2/+5
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-lib: Don't close the listener twice if we goto failed.Andreas Schneider2012-12-121-1/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-ctdb: Make sure addr.sun_path is null terminated.Andreas Schneider2012-12-121-1/+1
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-lib: Remove unsused variable from sys_get_nfs_quota().Andreas Schneider2012-12-121-2/+1
| | | | | | | | | testpath is the same a few lines later. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-netapi: Initialize group_handle of NetGroupSetUsers_r().Andreas Schneider2012-12-121-0/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4-netapi: Initialize group_handle of NetGroupGetUsers_r().Andreas Schneider2012-12-121-0/+1
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s3-netapi: Initialize group_handle of NetUserSetGroups_r.Andreas Schneider2012-12-121-0/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s3-netapi: Fix zeroing policy handles in NetLocalGroupAdd_r().Andreas Schneider2012-12-121-5/+5
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* util: Use new samba_getpass() function.Andreas Schneider2012-12-031-4/+5
| | | | Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
* s3:passdb: add sid_check_object_is_for_passdb()Michael Adam2012-12-032-0/+34
| | | | | | | | Variant of sid_check_is_for_passdb() that only checks for objects in the various domains, not for the domain sids themselves. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:lib: add utility function sid_check_is_for_passdb()Michael Adam2012-12-032-0/+102
| | | | | | | | This function checks whether the given sid should be treated by passdb (e.g. for id mapping). Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:popt_common: Fix password processing.Stefan Metzmacher2012-11-301-11/+2
| | | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri Nov 30 14:01:08 CET 2012 on sn-devel-104
* dbwrap: Do not rely on dbwrap_record_get_value to return a talloc objectVolker Lendecke2012-11-291-2/+3
| | | | | | | | | | | db_tdb_fetch_locked returns the value as part of a larger talloc object that also contains the key. This means we can not realloc, but have to freshly alloc. Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Nov 29 20:21:51 CET 2012 on sn-devel-104
* s3: Remove db_ctdb_fetchVolker Lendecke2012-11-291-55/+11
| | | | | | | Note that this also makes the request for read only copies much more explicity visible in the code. Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Directly parse local existing records in db_ctdb_parse_recordVolker Lendecke2012-11-291-0/+22
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Factor out db_ctdb_can_use_local_hdr from db_ctdb_can_use_local_copyVolker Lendecke2012-11-291-11/+14
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Remove unused code for fetching persistent ctdb recordsVolker Lendecke2012-11-291-129/+0
| | | | | | | The only entry point here is parse_record, and this catches the persistent case with a direct parse now Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Avoid db_ctdb_fetch for persistent databasesVolker Lendecke2012-11-291-0/+44
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Factor out parse_newest_in_marshall_buffer from ↵Volker Lendecke2012-11-291-15/+51
| | | | | | pull_newest_from_marshall_buffer Reviewed-by: Michael Adam <obnox@samba.org>
* s3: reduce db_ctdb_marshall_loop_next to specialized db_ctdb_marshall_buf_parseVolker Lendecke2012-11-291-48/+21
| | | | | | now that the db_ctdb_marshall_loop_next_key has been factored out. Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Factor out db_ctdb_marshall_loop_next_key from db_ctdb_marshall_loop_nextVolker Lendecke2012-11-291-9/+24
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Slightly simplify db_ctdb_marshall_loop_nextVolker Lendecke2012-11-291-4/+3
| | | | | | Both callers give a key argument Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Use db_ctdb_ltdb_parse in db_ctdb_fetch_db_seqnum_from_dbVolker Lendecke2012-11-291-20/+21
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Use db_ctdb_ltdb_parse in db_ctdb_ltdb_fetchVolker Lendecke2012-11-291-30/+46
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Add db_ctdb_ltdb_parseVolker Lendecke2012-11-291-0/+42
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Slightly simplify db_ctdb_transaction_commitVolker Lendecke2012-11-291-1/+2
| | | | | | Avoid an unnecessary "else". Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Remove header==NULL code from db_ctdb_marshall_recordVolker Lendecke2012-11-291-12/+5
| | | | | | The only call chain (via db_ctdb_marshall_add) has header != NULL Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Open gencache_notrans with TDB_NOSYNCVolker Lendecke2012-11-281-1/+4
| | | | | | | | | | | | | | | | | | | We are doing CLEAR_IF_FIRST here, and we are doing the transactions only to protect gencache_stabilize against concurrent writers. tdb's transaction.c says: - if TDB_NOSYNC is passed to flags in tdb_open then transactions are still available, but no fsync/msync calls are made. This means we are still proof against a process dying during transaction commit, but not against machine reboot. For gencache_notrans.tdb this is exactly what we want and avoids some expensive disk syncs. Reviewed by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Nov 28 03:13:56 CET 2012 on sn-devel-104
* s3: Avoid some transaction_commit on gencache.tdbVolker Lendecke2012-11-271-0/+110
| | | | | | | Commits are expensive, and in some scenarios we are overwriting existing values again and again. Reviewed by: Jeremy Allison <jra@samba.org>
* s3: Fix Coverity ID 741407 -- resource leakVolker Lendecke2012-11-261-0/+1
| | | | | | | Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Mon Nov 26 19:20:05 CET 2012 on sn-devel-104
* build: Do not install testing binariesAndrew Bartlett2012-11-222-2/+4
| | | | | | | | | | | | | These binaries are for developer or selftest use, and are not supported for installation onto the system. The autoconf build does not install these binaries, and so neither should the waf build. Andrew Bartlett Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Nov 22 12:00:36 CET 2012 on sn-devel-104
* s3: Fix some blank line endingsVolker Lendecke2012-11-201-10/+10
| | | | | | | Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue Nov 20 19:18:33 CET 2012 on sn-devel-104
generated by cgit (git 2.34.1) at 2025-08-31 06:23:58 +0000