| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| | |
(This used to be commit ffaa608be01d72075942ca3aff2325c6364e0556)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
safe_strcpy() isn't particularly safe (this has been noted before) as it does
not take the size of the buffer, but instead the size of the buffer *minus 1*
The locking.c fix was causing segfaults on machines running with
--enable-developer, and was tracked down thanks to the fact that vance's build
farm machine runs with such an option, and smbtorture's DIR1 test hits this
bug very well.
(The --enable-developer code writes to the last byte of the string, to check
for incorrect use of safe_strcpy()).
Andrew Bartlett
(This used to be commit e908fd164d1b11b6f76a6fdffb22e139813cb3c0)
|
| |
| |
| |
| | |
(This used to be commit 70fce680c01fa1baa65fb3cbc83dfaf822fdadd7)
|
| |
| |
| |
| |
| |
| |
| | |
make x_fwrite() match fwrite() in returning a size_t.
Andrew Bartlett
(This used to be commit 2943c695787b742e9a96b2eefe2d75f681bacf7c)
|
| |
| |
| |
| | |
(This used to be commit 367997562998adb3f80602596c770d9ac319065b)
|
| |
| |
| |
| |
| | |
modules/developer.c: init_module() should return an int
(This used to be commit 7f59703550378ff2333e3c851bf1a77037510abd)
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
(According to the manpages, you cannot put a stack variable into putenv()).
Yes, this leaks memory.
Andrew Bartlett
(This used to be commit 50bced1e26434ecc7474964062746e2831e5f433)
|
| |
| |
| |
| | |
(This used to be commit 8c69212eeb4a0ec144b960d76319fd4940b8c239)
|
| |
| |
| |
| |
| |
| | |
to set this for Tru64.
Jeremy.
(This used to be commit e7c4616c45ea5ec7c04022d6cca49ac70adde121)
|
| |
| |
| |
| | |
(This used to be commit e22465749dc7c2acd2441a897df592616fc275da)
|
| |
| |
| |
| | |
(This used to be commit 82414706e6659c1638936d9b9afdb9329109f58f)
|
| |
| |
| |
| | |
(This used to be commit fa38e7956c21b828ba208282ef0ac85c2b66ff22)
|
| |
| |
| |
| | |
(This used to be commit 90e1d8bdfa9ec0a4f3795d9a89db1d2324447b68)
|
| |
| |
| |
| |
| |
| |
| | |
it really is a developer hack...
Andrew Bartlett
(This used to be commit 3588ebb35b14422141d4070413185195b525038e)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When we look see if a user is in a list, and we try to 'expand' an @group, we
should lookup the user's own list of groups, rather than looking for all the
members of a group.
I'm sure this will fix some nasty performance issues, particularly on large
domains etc. In particular, this avoids contacting winbind at all, if the
group is not a winbind group.
(This caused a deadlock on my winbind-on-PDC setup).
The groups list always includes the user's primary group, as per the
getgrouplist manpage, and my recent changes to our implementation.
Andrew Bartlett
(This used to be commit 9be21976f7662ebe6eb92fff7cecbdb352eca334)
|
| |
| |
| |
| | |
(This used to be commit 4560594a67056ee1a5e51a122d1b254944e7c266)
|
| |
| |
| |
| |
| |
| |
| | |
In particular, make sure we include the primary gid in the list.
Andrew Bartlett
(This used to be commit 0cd4b339b7eff55019caaeaa998d5e70b2eed200)
|
| |
| |
| |
| | |
(This used to be commit 28653989cfe5d705b99a4888c0c3fb79d1f89162)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- return ret == 0 ? True : False;
+ return ret == 0;
and
- return tdb_close(cache) ? False : True;
+ return tdb_close(cache) != -1;
(This used to be commit 026b988b132ec76fdd3821639960658e1d36cd43)
|
| |
| |
| |
| |
| | |
Fix typo.
(This used to be commit 2b5664823e05e328c86051fb607182ad20d786d4)
|
| |
| |
| |
| | |
(This used to be commit 3cf539421fa2a5c276baeedbdbf42ced29d9f1e4)
|
| |
| |
| |
| | |
(This used to be commit 7e56014b2877cde489913310edbfd16c267d9859)
|
| |
| |
| |
| |
| |
| |
| | |
x_ varient of the command.
Andrew Bartlett
(This used to be commit 6a028507f0d5eadd2ec0a5b45c35e3a019a56f0b)
|
| |
| |
| |
| |
| | |
Jeremy.
(This used to be commit babbbd9c651e044832a78aa0fbcee5afd73770e2)
|
| |
| |
| |
| |
| | |
Thanks to Andrew Bartlett for spotting this.
(This used to be commit b4c210ccb05e71a8ddf1c25d028452dd5cd93c72)
|
| |
| |
| |
| | |
(This used to be commit 8f495e8634a1777c4b03d3ec07c76f905ff2fb98)
|
| |
| |
| |
| |
| |
| |
| | |
is as stable as possible in the string department and some pain now
will help later :-).
Jeremy.
(This used to be commit 86e3eddac698d90f4666b8492b4603a4efbbd67b)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Original message:
This patch attemptes to clean up winbindd's mutex locking.
The current locking scheme in winbind is a complete mess - indeed, the
next step should be to push the locking into cli_full_connection(), but
I'll leave it for now.
This patch works on the noted behaviour that 2 parts of the connection
process need protection - and independent protection. Tim Potter did
some work on this a little while back, verifying the second case.
The two cases are:
- between connect() and first session setup
- during the auth2 phase of the netlogon pipe setup.
I've removed the counter on the lock, as I fail to see what it gains us.
This patch also adds 'anonymous fallback' to our winbindd -> DC connection.
If the authenticated connection fails (wbinfo -A specifed) - say that
account isn't trusted by a trusted DC - then we try an anonymous.
Both tpot and mbp like the patch.
Andrew Bartlett
(This used to be commit b5283c00a900393b83f0edb2785c5caf402404eb)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Make ReadDirName return a const char*.
- Consequential changes from that
- mark our fstring/pstring assumptions in function prototypes
Andrew Bartlett
(This used to be commit 10b53d7c6fd77f23433dd2ef12bb14b227147a48)
|
| |
| |
| |
| | |
(This used to be commit 04a5cbc8964386774acdca759b4cfaded068c8f2)
|
| |
| |
| |
| |
| | |
I'm not merging the current HEAD string stuff quite yet.
(This used to be commit 9b8d12e081462566043bb51e9c95605609572a54)
|
| |
| |
| |
| |
| |
| | |
dereferencing
(This used to be commit 7bc5fc729f67ae16e09ea67efa9e2b8e2ba41c8f)
|
| |
| |
| |
| |
| |
| | |
from .NET RC2)
(This used to be commit e074cab810f9299d0b27881cddf8a74f10fe233e)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
-------------------------------------------------------------------------
I think there are basically two problem:
1. Windows clients do not always send ACEs for SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ,
and SMB_ACL_OTHER.
The function ensure_canon_entry_valid() is prepared for that, but tries
to "guess" values from group or other permissions, respectively, otherwise
falling back to minimum r-- for the owner. Even if the owner had full
permissions before setting ACL. This is the problem with W2k clients.
2. Function set_nt_acl() always chowns *before* attempting to set POSIX ACLs.
This is ok in a take-ownership situation, but must fail if the file is
to be given away. This is the problem with XP clients, trying to transfer
ownership of the original file to the temp file.
The problem with NT4 clients (no ACEs are transferred to the temp file, thus
are lost after moving the temp file to the original name) is a client problem.
It simply doesn't attempt to.
I have played around with that using posic_acls.c from 3.0 merged into 2.2.
As a result I can now present two patches, one for each branch. They
basically modify:
1. Interpret missing SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ, or SMB_ACL_OTHER
as "preserve current value" instead of attempting to build one ourself.
The original code is still in, but only as fallback in case current values
can't be retrieved.
2. Rearrange set_nt_acl() such that chown is only done before setting
ACLs if there is either no change of owning user, or change of owning
user is towards the current user. Otherwise chown is done after setting
ACLs.
It now seems to produce reasonable results. (Well, as far as it can. If
NT4 doesn't even try to transfer ACEs, only deliberate use of named default
ACEs and/or "force group" or the crystal ball can help :)
-------------------------------------------------------------------------
Jeremy.
(This used to be commit 1d3b8c528bebfa1971d1affe454a03453335786e)
|
| |
| |
| |
| |
| | |
Jeremy.
(This used to be commit 54e5413a9267b7279cbde0ec129478a5a9c3116c)
|
| |
| |
| |
| |
| |
| |
| |
| | |
* distinguish WinXP from Win2k
* add a 1/3 of a second delay in OpenPrinter
in order to trigger a LAN/WAN optimization in
2k clients.
(This used to be commit c7712fa054d21b4884a78b7ea6c0fb8b3d637c6b)
|
| |
| |
| |
| | |
(This used to be commit 38fa2898967f607a17fd7fbd324f2940a05fb551)
|
| |
| |
| |
| |
| |
| |
| | |
init_valid_table: Fix a memory leak that would lose the
dynamically-created valid table every time the configuration was
reloaded.
(This used to be commit 3ff4845bc43736bfa091419c80b9a0ebdc9d156e)
|
| |
| |
| |
| |
| |
| |
| | |
strdup() instead.
Jeremy.
(This used to be commit 6521601bf8013c8809db13ccf7dd256ea4ad5dd7)
|
| |
| |
| |
| | |
(This used to be commit 3761f8ebe339fbbeffee9d7b69f9483ebfd9ae6b)
|
| |
| |
| |
| |
| | |
Andrew Bartlett
(This used to be commit 9ef0d40c3f8aef52ab321dc065264c42065bc876)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- new kerberos code, allowing the account to change it's own password
without special SD settings required
- NTLMSSP client code, now seperated from cliconnect.c
- NTLMv2 client code
- SMB signing fixes
Andrew Bartlett
(This used to be commit 837680ca517982f2e5944730581a83012d4181ae)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- user_ok() and user_in_group() now take a list of groups, instead of
looking for the user in the members of all groups.
- The 'server_info' returned from the authentication is now kept around
- in future we won't copy the sesion key, username etc, we will just
referece them directly.
- rhosts upgraded to use the SAM if possible, otherwise fake up based on
getpwnam().
- auth_util code to deal with groups upgraded to deal with non-winbind domain
members again.
Andrew Bartlett
(This used to be commit 74b5436c75114170ce7c780c19226103d0df9060)
|
| |
| |
| |
| | |
(This used to be commit 822f6c2f38b9b30dca2358e99ad6a379f5890c89)
|
| |
| |
| |
| | |
(This used to be commit 6cb124247d10de86bdf6a98f3dd703b3a9eb1d35)
|
| |
| |
| |
| | |
(This used to be commit bae354a20c07458722b5193911e7eaaf9bfbaeb7)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- setenv() replacement
- mimir's ASN1/SPNEGO typo fixes
- (size_t)-1 fixes for push_* returns
- function argument signed/unsigned correction
- ASN1 error handling (ensure we don't use initiailsed data)
- extra net ads join error checking
- allow 'set security discriptor' to fail
- escape ldap strings in libads.
- getgrouplist() correctness fixes (include primary gid)
Andrew Bartlett
(This used to be commit e9d6e2ea9a3dc01d3849b925c50702cda6ddf225)
|
| |
| |
| |
| | |
(This used to be commit d510ff85fb0dafddf3dea9412a09eeee6e70f0cb)
|
| |
| |
| |
| |
| |
| | |
to set this for Tru64.
Jeremy.
(This used to be commit a21154961135def29d7ede302ed09ce52fc22fc1)
|
| |
| |
| |
| | |
(This used to be commit fcc7a197b1ec85f9492e335a824317a904b0c919)
|