summaryrefslogtreecommitdiffstats
path: root/source/web
Commit message (Collapse)AuthorAgeFilesLines
* Fix swat. Bug #5613.Jeremy Allison2008-07-151-13/+18
| | | | Jeremy
* Fix empty input fields in SWAT; [#5515].Andreas Schneider2008-06-031-4/+4
| | | | Signed-off-by: Stefan Metzmacher <metze@samba.org>
* Fix saving of the config file in SWAT; [#5516].Andreas Schneider2008-06-031-2/+2
| | | | | | | The strlen of the source string passed to convert_string_allocate was too short :) Signed-off-by: Stefan Metzmacher <metze@samba.org>
* Cleanup size_t return values in callers of convert_string_allocateTim Prouty2008-05-202-7/+10
| | | | | This patch is the second iteration of an inside-out conversion to cleanup functions in charcnv.c returning size_t == -1 to indicate failure.
* swat: freeze swat_proto.h from "make proto"Michael Adam2008-05-181-0/+70
| | | | Michael
* Cleanup size_t return values in convert_string_allocateTim Prouty2008-04-111-4/+4
| | | | | This patch is the first iteration of an inside-out conversion to cleanup functions in charcnv.c returning size_t == -1 to indicate failure.
* Add a talloc context parameter to current_timestring() to fix memleaks.Michael Adam2008-03-281-1/+5
| | | | | | | | | | | | | current_timestring used to return a string talloced to talloc_tos(). When called by DEBUG from a TALLOC_FREE, this produced messages "no talloc stackframe around, leaking memory". For example when used from net conf. This also adds a temporary talloc context to alloc_sub_basic(). For this purpose, the exit strategy is slightly altered: a common exit point is used for success and failure. Michael
* loadparm: add convenience wrapper lp_kill_all_services()Michael Adam2008-03-121-1/+1
| | | | Michael
* Always pass a TALLOC_CTX to str_list_make and str_list_copyVolker Lendecke2008-02-041-2/+2
|
* strtok -> strtok_rVolker Lendecke2008-01-231-1/+3
|
* Remove the char[1024] strings from dynconfig. ReplaceJeremy Allison2007-12-102-12/+12
| | | | | | them with malloc'ing accessor functions. Should save a lot of static space :-). Jeremy.
* Tiny simplificationsVolker Lendecke2007-12-101-1/+1
| | | | | | locking.c:open_read_only was unused don't export the silly boolean flag locking_init(bool read_only)
* We don't need P_GSTRING or P_UGSTRING anymore.Jeremy Allison2007-12-071-15/+0
| | | | Jeremy.
* Remove some globalsVolker Lendecke2007-12-051-5/+12
|
* Make strhex_to_str clear on string limits. Remove pstring from web/*.cJeremy Allison2007-12-034-89/+123
| | | | Jeremy.
* Make remote_password_change return malloced error stringsVolker Lendecke2007-11-231-3/+4
| | | | This fixes a segfault in smbpasswd -r
* Remove pstrings from pam_smbpass - make local_password_changeJeremy Allison2007-11-211-6/+8
| | | | | return malloced strings. Jeremy.
* More pstring removal. This one was tricky. I had to addJeremy Allison2007-11-151-0/+3
| | | | | | one horror (pstring_clean_name()) which will have to remain until I've removed all pstrings from the client code. Jeremy.
* I can't get away without a 'length' arg. :-).Jeremy Allison2007-11-031-1/+1
| | | | Jeremy.
* Stop get_peer_addr() and client_addr() from using globalJeremy Allison2007-11-031-1/+2
| | | | | statics. Part of my library cleanups. Jeremy.
* This is a large patch (sorry). Migrate from struct in_addrJeremy Allison2007-10-241-6/+10
| | | | | | | | | | | | | to struct sockaddr_storage in most places that matter (ie. not the nmbd and NetBIOS lookups). This passes make test on an IPv4 box, but I'll have to do more work/testing on IPv6 enabled boxes. This should now give us a framework for testing and finishing the IPv6 migration. It's at the state where someone with a working IPv6 setup should (theorecically) be able to type : smbclient //ipv6-address/share and have it work. Jeremy.
* Fix the popt / bool issues. Some places we used BOOLJeremy Allison2007-10-191-2/+2
| | | | | | where we meant int. Fix this. Thanks to metze for pointing this out. Jeremy.
* RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison2007-10-184-25/+25
| | | | | | | bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy.
* Add const to the get_peer_addr() and get_socket_addr()Jeremy Allison2007-10-111-2/+2
| | | | | calls. Use the IPv6 varient for get_peer_addr(). Jeremy.
* Add start of IPv6 implementation. Currently most of this is avoidingJeremy Allison2007-10-101-2/+6
| | | | | | | | | | IPv6 in winbindd, but moves most of the socket functions that were wrongly in lib/util.c into lib/util_sock.c and provides generic IPv4/6 independent versions of most things. Still lots of work to do, but now I can see how I'll fix the access check code. Nasty part that remains is the name resolution code which is used to returning arrays of in_addr structs. Jeremy.
* r24781: Fix build warning.Günther Deschner2007-10-101-1/+1
| | | | Guenther
* r24701: Fix the swat buildVolker Lendecke2007-10-102-0/+27
| | | | | | | Swat has not been built by default for a while, so I did not notice that the _ macro is actually used. Re-add the lang_msg_rotate function, this time only to swat so that this is the only binary that has to take the 16k penalty.
* r23784: use the GPLv3 boilerplate as recommended by the FSF and the license textAndrew Tridgell2007-10-106-12/+6
|
* r23779: Change from v2 or later to v3 or later.Jeremy Allison2007-10-106-6/+6
| | | | Jeremy.
* r23554: Fix bug #4711 by makeing cli_connect return an NTSTATUS.Jeremy Allison2007-10-101-1/+3
| | | | | Long overdue fix.... Jeremy.
* r23171: Convert connections.tdb to dbwrapVolker Lendecke2007-10-101-12/+11
|
* r22761: This introduces lib/conn_tdb.c with two main functions: ↵Volker Lendecke2007-10-101-52/+31
| | | | | | | | | connections_traverse and connections_forall. This centralizes all the routines that did individual tdb_open("connections.tdb") and direct tdb_traverse. Volker
* r22736: Start to merge the low-hanging fruit from the now 7000-line cluster ↵Volker Lendecke2007-10-102-5/+5
| | | | | | | | | patch. This changes "struct process_id" to "struct server_id", keeping both is just too much hassle. No functional change (I hope ;-)) Volker
* r22282: Fix last few name -> servicename changes.Jeremy Allison2007-10-101-1/+1
| | | | Jeremy.
* r21784: Replace smb_register_idle_event() with event_add_timed(). This fixes ↵Volker Lendecke2007-10-101-1/+1
| | | | | | | | winbind who did not run the idle events to drop ldap connections. Volker
* r21714: Change the VFS interface to use struct timespecJeremy Allison2007-10-101-1/+1
| | | | | | | | | | for utimes - change the call to ntimes. This preserves nsec timestamps we get from stat (if the system supports it) and only maps back down to usec or sec resolution on time set. Looks bigger than it is as I had to move lots of internal code from using time_t and struct utimebuf to struct timespec. Jeremy.
* r17873: Fix possible null deref found by Stanford checker.Jeremy Allison2007-10-101-2/+3
| | | | Jeremy.
* r17177: Get rid of a global variable by adding a private data pointer toVolker Lendecke2007-10-101-2/+5
| | | | | | share_mode_forall(). Volker
* r16945: Sync trunk -> 3.0 for 3.0.24 code. Still needJeremy Allison2007-10-103-8/+8
| | | | | | | to do the upper layer directories but this is what everyone is waiting for.... Jeremy.
* r16597: Klocwork #2006. Fix possible null deref.Jeremy Allison2007-10-101-0/+4
| | | | Jeremy.
* r16435: Add in the uid info that Jerry needs into theJeremy Allison2007-10-101-0/+1
| | | | | | | share_mode struct. Allows us to know the unix uid of the opener of the file/directory. Needed for info level queries on open files. Jeremy.
* r16426: Klocwork #1544, #1545, #1546, #1549, #1550, #1552, #1553, #1554Jeremy Allison2007-10-102-20/+35
| | | | Jeremy.
* r16230: Fix Klocwork #861 and others. localtime and asctimeJeremy Allison2007-10-101-1/+1
| | | | | can return NULL. Ensure we check all returns correctly. Jeremy.
* r15465: Fix segfault in SWAT.Deryck Hodge2007-10-101-0/+2
| | | | | | Fixes bug #3702. deryck
* r14618: add --no-process-group to all server programmsStefan Metzmacher2007-10-101-3/+3
| | | | | | | | | | | to make the following possible: timelimit 20000 bin/nmbd -F -S --no-process-group timelimit 20000 bin/smbd -F -S --no-process-group this is needed to 'make test' working without losing child processes metze
* r14255: Revert r14204 which was horribly broken.James Peach2007-10-101-0/+15
|
* r14204: Remove the basically unused P_GSTRING and P_UGSTRINGJames Peach2007-10-101-15/+0
| | | | parameter types.
* r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison2007-10-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy.
* r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()Gerald Carter2007-10-101-3/+3
| | | | macro which sets the freed pointer to NULL.
* r13383: pulling in swat-welcome patch from SuSE packagingGerald Carter2007-10-101-1/+5
|
generated by cgit (git 2.34.1) at 2025-08-30 06:37:39 +0000