| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Jeremy.
|
|
|
|
| |
to do so may result in lost data. Fix an ifdef check, I really think we meant to check HAVE_MMAP here.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit dd781951fb9acc556f1bd6760b72151a7c359a9f.
This fix is not valid:
1. convert_string() is not only used for key strings but also for data.
2. Some databases use string_tdb_data() i.e. non-null-terminated strings
as keynames and others (like the one I was using), use
string_term_tdb_data(), i.e. zero-terminated key strings.
After discussion with Metze, the easiest (and proper way) to
handle this is to specify key names as "keyname\0" for databases
which use string_term_tdb_data().
Sorry for the noise...
Michael
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevented all commands operating on keys (all non-traverse commands)
in tdbtool to fail with a "fetch failed" or "delete failed" message.
It seems that it fixes bug #2344 ...
Apparently this bug was introduced with 94e53472666ed in 2005.
Either nobody is using tdbtool or else tdb_find() has become
more strict about the key legth in the meantime. :-)
Michael
|
|
|
|
| |
Guenther
|
| |
|
|
|
|
|
|
|
|
| |
an alarm sig would not terminate and could lead
to runaway smbd processes.
Thanks to Dave Daugherty @ Centrify for pointing
this out to us.
Jeremy.
|
| |
|
|
|
|
| |
metze
|
|
|
|
|
| |
Found by Taj Khattra <taj.khattra@gmail.com>.
Jeremy.
|
|
|
|
|
|
| |
remove broken samba3 specific stuff from tdbtool
metze
|
|
|
|
| |
metze
|
|
|
|
| |
metze
|
|
|
|
| |
metze
|
|
|
|
|
|
| |
and fix all compiler warnings in the users
metze
|
|
|
|
|
|
|
|
|
|
|
| |
samba-technical@samba.org. If
you do a tdb_set_max_dead(tdb, n), then for this tdb a delete operation will
only mark a record as dead and re-use it if a new record is created. The
parameter n allows for at most n dead records per hash chain. If this number
is exceeded, all dead records are put on the central freelist.
Volker
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
need to
agree on the behaviour of non-existing records.
Tridge, can you comment? Should we change tdb_fetch, or should we have
different concepts in tdb_fetch() and tdb_parse_record() ?
Volker
|
|
|
|
|
|
|
|
|
| |
Not as bad
as not doing it at all, but needs fixing. Also simplify the logic, I had
missed the "goto out" at the end of the function.
Volker
|
|
|
|
|
|
|
|
| |
succeeded. Found while testing the brlock seqnum patch.
Tridge, please check!
Volker
|
|
|
|
|
|
|
|
|
|
|
| |
in-memory
mirrors of the hash chain locks to a dynamically allocated one.
Jeremy, I count on you to revert it if the build farm freaks out, it's after
midnight here :-)
Volker
|
| |
|
| |
|
| |
|
|
|
|
| |
more no previous prototype warnings
|
| |
|
|
|
|
| |
separately specifying CPPFLAGS and LDFLAGS.
|
|
|
|
|
|
| |
Add code to check for loops in the free list.
Should help us validate tdb's against corruption.
Jeremy.
|
|
|
|
|
| |
Rename to log_ctx.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
command now
prints the hash on every record for easier awk'ing, and tdbbackup allows a
different hash chain length on the backed up tdb.
Jeremy, Günther, this might be interesting for you huge domains. Not only
locking.tdb, also the winbind ones might grow huge.
In the installation I fixed with this winbind spent a huge amount of CPU
spinning through a degenerated winbindd_idmap.tdb with entries for more than
15.000 users. With a default number of hash chains of 131 on that tdb you can
imagine that the lists get large.
Not merging to 4, I don't get tdbbackup to compile there right now.
What about changing the global default hash chain number to be dramatically
larger? Disk is cheap these days.
Volker
|
|
|
|
| |
see discussion on samba-technical
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tdb. This includes:
- the new tdb_lockall and tdb_lockall_read code, which will be needed
for the ldb speedups
- the tdb logging changes. This is an intermediate step to keep the
differences between the two branches small. The plan is still to
move to a tdb_init()/tdb_set_logging_function()/tdb_attach() style
of open which will make things much cleaner.
- the updated test suites and standalone tdb build code
- use libreplace headers
There are still some small differences I haven't merged. I'll discuss
those on the list.
|
|
|
|
|
|
|
|
|
| |
descriptor
buffers.
Make security access masks simply a uint32 rather than a structure
with a uint32 in it.
|
|
|
|
| |
metze
|
|
|
|
|
|
|
| |
and DLIST_DEMOTE() now take the type of the tmp pointer
not the tmp pointer itself anymore.
metze
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
definitions which
are not compatible. I am aware that this would be a huge change in Samba4, but
I would like to see it in the code that is shared.
Stefan, when you do merge work, can you get this across to Samba4?
Thanks,
Volker
|
|
|
|
|
|
| |
Let's see what it breaks. For me it works :-)
Volker
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Linux,
F_RDLCK is defined to 0, for example NetBSD has it at 1.
Still does not work fully though. Still investigating.
This might also be interesting to Samba4.
Volker
|
|
|
|
|
|
|
|
| |
keys,
this can trivially be added later.
Volker
|
|
|
|
|
|
|
|
| |
in talloc
and tdb "upstream"?
Volker
|
|
|
|
|
| |
(tdbtool still fails).
Jeremy.
|
|
|
|
|
|
|
| |
to do the upper layer directories but this is what
everyone is waiting for....
Jeremy.
|
|
|
|
| |
the fastest clock available on uniprocessors.
|
| |
|
|
|
|
| |
Volker
|
|
|
|
|
|
|
|
|
| |
does not
have the timeout argument in Samba4. Add a new routine
tdb_lock_bystring_with_timeout.
Volker
|
|
|
|
|
|
|
|
|
| |
has the linear posix locking issue which causes
CLEAR_IF_FIRST to cause performance problems.
As we know we're in a daemon architecture with
long-lived parent we can avoid this in the Samba
case. Add a comment explaining this.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|