summaryrefslogtreecommitdiffstats
path: root/source/smbd
Commit message (Collapse)AuthorAgeFilesLines
...
* smb.h: Removed fdnum from file_fd_struct. Not needed.Jeremy Allison1998-09-101-29/+109
| | | | | | | files.c: Removed fd bitmap - not needed. Added code to do use arrays rather than linked list - disabled by default but can be enabled to check performance. Jeremy.
* Improved stat cache code by uppercasing any search name that gets added toJeremy Allison1998-09-102-19/+17
| | | | | | | it if we're in case insensitive mode, and then doing a memcmp rather than a StrnCaseCmp (which is *horribly* slow) on every lookup. Fixed bug with refusing NT SMB's (use *brackets* where needed :-). Jeremy.
* Copyright notices written to debug logs are now through 1998.Christopher R. Hertel1998-09-091-1/+1
| | | | Chris -)-----
* Added back groupname map stuff removed by Andrew's "slash 'n' burn"Jeremy Allison1998-09-085-32/+49
| | | | | | | | | | | | | | | | | tactics :-). Protected by #ifdef until used. Fixed bug in fd_attempt_close() where a pointer to potentially free'd memory was returned. I hate that. Added "blocking locks" as a per-share option for performance testing. Changed is_mangled() so it will return true if called with a pathname and any component of the pathname was mangled (it was already attempting to do this, but not checking for a '/' as end-of-mangle). This should be a better fix for the wierd stat cache bug Andrew identified. Jeremy.
* added 0x10 to the frag length in the "bind ack".Luke Leighton1998-09-071-1/+1
|
* add a "stat cache" boolean smb.conf option. (defaults to on)Andrew Tridgell1998-09-061-2/+10
| | | | | | | | I think we need this so we can rule out stat cache bugs when dealing with bug reports. If we ask a user to disable the stat cache and the problem persists then we know it isn't a stat cache bug. The stat cache code is sufficiently complicated that it can be pretty hard to tell if it is causing problems or not.
* fixed a stat cache bug (the one found by Matthew Geier).Andrew Tridgell1998-09-051-1/+5
| | | | | | The fix I used is a very conservative fix. I'll leave it up to Jeremy to put in a better fix. The problem was the detection of mangled names.
* some cleanups to use ZERO_STRUCT() and friendsAndrew Tridgell1998-09-054-9/+11
|
* ahh, the joy of deleting large chunks of code that someone else hasAndrew Tridgell1998-09-051-4/+0
| | | | | | | | painstakingly put in :) This gets rid of most of the #ifdef LARGE_SMB_INO_T ifdefs around DEBUG() statements. We just use %.0f in all cases. Makes the code a bit easier to read :)
* tridge the destroyer returns!Andrew Tridgell1998-09-0511-266/+247
| | | | | | | | | | | | | | | | | | | | | | prompted by the interpret_security() dead code that Jean-Francois pointed out I added a make target "finddead" that finds potentially dead (ie. unused) code. It spat out 304 function names ... I went through these are deleted many of them, making others static (finddead also reports functions that are used only in the local file). in doing this I have almost certainly deleted some useful code. I may have even prevented compilation with some compile options. I apologise. I decided it was better to get rid of this code now and add back the one or two functions that are needed than to keep all this baggage. So, if I have done a bit too much "destroying" then let me know. Keep the swearing to a minimum :) One bit I didn't do is the ubibt code. Chris, can you look at that? Heaps of unused functions there. Can they be made static?
* Fixed one more Debug problem with inode in non-64 bit case.Jeremy Allison1998-09-051-1/+1
| | | | Jeremy.
* Bugfix for leak in reference counted file struct.Jeremy Allison1998-09-054-15/+13
| | | | | Added "nt smb support" parameter to allow NT SMB's to be turned off. Jeremy.
* Modified dev_t and ino_t code to be 64 bit clean (including changesJeremy Allison1998-09-044-32/+170
| | | | | | | | | | to oplock break message passing). I think that smbd/nmbd are now inode and offset size independent (at least for 32 bit and 64 bit systems). Now to expose all this new functionality to NT clients..... Jeremy.
* More 64 bit stuff - now the fcntl locks are 64 bit clean.Jeremy Allison1998-09-042-9/+13
| | | | | | Nearly at the stage where I can expose the 64-bit-ness to the NT clients.... Jeremy.
* Ok - this is the 64 bit widening check in. It changes the configureJeremy Allison1998-09-0310-162/+172
| | | | | | | | | | | | | | | | | | | | | | | | | to check for stat64 and friends, and then changes much of Samba to use the data type SMB_OFF_T for file size information. stat/fstat/lstat/lseek/ftruncate have now become sys_stat etc. to hide the 64 bit calls if needed. Note that this still does not expose 64 bit functionality to the client, as the changes to the reply_xxx smb's are not yet done. This code change should make these changes possible. Still to do before full 64 bit-ness to the client: fcntl lock code. statfs code widening of dev_t and ino_t (now possible due to SMB_DEV_T and SMB_OFF_T types being in place). Let me know if wierd things happen after this check-in and I'll fix them :-). Jeremy.
* changed the SMBtrans reply code to align at the same alignment asAndrew Tridgell1998-09-031-13/+8
| | | | | | | | | observed from NT. We were aligning the data before but not the parameters. This aligns both. This change may break some other parts of ipc.c if we have relied on the alignment somewhere, so if you think this broke something then let me know.
* fixed a bug in the name mangling code. It implicitly assumed thatAndrew Tridgell1998-09-032-40/+40
| | | | | | | | mangling a name can't increase it's size which isn't true. (imagine a file called "L B" which mangles to "LB~XX") The symptoms were that users couldn't run batch files from short directory names that contained non 8.3 characters (such as spaces).
* Fix for PR#9497 - not waiting for child.Jeremy Allison1998-09-021-2/+4
| | | | Jeremy.
* we are never interested in SIGPIPE so just ignore (block) itAndrew Tridgell1998-09-021-23/+3
| | | | always. Don't even install a handler.
* More abstraction of file system data types, to move to a 64Jeremy Allison1998-09-0113-99/+99
| | | | | | | | | | | | | | | | | | | | | bit file interface for the NT SMB's. Created a new define, SMB_STRUCT_STAT that currently is defined to be struct stat - this wil change to a user defined type containing 64 bit info when the correct wrappers are written for 64 bit stat(), fstat() and lstat() calls. Also changed all sys_xxxx() calls that were previously just wrappers to the same call prefixed by a dos_to_unix() call into dos_xxxx() calls. This makes it explicit when a pathname translation is being done, and when it is not. Now, all sys_xxx() calls are meant to be wrappers to mask OS differences, and not silently converting filenames on the fly. Jeremy.
* check that a valid pipe is passed before doing a pipe close.Andrew Tridgell1998-09-011-0/+4
| | | | | | | | | | | I made this change after getting a segv in reply_pipe_close(). The funny thing was that pipes_open was 1 and Pipes was NULL. That "can't happen" and suggests that we have a wild pointer somewhere. I suspect the rpc code, as I was playing with long share names (a share called "averylongusername") at the time and the logs show lots of srvsvc operations. I bet there is a buffer in the rpc code somewhere that is overflowing and trashing bits of the data segment.
* configure.in, configure: include/config.h.in: Added stropts and poll.Jeremy Allison1998-08-316-29/+42
| | | | | | | | | | | include/smb.h: Moved old typedefs of uint8 etc. into include/includes.h where all the other defines live (changed them from typedefs to defines). Other changes : changed from using uint32 to SMB_DEV_T and SMB_INO_T in preparation for moving to size independed (ie. 64 bit clean) device and inode access. Stat call wrapper comes next :-). Jeremy.
* bounds check next_token() to prevent possible buffer overflowsAndrew Tridgell1998-08-314-19/+19
|
* This checking fixes the statcache bug that stopped NetBench from runningJeremy Allison1998-08-282-7/+15
| | | | | | | | | | | | | | correctly. Added new parameter "stat cache size" - set to 50 by default. I now declare the statcache code officially "open" for business :-). It gets a hit rate of 97% with a NetBench run and seems to make using a case insensitive run as efficient as a case sensitive run. Also tidied up our sys_select usage - added a maxfd parameter and also added an implementation of select in terms of poll(), for systems where poll() is much faster. This is disabled by default. Jeremy.
* Fixed stat cache statistics calculation. Oops.Jeremy Allison1998-08-271-1/+1
| | | | Jeremy.
* This is the stat cache code - seems to work fine (needs heavyJeremy Allison1998-08-277-50/+312
| | | | | | NetBench testing though.... :-). Attempts to efficiently reduce the number of stat() calls Samba does. Jeremy.
* changed the default permissions code to do this:Andrew Tridgell1998-08-251-12/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | if ((sbuf->st_mode & S_IWUSR) == 0) result |= aRONLY; rather than the very complex user/group permissions checks we do currently. This is equivalent ot setting "alternate permissions = yes" in the old code. The change is motivated by three main reasons: 1) it's basically impossible to second guess whether a file is writeable without trying to open it for writing. ACLs, root squash etc just make it too hard. 2) setting it not RONLY if the owner can write is closer to what NT does (eg. look at a cdrom - files are not marked read only). 3) it prevents the silly problem of copying files from a read only share to a writeable share and then finding you can't write to them as windows preserves the RONLY flag. Lots of people get bitten by this when they drag a folder from a Samba drive. It also hurts some install programs. I have also added a new flag type for loadparm.c called FLAG_DEPRECATED which I've set for "alternate permissions". I'll soon add code to testparm to give a warning about deprecated options.
* Added code to (correctly) ignore TRANSACT2_SETFILEINFO with ↵Jeremy Allison1998-08-252-2/+4
| | | | | | | SMB_SET_FILE_ALLOCATION_INFO. Office 97 expects this call to succeed when you tell it you do NT SMB calls. Jeremy.
* Changed ASSERT macros to SMB_ASSERT macros as some systems alreadyJeremy Allison1998-08-242-3/+3
| | | | | have an ASSERT macro defined. Jeremy.
* added ASSERT() and ASSERT_ARRAY() macros and sprinkled them liberallyAndrew Tridgell1998-08-221-7/+1
| | | | in the rpc code.
* nmbd and smbd had different behavior with respect to log files. nmbd wouldChristopher R. Hertel1998-08-211-7/+11
| | | | | | | | | | | | | | | default to overwrite and smbd would default to append. Also, the -a option (actually a toggle, such that "-a -a" would set the default) was documented as append mode for nmbd, and *overwrite mode* for smbd. nmbd now defaults to append mode, to match smbd. The -a option now always means append, and I've added the -o option to both, meaning overwrite. Note that the change to nmbd's default behavior may confuse some people. I've not seen anything about 2.0.0 changes in the WHATSNEW.txt file. Where would I document a change like this? Chris -)-----
* don't attempt to answer QFILEINFO/SMB_QUERY_FILE_STREAM_INFO queries -Andrew Tridgell1998-08-211-0/+4
| | | | | | if we do then NTws gets a BSOD. I checked and NT server refuses these queries too :)
* added new smb.conf option "panic action". see my samba-technicalAndrew Tridgell1998-08-211-3/+1
| | | | explanation.
* fixed a bug in trans2_qfilepathinfo() where we used the length of theAndrew Tridgell1998-08-211-0/+4
| | | | basename of a file but the whole file name. silly error.
* Fixes for the problem in blocking locks with file_fsp returning theJeremy Allison1998-08-213-32/+51
| | | | | | chain_fsp on close (if you don't know what this means, consider yourself lucky - this one took a day to track down :-). Jeremy.
* Turning on blocking locking code. NB. Blocking lock requests that are notJeremy Allison1998-08-206-86/+316
| | | | | | | | | | | | | | | | | | the head of an SMB request (ie. are part of a chain) will not be queued - this will be fixed when we move to the new chain code. In practice, this doesn't seem to cause much of a problem (in my admittedly limited testing) bug a debug level zero message will be placed in the log when this happens to help determine how real the problem is. smbd/locking.c: New debug messages. smbd/blocking.c: New blocking code - handles SMBlock, SMBlockread and SMBlockingX smbd/chgpasswd.c: Fix for master fd leak. smbd/files.c: Tidyup comment. smbd/nttrans.c: Added fnum to debug message. smbd/process.c: Made chain_reply() use construct_reply_common(). Added blocking lock queue processing into idle loop. smbd/reply.c: Added queue pushes for SMBlock, SMBlockread and SMBlockingX. Jeremy.
* Blocking lock code split out...Jeremy Allison1998-08-191-0/+375
| | | | Jeremy.
* Makefile.in: Moved blocking lock code into smbd/blocking.c for link purposes.Jeremy Allison1998-08-194-117/+176
| | | | | | | | | | | include/includes.h: Added nterr.h. locking/locking.c: Moved blocking lock code into smbd/blocking.c for link purposes. smbd/close.c: Added blocking lock removal to file close. smbd/filename.c: Tidied up unix_convert() so I could read it (:-) in preparation for the stat_cache code. smbd/nttrans.c: Added WRITE_ATTRIBUTES check. smbd/reply.c: Fixed multibyte char problem in wildcard mask. Jeremy.
* smbd/nttrans.c: Fixed bug in split off pipe code.Jeremy Allison1998-08-171-0/+4
| | | | | locking/locking.c: More blocking lock changes. Jeremy.
* Fixed bug introduced by the recent changes where the chain_fnumJeremy Allison1998-08-173-171/+193
| | | | | could be overwritten in oplock processing code. Jeremy.
* removed some of the rough edges from the splitupAndrew Tridgell1998-08-172-435/+456
|
* move soem variables from server.c that don't belong there.Andrew Tridgell1998-08-174-51/+30
|
* this completes the splitup of server.c.Andrew Tridgell1998-08-178-3322/+3523
| | | | | | | | the splitup was done with an axe, not a scalpel, so there are some rough edges. I mostly wanted to get the general form right with fine tuning of what goes where to come later. Still, this is better than what we had before where server.c was a general repository for anything that didn't fit elsewhere.
* more splitting of server.cAndrew Tridgell1998-08-174-557/+610
| | | | created dosmode.c and filename.c
* now that we have no global arrays we can start to split up the monsterAndrew Tridgell1998-08-173-485/+532
| | | | | | | server.c without breaking things. this splits off netprot.c and fileio.c for negprot and read/write/seek handling respectively.
* added some optimisation for the case where the number of open files isAndrew Tridgell1998-08-172-50/+24
| | | | | | | | | very large. files.c now promotes a files_struct to the top of the list if it is used when it is more than 10 elements from the top. also moved common linked list code for the 5 sets of linked lists that I've created over the past few days into dlinklist.h (I've explained to Chris why I didn't use the ubiqx code)
* moved connection_struct handling code into smbd/conn.c and changed itAndrew Tridgell1998-08-174-128/+227
| | | | to a linked list with bitmap format.
* much cleaner chain pointer handling for both files and pipes.Andrew Tridgell1998-08-176-60/+67
| | | | | | the chain pointer is now stored as a static and is set whenever a handle is created or extracted. This also makes the code less error prone.
* some cleanups from the conversion of Pipes[] to a linked list. I alsoAndrew Tridgell1998-08-175-134/+114
| | | | | | | | removed most cases where a pnum is used and substituted a pipes_struct*. in files.c I added a offset of 0x1000 to all file handles on the wire. This makes it much less likely that bad parsing will give us the wrong field.
* - some tidying up in files.cAndrew Tridgell1998-08-163-11/+10
| | | | | | | | - handle null fsp in DEBUG() at end of reply_ntcreate_and_X(). Jeremy, can you fix this properly? - get snum right in print queue code in ipc.c (it was broken by my connections_struct changes).