summaryrefslogtreecommitdiffstats
path: root/source/smbd
Commit message (Collapse)AuthorAgeFilesLines
...
* fix WinXP & Win2K3 remote_arch and check pointer in ntlmssp code before ↵Gerald Carter2003-03-141-17/+18
| | | | dereferencing
* Ensure we count the length correctly in mangle_map.Jeremy Allison2003-03-121-6/+15
| | | | Jeremy.
* adding some initiaial code to sert %a to Win2K3 (using Native LanMan string ↵Gerald Carter2003-03-121-0/+2
| | | | from .NET RC2)
* We use unsigned now, so use %u.Jeremy Allison2003-03-111-1/+1
| | | | Jeremy.
* Fix up zero termination. Spotted by Sebastian Krahmer <krahmer@suse.de>.Jeremy Allison2003-03-111-1/+2
| | | | Jeremy.
* Don't segfault on make_server_info_guest() failure - instead return theAndrew Bartlett2003-03-101-4/+2
| | | | | | | | | error code. make_server_info_guest() requires an entry in the SAM at the moment, but this will change before release. Andrew Bartlett
* Make sure that the 'remote' machine name can only be set once. For some weirdAndrew Bartlett2003-03-082-4/+4
| | | | | | | | | | | | reason, during a Win2003 installation, when you select 'domain join' it sends one machine name in the name exchange, and litraly 'machinename' during the NTLMSSP login. Also fix up winbindd's logfile handling, so that it matches smbd and nmbd. (This helps me, by seperating the logs by pid). Andrew Bartlett
* Fix typo in earlier fix, caught by Ranjit @ HP.Jeremy Allison2003-03-081-1/+1
| | | | Jeremy.
* Use ERROR_NT, not ERROR_DOS as Andrew Bartlett pointed out.Jeremy Allison2003-03-073-3/+3
| | | | Jeremy.
* Missed parentheses around complex logic.Jeremy Allison2003-03-071-1/+2
| | | | Jeremy.
* Patch from Michael Steffens. In his own words :Jeremy Allison2003-03-071-78/+199
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ------------------------------------------------------------------------- I think there are basically two problem: 1. Windows clients do not always send ACEs for SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ, and SMB_ACL_OTHER. The function ensure_canon_entry_valid() is prepared for that, but tries to "guess" values from group or other permissions, respectively, otherwise falling back to minimum r-- for the owner. Even if the owner had full permissions before setting ACL. This is the problem with W2k clients. 2. Function set_nt_acl() always chowns *before* attempting to set POSIX ACLs. This is ok in a take-ownership situation, but must fail if the file is to be given away. This is the problem with XP clients, trying to transfer ownership of the original file to the temp file. The problem with NT4 clients (no ACEs are transferred to the temp file, thus are lost after moving the temp file to the original name) is a client problem. It simply doesn't attempt to. I have played around with that using posic_acls.c from 3.0 merged into 2.2. As a result I can now present two patches, one for each branch. They basically modify: 1. Interpret missing SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ, or SMB_ACL_OTHER as "preserve current value" instead of attempting to build one ourself. The original code is still in, but only as fallback in case current values can't be retrieved. 2. Rearrange set_nt_acl() such that chown is only done before setting ACLs if there is either no change of owning user, or change of owning user is towards the current user. Otherwise chown is done after setting ACLs. It now seems to produce reasonable results. (Well, as far as it can. If NT4 doesn't even try to transfer ACEs, only deliberate use of named default ACEs and/or "force group" or the crystal ball can help :) ------------------------------------------------------------------------- Jeremy.
* Fix noticed by Corny.Bondad@hp.com. Ensure we free up memory on error exit.Jeremy Allison2003-03-071-0/+3
| | | | Jeremy.
* Found at Connectathon, .NET RC1 arranges trans/trans2/nttrans parametersJeremy Allison2003-03-073-69/+227
| | | | | differently to W2K, cope with this. Jeremy.
* more off-by-one safe_strcpy()Andrew Bartlett2003-03-061-3/+3
|
* Another pstrcpy() into malloc()ed buffer fix.Andrew Bartlett2003-03-031-2/+2
| | | | Andrew Bartlett
* Const warning fixes.Jeremy Allison2003-03-031-2/+2
| | | | Jeremy.
* i forgot to commit the privilege db init callAndrew Tridgell2003-03-011-0/+4
|
* don't forget the NULLGerald Carter2003-02-271-3/+3
|
* and the winner of "i should have just written it in assemblyGerald Carter2003-02-271-3/+3
| | | | | | is..." don't use pstrcpy() when you are not dealing with pstrings.
* don't pass NULL pointers to strcmp()Gerald Carter2003-02-271-2/+2
|
* additional fix for CR 601Gerald Carter2003-02-271-1/+16
| | | | | | | * distinguish WinXP from Win2k * add a 1/3 of a second delay in OpenPrinter in order to trigger a LAN/WAN optimization in 2k clients.
* - Rename 'modules = ' to 'preload modules = 'Jelmer Vernooij2003-02-271-2/+1
| | | | | | - Add smb_probe_module() - Add init_modules() - Call these functions
* Fix to allow blocking lock notification to be done rapidly (no waitJeremy Allison2003-02-273-10/+82
| | | | | | for smb -> smb lock release). Adds new PENDING_LOCK type to lockdb (does not interfere with existing locks). Jeremy.
* Progress on CR 601Gerald Carter2003-02-251-3/+3
| | | | | | | | | cache the printer_info_2 with the open printer handle. cache is invalidated on a mod_a_printer() call **on that smbd**. Yes, this means that the window for admins to step on each other from different clients just got larger, but since handles a generally short lived this is probably ok.
* Patch from Luke Howard to add mutual kerberos authentication, and SMB sessionAndrew Bartlett2003-02-241-13/+39
| | | | | | keys for kerberos authentication. Andrew Bartlett
* More signed/unsigned fixes (yes, I run with funny compiler options) andAndrew Bartlett2003-02-222-5/+5
| | | | | | make x_fwrite() match fwrite() in returning a size_t. Andrew Bartlett
* Added comments to make it clearer when we're assigning a pointer that itJeremy Allison2003-02-211-0/+12
| | | | | must not be freed afterwards. Jeremy.
* Fixed compiler warning.Tim Potter2003-02-211-1/+0
|
* Like for NTLM logins, lookup the 'winbind' user first, then the 'local' user.Andrew Bartlett2003-02-201-18/+14
| | | | | | This needs to change, to be a SID->UID lookup from the PAC. Andrew Bartlett
* Fix inspired by Stefan (metze) Metzmacher - cache the sidtype also.Jeremy Allison2003-02-191-19/+27
| | | | Jeremy.
* Fix logfile formatting, we were missing a "\n"Andrew Bartlett2003-02-191-2/+2
|
* Fix from Corny.Bondad@hp.com for missing if (setting_acls) on defaultJeremy Allison2003-02-191-3/+3
| | | | | perms. Jeremy.
* This patch fixes one of my longest-standing pet hates with Samba :-).Andrew Bartlett2003-02-174-21/+21
| | | | | | | | | | | | | | | | | When we look see if a user is in a list, and we try to 'expand' an @group, we should lookup the user's own list of groups, rather than looking for all the members of a group. I'm sure this will fix some nasty performance issues, particularly on large domains etc. In particular, this avoids contacting winbind at all, if the group is not a winbind group. (This caused a deadlock on my winbind-on-PDC setup). The groups list always includes the user's primary group, as per the getgrouplist manpage, and my recent changes to our implementation. Andrew Bartlett
* Added code based on Michael Steffens <michael.steffens@hp.com> uid/gidJeremy Allison2003-02-121-1/+205
| | | | | | caching code. Reduces load on winbindd. Probably should be moved to use gencache at some future date. Jeremy.
* Correctly return access denied on share mode deny when we can't open theJeremy Allison2003-02-121-3/+19
| | | | | file. This is a regression that was damaged by other code. Jeremy.
* add a note about relative opens with blank paths - its a re-open!Andrew Tridgell2003-02-121-0/+10
| | | | (not implemented yet)
* Fix delete on close semantics to match W2K. I (think:-) I understand it now :-).Jeremy Allison2003-02-112-45/+46
| | | | | | Thanks to Nir Livni <nirl@cyber-ark.com> for giving me the test case to track it down. Jeremy.
* Some cleanups:Andrew Bartlett2003-02-104-29/+45
| | | | | | | | | | | | | | | - Don't use pstrcpy into an allocated string - use safe_strcpy() directly instead. - Keep a copy of the 'server_info' attached to the vuid. In future use this for things like the session key, homedir and full name instead of current copies. - Try to avoid memory leak/segfault on Realloc failure - clear up #endif comments Andrew Bartlett
* check pointer before dereferencing itGerald Carter2003-02-071-1/+1
|
* make sure we don't run over the end of 'name' in unix_convert()Andrew Tridgell2003-02-071-7/+15
| | | | Thanks to Andrew Bartlett for spotting this.
* Check for too many processes *before* the fork.Jeremy Allison2003-02-051-2/+36
| | | | Jeremy.
* Patch from Edmund Lam <epl@unimelb.edu.au> to fix braindead Tru64 behaviour:Andrew Bartlett2003-02-041-2/+2
| | | | | | Apparently acl_type is #defined to acl_common.entry_type in their acl.h.... Andrew Bartlett
* Ensure we only ever set fsp->conn in one place.Jeremy Allison2003-02-041-7/+0
| | | | Jeremy.
* Ensure Samba passes the open attribute truncate tests in smbtorture.Jeremy Allison2003-02-041-9/+12
| | | | Jeremy.
* untest fix for wide links parameter bug.Simo Sorce2003-02-021-2/+65
| | | | it work properly on 2.2 and the patch apply so I think it should be ok.
* Non-error connection numbers are always positiveAndrew Bartlett2003-02-011-2/+2
|
* Add 3 second timeout when terminating server and sending print notifyJeremy Allison2003-01-302-2/+2
| | | | | | messages. Stops build-up of large numbers of smbd's waiting to terminate on large print throughput. Jeremy.
* Fix for interesting resource constraint condition. When all opens areJeremy Allison2003-01-302-16/+19
| | | | | | | | | | level 2 and a request for open with no oplock is received then the smbd should send *synchronous* break messages, not asynchronous, otherwise it spins very rapidly, releasing the lock, sending the 'break to none' messages and then re-acquiring the lock before any other process has a chance to get the lock and remove it's own oplock (at least on linux). Jeremy.
* As per a comment by herb a little while back, this should be >=, not == to keepAndrew Bartlett2003-01-281-1/+1
| | | | identical behaviour with previous versions
* The previous patch (NTLMSSP common code factoring) was missing a minor detail -Andrew Bartlett2003-01-281-28/+35
| | | | | | | | | testing :-). This gets the 'signiture' after the extended security blob, rather than over the top of it. Also move that code to the top of the file, with some of the other util functions. Andrew Bartlett