| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
3.2.0pre1
|
| |
|
|
|
|
| |
This removes file_id_string_static and file_id_string_static2
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Simplify calling convention of timeout_processing. lp_deadtime is only
referenced in conn_idle_all().
Move sending keepalives out of the main processing loop into idle event.
On the way, make lp_keepalive() a proper parameter.
Move sending auth_server keepalives out of the main loop into an idle event.
Move deadtime processing into an idle event. While there, simplify
conn_idle_all() a bit.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move process_blocking_lock_queue to a timed event.
The idea is that we have blocking.c:brl_timeout as a timed
event that is present whenever we do have a blocking lock
pending. It fires brl_timeout_fn() which calls
process_blocking_lock_queue().
Whenever we make changes to blocking_lock_queue, we trigger
a recalc_brl_timeout() which sets a new brl_timout event if
necessary. This makes the call to
blocking_locks_timeout_ms() in setup_select_timeout()
unnecessary, this is implicitly done in
event_add_to_select_args() from the timed events.
Volker
|
|
|
|
|
|
|
| |
Replace smb_register_idle_event() with event_add_timed(). This fixes winbind
which did not run the idle events to drop ldap connections.
Volker
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the two functions talloc_stackframe() and talloc_tos().
* When a new talloc stackframe is allocated with talloc_stackframe(), then
* the TALLOC_CTX returned with talloc_tos() is reset to that new
* frame. Whenever that stack frame is TALLOC_FREE()'ed, then the reverse
* happens: The previous talloc_tos() is restored.
*
* This API is designed to be robust in the sense that if someone forgets to
* TALLOC_FREE() a stackframe, then the next outer one correctly cleans up and
* resets the talloc_tos().
The original motivation for this patch was to get rid of the
sid_string_static & friends buffers. Explicitly passing talloc context
everywhere clutters code too much for my taste, so an implicit
talloc_tos() is introduced here. Many of these static buffers are
replaced by a single static pointer.
The intended use would thus be that low-level functions can rather
freely push stuff to talloc_tos, the upper layers clean up by freeing
the stackframe. The more of these stackframes are used and correctly
freed the more exact the memory cleanup happens.
This patch removes the main_loop_talloc_ctx, tmp_talloc_ctx and
lp_talloc_ctx (did I forget any?)
So, never do a
tmp_ctx = talloc_init("foo");
anymore, instead, use
tmp_ctx = talloc_stackframe()
:-)
Volker
|
|
|
|
|
|
| |
Ronnie. If a lock timeout expires, we must check we can get the
lock before responding with failure. Volker is writing a torture test.
Jeremy.
|
|
|
|
|
| |
was correct.
Jeremy.
|
| |
|
|
|
|
| |
Jeremy, please check ;-)
|
| |
|
|
|
|
|
|
| |
try to fix the build on irix...
metze
|
| |
|
|
|
|
|
|
| |
use of directory name cache, 100 by default. Will be needed
to turn this off for *BSD systems.
Jeremy.
|
|
|
|
|
|
| |
- use poptPrintUsage() to give the user more info
metze
|
|
|
|
|
|
|
| |
back-port
of the 3.2 sessionsetup code to enable vl's merge to go easier.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
the first
statement will return positively but prefix_cache_hashes would be NULL
|
|
|
|
|
|
|
|
|
|
| |
smbd, nmbd and winbindd can be started with invalid options currently.
The first patch attached would be a possible solution.
It contains an exit if an invalid option has been used. The main problem
is, that existing setups with wrong options or missing arguments in start
scripts will break (which is the right behaviour from my point of view).
metze
|
|
|
|
| |
In this error case we would have used "start" not having it initialized
|
|
|
|
|
|
|
|
|
|
| |
This API will change anyway when moving away from pstrings.
It took so long to fix, because that rename bug I just fixed gave make
test failures that had nothing to do with this one.
I have samba4 tests for both bugs, will check them in when the build
farm has caught up
|
|
|
|
|
| |
This was broken when I changed reply_mv to wrap in a open_file_ntcreate
call, unix_convert on the destination was called twice
|
| |
|
|
|
|
| |
Jeremy.
|
| |
|
|
|
|
| |
part of the string to the caller.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
to ERRDOS, ERRfilexists for NTCreateX and NTTransCreate.
Jeremy.
|
|
|
|
|
| |
to DOS error ERRDOS, ERRfilexists on open calls.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
to DOS error ERRDOS, ERRfilexists on open calls.
Jeremy.
|
| |
|
| |
|
|
|
|
| |
strlcpy does not like a NULL source. Fix a use-after-free.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
----------------------------------------------------------
In rare cases, Samba 3.0.25b shows directory contents at the wrong
position in the file tree when displaying a subdirectory of a DFS link.
The problem occurs whenever Windows XP asks for a DFS referral for a
subdirectory of a DFS link with a trailing backslash.
Windows does not do this very often, but we saw it several times per day
on our central DFS server.
smbd/msdfs.c, dfs_path_lookup() does the following with the requested
path:
- in line 390, the local copy 'localpath' is 'unix_convert'ed; the
trailing backslash is removed inside unix_convert
- in lines 417-20, 'dfspath' (another copy of the requested path) is
mangled another way without removing trailing backslashes
That's why the following loop (lines 435-461) that is meant to
synchronously cut off the last path component from both strings until it
comes to a DFS link, does not handle both strings the same. When the
original path ended with a backslash, 'canon_dfspath' has always one
component more than 'localpath', so that *consumedcntp gets too big in
line 446. This value is reported to the client.
----------------------------------------------------------
Bug #4860.
Jeremy.
|
|
|
|
|
|
|
| |
Panisset <panisset@A52.com>.
Awaiting confirmation from reporter.
Jeremy.
|
|
|
|
|
|
|
|
|
| |
add a file_id_create() hook into the VFS layer
it's needed for some cluster filesystems to
overload this function.
metze
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
the claim_connection() must come after the sockets are open
metze
|
| |
|
| |
|
| |
|