| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Upped MAX_OPEN_DIRECTORIES to 256.
Ensured new directory handles are only allocated between 255 - MAX.
Stopped re-open of a directory about to be closed.
Log a message if a directory is to be closed and the bitmap
is not set.
Jeremy.
|
|
|
|
|
|
|
|
|
| |
with a completely bogus FID (0xFFFF). This was causing the new
2.0 code to crash by indirecting through a null pointer, as
the old debug code wanted to print this fid value, and was
using fsp->fnum to do it - erroneously assuming that fsp
was non-null.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
was in seconds. This meant that PDC -> BDC failover took so long it essentiually
didn't happen.
include/client.h: Added explicit comment that cli->timeout should be milliseconds.
include/local.h: Changed LONG_CONNECT_TIMEOUT & SHORT_CONNECT_TIMEOUT to be milliseconds.
lib/smbrun.c: Tidied up fork failure catching.
lib/util_sock.c: Ensured timeout treated as milliseconds.
libsmb/clientgen.c: Added comment.
rpc_server/srv_pipe_hnd.c: Luke's changes.
smbd/chgpasswd.c: Paranoia code for EINTR around sys_waitpid.
Jeremy.
|
|
|
|
|
|
|
|
| |
echo >test.~pa
would create a file called : test.~pa.~pa.~pa.~pa
Jeremy.
|
|
|
|
|
| |
have been done.
Jeremy.
|
|
|
|
|
| |
the non-trans2 call - if you set the return parameters right.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
problem.
printing/print_svid.c: Fix for DG/UX lpstat.
smbd/dfree.c: Added 'max_four_gig' parameter to normalize to 4GB when asked
(used to be the default).
smbd/open.c smbd/reply.c smbd/trans2.c:
Changed to allow a <4GB volume size to be returned on a trans2
qfsinfo level 1 call. NT clients refuse to do the correct call to Samba servers
(Herb recons it's the unicode bit) - this allows even a level 1 to return a
volume size up to 9444732961341243916800 bytes (should be enough for now,
until we get the unicode support added :-).
Jeremy.
|
|
|
|
|
|
|
|
| |
check_mangled_cache was not always restoring the filename correctly
before returning False.
Thanks to Christoph Scheeder <christoph.scheeder@Scheeder.de> for tracking
this down.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
Fix bugs in loadparm.c and move location of
#ifdef WITH_SSL to a place that makes more sense!
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
Outinen <Panu.Outinen@vertex.fi>
Jeremy.
|
|
|
|
|
| |
Code <from Elmar.Daegele@bln.siemens.de>.
Jeremy.
|
|
|
|
|
|
| |
setfileinfo call with allocation set to zero instead of SMB_SET_FILE_END_OF_FILE_INFO
to truncate a file.
Jeremy.
|
|
|
|
|
|
| |
directory handle. WinCenter (multi-user NT system) is doing
this. This code still needs testing....
Jeremy.
|
|
|
|
|
|
| |
cause smbd to crash. As we're only removing entries from a queue then
remove the AS_USER flag for reply_ntcancel.
Jeremy.
|
|
|
|
|
| |
smbd/password.c: Fixed ACB_DISABLED flag when doing 'update encrypted'.
Jeremy.
|
|
|
|
|
| |
before check for NULL.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
Moved the message so it's printed only in the case where we can't map the lock range.
Jeremy.
|
|
|
|
|
|
| |
allow people to turn it off if it really bugs them and in case we
get it a lot.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
code could have worked, so I'm a little suspicious of the testing that
has been done on it!
|
|
|
|
|
|
| |
smbd/reply.c: Changed "Error" in level 0 debug message about NT bug to "Warning"
as Samba will continue without it.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc2.7.x - this condition is now auto detected and uses the correct flags.
smbd/reply.c: Did more mapping for 64-bit lock requests on 32 bit systems.
smbd/nttrans.c:
smbd/oplock.c: Fixed the MS-Office not noticing files are open problem. This
was a *subtle* problem and now needs testing to ensure the fix is correct.
It's past 8pm, I'm tired and I'm going for a pizza.
Jeremy.
|
|
|
|
|
| |
to be the same as NT (seems to work without it but you never know...).
Jeremy.
|
|
|
|
|
|
| |
if you send this query to a FAT volume. Phew - I'm glad I got this one in
under the wire for 2.0.0.....
Jeremy.
|
|
|
|
|
|
|
|
| |
do too many iterations.
nmbd/nmbd.c: Fixed SIGHUP handling to act the same as smbd.
smbd/reply.c: Added code to map 64-bit lock ranges where possible on 32-bit systems.
smbd/server.c: Fixed comment.
Jeremy.
|
|
|
|
| |
error (smbtorture sends null params)
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
No-one seemed to have noticed it wasn't working (this worries
me....).
ChangeNotify now scans the directory if necessary and uses the
sum of all timestamps and the number of entries as the 'hash'
to determin if anything changed.
Jeremy.
|
|
|
|
|
|
|
|
| |
than it should :-).
SMBsearch now gets directory handles that are 8 bit in the range
1-255 and will close the oldest non-expect-close handle if the table gets full.
findfirst gets 16 bit directory handles starting at 256 and above.
Jeremy.
|
|
|
|
|
|
|
| |
array, leaks are rather more severe :-). This fixes a bug in trans2
findfirst where I forgot to close a directory handle if returning a
'no such file' error. Also fixed a similar case in smbsearch.
Jeremy.
|
|
|
|
|
|
|
| |
time calculations, not by incrementing a counter.
The select timeout is set to the old (lower) value of 10 seconds if there
are blocking locks pending, and to the newer 60 second value if not.
Jeremy.
|
|
|
|
|
| |
of them.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
| |
beta5. The problem was that I had increased the select timeout so much
that the client was sending echo requests as a sort of keepalive.
As smbd only did timeout processing on select timeout then not
much timeout processing was being done :-).
I've fixed this by moving the timeout code to a function and
calling it every time we get an SMBecho request (we must have
been idle at that point).
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
| |
array for directory handles. This tidied up the code a *lot*.
Plus it means I've fixed the bug in PR#10058, which was due to an
NT app that wanted to simultaneously open >256 directory handles.
Jeremy.
|
|
|
|
|
|
|
|
|
| |
--with-mmap code.
lib/time.c: Changed %T to %H:%M:%S for systems that don't have %T.
locking/locking_slow.c: Re-added FTRUNCATE_NEEDS_ROOT code - now to test for it...
smbd/quotas.c: Fixed IRIX quota compile.
Jeremy.
|
|
|
|
|
| |
zeroed out before use.
Jeremy.
|
|
|
|
|
|
| |
All others - added checks for the compiler understanding volatile and
the system having sig_atomic_t. Changed sighup code to use this.
Jeremy.
|
|
|
|
|
|
|
|
| |
Discovered by Menny Hamburger at Mainsoft. This is a core+
protocol request that predates the read/write lock concept.
Thus instead of asking for a read lock here we need to ask
for a write lock.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
smbd/chgpasswd.c.
smbd/chgpasswd.c
smbd/open.c: Ensure that we replace SIGCLD handler with CatchChildLeaveStatus()
*before* we expect to reap a child status - and reset it to CatchChild()
after we've done the sys_waitpid(). The original CatchChild() code
would eat the status code from the zombie in the signal handler, meaning
that the sys_waitpid() calls in check_access_allowed_for_current_user()
and chgpasswd would never return a status.
smbd/open.c:
smbd/reply.c:
smbd/close.c: Check error return on close() calls - ensure a valid error return
is sent back to the client. This catches the "file truncated"
bug when a user has run out of quota (or space) and the ENOSPC
error is returned on the *close()* call, not the write() (eg. on
an nfs mounted drive).
smbd/fileio.c: Added check for ESPIPE on sys_lseek() in file_seek() to allow
people to use Windows clients to communicate with UNIX fifo's
(like they could in 1.9.18).
Jeremy.
|
|
|
|
|
|
| |
(with a filename of log123.abcd, a dir command of
dir l*.???.?.?.?.?.? should find the file, as it does on NT).
Jeremy.
|
|
|
|
|
|
|
| |
wildcards against both long and short filenames in a trans2 wildcard
match. This fix gets us closer to NT compatibility (still not entirely
there yet.... one more issue I know about to fix....).
Jeremy.
|
|
|
|
|
|
| |
smbd/password.c: Set debug loglevel of disabled account to 1 (I was bitten by
this recently).
Jeremy.
|
|
|
|
|
|
|
|
|
|
| |
Changed privilage to privilege.
Also added set_real_uid() call to lib/util_sec.c.
Removed last set[re]uid calls from quotas.c - all such calls now live only
in lib/util_sec.c.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All setuid code now resides in the one module lib/util_sec.c.
The interfaces this module exports are :
void gain_root_privilage(void); - Set real/eff/saved uid's to 0.
void gain_root_group_privilage(void); - Set real/eff/saved gid's to 0.
int set_effective_uid(uid_t uid); - Set eff uid *only* to given value.
int set_effective_gid(gid_t gid); - Set eff gid *only* to given value.
BOOL become_user_permanently(uid_t uid, gid_t gid); - Set real/eff/saved uid's and gid's
to uid and gid permanently - with no way back to root.
Most of the quota code now uses these calls (except for a few
special cases).
smbd/chgpasswd.c: Ensured the dochild exits in the fork()'d child.
libsmb/nmblib.c: Fix from Jasper for memory leak.
Jeremy.
|
|
|
|
|
| |
Added strerror print for initgroups fail.
Jeremy.
|