| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
configure.in:
include/config.h.in:
include/profile.h:
smbd/vfs-wrap.c:
smbd/vfs.c:
Added fchmod and fchown to VFS (sorry Gerald - but we needed them anyway).
smbd/dosmode.c:
smbd/files.c:
printing/printfsp.c:
smbd/close.c:
smbd/open.c:
Fixed "dos filemode" correctly so there are no race conditions. Forces test
of open of file O_WRONLY before allowing fchmod as root. Afterwards, calls
standard close function that preserves POSIX locks due to POSIX-me-harder
braindamage. :-). Andrew please review this code.
Jeremy.
|
|
|
|
|
| |
to the places where [f]chmod_acl is called instead.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will probably break 2.2 for a while.
Do *NOT* checkout unless you like core dumps.
This is the first merge of the TNG SAMR code into 2.2.
It will eventually give us a wonderful PDC, but maybe painful
in the short term. It had to be done however, and this touches
almost every file (mostly just removing the OLD_NT_DOMAIN) stuff.
I removed some SAMR functionality from rpcclient that would
no longer compile.
Also changed fstring to 256 bytes to better match an NT pathname.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
smbd/vfs-wrap.c:
smbd/vfs.c: Added fchmod_acl and chmod_acl.
lib/substitute.c:
smbd/lanman.c:
smbd/open.c:
smbd/process.c:
smbd/reply.c:
smbd/service.c: Removed sessetup_user variable. Added current_user_info struct
which conatins domain info etc. Added '%D' for client domain parameter.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
| |
Also, fix etags/ctags rules to work when srcdir != builddir
- updated configure
- compiler warning fixes from APPLIANCE_HEAD
(source/lib/util_sec.c source/smbd/vfs-wrap.c)
- tdb_chainlock() no longer returns a value.
(source/locking/locking.c source/tdb/tdbutil.c source/include/proto.h)
|
|
|
|
|
|
|
|
|
| |
a byte range lock (write lock only, but Win2k breaks on read lock also so I
do the same) - if you think about why, this is obvious. Also fixed our client
code to do level II oplocks, if requested, and fixed the code where we would
assume the client wanted level II if it advertised itself as being level II
capable - it may not want that.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
smbd/vfs-wrap.c: wrong parameters for disconnet.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
smb.h move FLUSH_REASONS to profile.h now that it is included by all
profile.h add FLUSH_REASONS, add external declarations for
profile_starttime, profile_endtime, do_profile_flag which
are defined in profile/profile.c Modify PROFILE macros
profile.c always include this function. It is still called under an
#ifdef WITH_PROFILE but we need the above variables so we
might as well include the function as well.
fileio.c use new PROFILE macros to make code cleaner looking
reply.c fix a typo in one START_PROFILE call
statcache.c use new PROFILE macros to make code cleaner looking
vfs_wrap.c use new PROFILE macros to make code cleaner looking added
time profiling to each call.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a conn struct depending on the call.
We need this to have a clean NT ACL call interface.
This will break any existing VFS libraries (that's why this is pre-release
code).
In addition - added Herb's WITH_PROFILE changes - Herb - please examine
the changes I've made to the smbd/reply.c code you added. The original
code was very ugly and I have replaced it with a
START_PROFILE(x)/END_PROFILE(x) pair using the preprocessor.
Please check this compiles ok with the --with-profile switch.
Jeremy.
|
|
|
|
|
| |
above this layer.
Jeremy.
|
|
|
|
| |
still more to come but I wanted to commit so it didn't get lost
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
| |
errors etc.) into locking/posix.c, where it is needed. fcntl_lock in lib/util.c
is now very small and clean.
Added (*lock) op to vfs layer.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new open mechanism Andrew & I discussed.
config.sub:
configure: Included the QNX patch.
include/vfs.h:
smbd/vfs-wrap.c:
smbd/vfs.c: Added ftruncate vfs call (needed).
Note that we will also need locking calls in the vfs (to be added).
lib/util_unistr.c:
nmbd/nmbd_processlogon.c: Fix for NT domain logons causing nmbd to core dump.
Also fix for sidsize DOS bug.
locking/locking.c: Check value of ret before using it for memdup.
printing/printing.c: Convert print_fsp_open to return an allocated fsp.
rpc_server/srv_lsa.c: Fix for NT domain logons.
I have removed all use of lp_share_modes() from the code (although I
left the parameter in the table for backwards compatibility). It no longer makes
sense for this to exist.
smbd/close.c: Removed lp_share_modes().
smbd/fileio.c: Fixed parameters to unlock_share_entry call in panic code.
smbd/files.c: Correctly set the unix_ERR_code to ERRnofids on fsp allocation fail.
smbd/nttrans.c:
smbd/reply.c:
smbd/trans2.c: Changed all occurrences of open_file_shared/open_directory/
open_file_stat to return an fsp from the call.
smbd/open.c: Changed all occurrences of open_file_shared/open_directory/
open_file_stat to return an fsp from the call.
In addition I have fixed a long standing race condition in the deny mode
processing w.r.t. two smbd's creating a file. Andrew, please note that
your original idea of using open with O_EXCL in this case would not work
(I went over the races very carefully) and so we must re-check deny modes
*after* the open() call returns. This is because there is a race between
the open with O_EXCL and the lock of the share mode entry. Imagine the
case where the first smbd does the open with O_EXCL and a deny mode of DENY_ALL,
but is pre-empted before it locks the share modes and creates the deny
mode entry for DENY_ALL. A second smbd could then come in with O_RDONLY
and a deny mode of DENY_NONE and the two opens would be allowed.
The *only* way to fix this race is to lock the share modes after the
open and then do the deny mode checks *after* this lock in the case
where the file did not originally exist.
This code will need extensive testing but seems to initially work.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
accessing files on local disk.
|
|
|
|
| |
that were in the head branch but weren't in SAMBA_2_0
|
|
|
|
|
|
| |
Added checks to panic if VFS functions are passed NULL pointers. This
may expose some bugs that have been lurking about. Checks can be
easily removed later.
|
|
|
|
|
|
|
| |
possibilty of NULL function pointers being called.
Changed arguments to fsync() function to break dependency on
connection_struct.
|
| |
|
| |
|
|
|
|
| |
void!
|
|
tridge telling me why this needed to be done but I have since
forgotten. (-:
|