| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
create_file calls unix_convert internally, so modifies fname. So we can't use
"fname" after create_file has returned. Use fsp->fsp_name instead.
Found during a lengthy debugging session with Karolin testing the xattr_tdb
module...
|
|
|
|
| |
Thanks to Corinna Vinschen
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Jan 22 13:31, Volker Lendecke wrote:
> On Tue, Jan 22, 2008 at 11:33:17AM +0100, Corinna Vinschen wrote:
> > Right. I changed samba_gitcommitdate from time_t to NTTIME and shortened
> > samba_version_string to 28 bytes. New patch below.
>
> Ok, pushed with some modifications. You might want to review
> that.
Reviewed and tested. Looks good, thank you!
Below you'll find a tiny patch to add the git commit date. It seems
I simply missed its existence in version.h :( Tested on Windows XP.
Thanks,
Corinna
* source/smbd/trans2.c (samba_extended_info_version): Fill out
samba_gitcommitdate member with GIT commit timestamp.
|
|
|
|
|
| |
This is right now only used there, and in version.c it gave linker errors
because some binaries (e.g. smbmnt) don't link in time.o
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Jan 21 16:18, Danilo Almeida wrote:
> Corina wrote:
>
> > + time_t samba_gitcommitdate;
>
> And:
>
> > + SIVAL(pdata,28,extended_info.samba_gitcommitdate);
> > + memcpy(pdata+32,extended_info.samba_version_string,32);
>
> Note that you are dropping bits on a system w/64-bit time_t, and that this has the 2038 problem.
Right. I changed samba_gitcommitdate from time_t to NTTIME and shortened
samba_version_string to 28 bytes. New patch below.
Thanks,
Corinna
|
| |
|
|
|
|
| |
Found by the IBM checker
|
|
|
|
| |
gcolley was right, my nt4 does not blue screen with it
|
|
|
|
|
|
| |
Based on jpeach's work, modified the streaminfo prototype
Make use of it in trans2.c together with marshall_stream_info()
|
|
|
|
| |
Refactor get_ea_list_from_file to use that.
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
I did not test it, but it should not affect cifsfs, there are special posix
calls that also return the stat information unfiltered.
|
|
|
|
|
|
|
|
|
|
|
|
| |
handle FS capabilities.
As discussed with Volker, it is better to calculate FS capabilities at
connection time. We already do this with help of VFS statvfs() call
which allows to fill-in system-specific attributes including FS
capabilities. So just re-use it if you want to represent additional
capabilities in your modules. The only caution is that you need to
call underlying statvfs() call to actually get system-specific
capabilities (and other fields) added. Then add module-specific ones.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
operations to VFS
Offline files support and remote storage are for allowing communication with
backup and archiving tools that mark files moved to a tape library as offline.
We translate this info into corresponding CIFS offline file attribute and
mark an exported volume as remote storage.
Async I/O force is to allow selective redirection of I/O operations to asynchronous
processing in case it is viable at VFS module discretion. It is needed for
proper handling of offline files as performing regular I/O on offline file will
block smbd.
Signed-off-by: Alexander Bokovoy <ab@samba.org>
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Michael
|
|
|
|
| |
Michael
|
|
|
|
| |
Michael
|
|
|
|
| |
Michael
|
|
|
|
| |
Michael
|
|
|
|
| |
Michael
|
|
|
|
|
|
| |
an extra parameter. This cleans up quite a few places
we were passing it around without needing it.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
with Volker. Mostly making sure we have data on the incoming
packet type, not stored in the smb header.
Jeremy.
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
sid_size did the same as ndr_size_dom_sid
|
|
|
|
|
| |
is mandatory or signing is on.
Jeremy.
|
|
|
|
|
|
|
|
| |
on a share (or global) and have the server reply with
ACCESS_DENIED for all non-encrypted traffic (except
that used to query encryption requirements and set
encryption state).
Jeremy.
|
|
|
|
|
|
| |
Currently if set required this is not enforced. I'll be adding
that soon.
Jeremy.
|
|
|
|
|
| |
our reported caps.
Jeremy.
|
|
|
|
|
| |
negotiation works.
Jeremy.
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
| |
|
|
|
|
|
| |
it with accessor functions. "One global or pstring a day...." :-).
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
message accordingly. Apart from not supporting create time we
now pass the S4 RAW-NOTIFY torture.
Jeremy.
|
|
|
|
|
|
|
| |
False instead of NULL. Fix more of the notifications to
be correct for Samba4 RAW-NOTIFY torture (we had missed
one when calling set_ea_dos_attribute().
Jeremy.
|
|
|
|
|
|
|
|
| |
capability for large UNIX write if not signing and
recvfile set. Cope with large UNIX write length on
incoming processing. Stevef - we can now test 1-16Mb
writes from CIFFS.
Jeremy.
|
|
|
|
|
|
|
| |
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Found by Metze's code review (thanks Metze !).
Jeremy.
|
|
|
|
|
| |
to unix_convert().
Jeremy.
|
|
|
|
|
|
|
|
| |
the main server code paths. We should now be able to cope with
paths up to PATH_MAX length now.
Final job will be to add the TALLOC_CTX * parameter to
unix_convert to make it explicit (for Volker).
Jeremy.
|