| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
file. This is a regression that was damaged by other code.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
|
| |
level 2 and a request for open with no oplock is received then the
smbd should send *synchronous* break messages, not asynchronous,
otherwise it spins very rapidly, releasing the lock, sending the
'break to none' messages and then re-acquiring the lock before
any other process has a chance to get the lock and remove it's own
oplock (at least on linux).
Jeremy.
|
|
|
|
|
| |
on work by <steve@griffin.sio2.nl>.
Jeremy.
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
when opening truncate with current SYSTEM|HIDDEN -> NONE. It's fine to
truncate on open with current NONE -> SYSTEM | HIDDEN.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
| |
This is not 100% the same as what SuSE shipped in their Samba, there is
a crash bug fix, a race condition fix, and a few logic changes I'd like to
discuss with Andreas. Added Andreas to (C) notices for posix_acls.c
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
truncate.
Jeremy.
|
|
|
|
|
| |
are mapping system or hidden.
Jeremy.
|
| |
|
|
|
|
| |
Andrew Bartlett
|
|
|
|
|
| |
to be printed, it just means file not found.
Jeremy.
|
|
|
|
|
| |
what we do is map to the authenticated user when the sid is unmappable
and dos filemodes are enabled
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
cases for rename and unlink. Had to add desired_access into the share mode record.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
| |
bugs with opening and renaming mp3 files, also the word rename
problems that people have had for a while.
Needs a make clean :-) make.
Also added JohnR's printing fix.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
Based on code donated by Olaf Frączyk <olaf@cbk.poznan.pl>. Further commit
will change to sending via vfs interface.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
|
| |
The hack passes the true ntcreate desired_access down to open_file_shared1()
from the ntcreatex function. This is used to determine if share modes
should be used in denying this open.
This hack will become unnecessary when we redo open.c to use the proper
NTCreateX semantics rather than trying to jam the ntcreate semantics into
openX semantics.
|
| |
|
|
|
|
| |
Changed "SMB/Netbios" to "SMB/CIFS" in file header.
|
|
|
|
|
| |
case.
Jeremy.
|
|
|
|
| |
oplocks and really shouldn't be used
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
created the file or not.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
being set. Also prevent an open on a file on a readonly share from
setting delete on close.
Jeremy.
|
|
|
|
|
| |
user demand (don't talk to me about removing parameters.... :-).
Jeremy.
|
|
|
|
|
| |
in samba-technical for explaination.
Jeremy.
|
|
|
|
|
| |
smbd/open.c: Fix "delete on close" for directories.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
in a tdb.
Jeremy.
|
| |
|
|
|
|
|
| |
Stops spurious profile creation messages.
Jeremy.
|
| |
|
|
|
|
| |
thanks to Andreas Moroder for spotting these two.
|
|
|
|
| |
breakfast, but at least you can follow the indents
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
major changes include:
- added NSTATUS type
- added automatic mapping between dos and nt error codes
- changed all ERROR() calls to ERROR_DOS() and many to ERROR_NT()
these calls auto-translate to the client error code system
- got rid of the cached error code and the writebmpx code
We eventually will need to also:
- get rid of BOOL, so we don't lose error info
- replace all ERROR_DOS() calls with ERROR_NT() calls
but that is too much for one night
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
Don't delete a share mode that failed to remove the oplock (doh!),
just set the oplock entry to zero....
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
link from Seattle is having problems.
I've added 3 things here to work on the fcntl spin
problem.
1). Check *all* tdb return codes... :-).
2). If we're asking ourselves to break an oplock, and we can't
find a fsp pointer that matches the entry, this is a *logic bug*
and we should abort and panic so someone with gdb can pick up
the pieces.
3). After we've broken an oplock, ensure that the entry itself
has been removed, and if not remove it ourselves. This should
not be neccessary in a correctly working environmen,t, but will
provide an added layer of robustness in error situations.
4). I hate german keyboards :-) :-).
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
break code path that was invalid (ie. we were assuming
we could infer a non-levelII oplock when such an oplock
was detected - this may no longer be valid once we've
processed the break process dealing with the break will
change the state of it anyway.
This prevents the state where we get the following packet
trace :
client server
NTcreate ->
<- NTcreate resp
NTcreate ->
<- break to level II
ok - broken ->
<- break to none
Thanks to Alan Romeril for providing the trace that allowed
me to track this down.
Jeremy.
|
|
|
|
| |
Jeremy.
|