| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Some of the bits generate INVALID_PARAMETER and some bits
are ignored when they come from a client, that's why we need
to use bits from the ignored range for our internal usage.
metze
|
|
|
|
|
|
| |
then don't allow create_file() to call down to
create_file_unixpath() with a stream name.
Jeremy.
|
| |
|
|
|
|
| |
No functional change, this is a preparation for more current_user ref removal
|
|
|
|
|
| |
current_user_info was "only" used in a debug msg, and current_user.ut.uid is
also available via conn->server_info
|
|
|
|
|
| |
The current vuid is not only available there, it is also in the current
smb_request structure.
|
| |
|
|
|
|
|
|
|
| |
being (correctly) used in the can_read/can_write checks for hide unreadable/unwritable
and this is more properly done using the functions in smbd/file_access.c.
Preparing to do NT access checks on all file access.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
Now all those redundant fd's have vanished from the VFS API.
Michael
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This hides the pending close fds from the outside. Call order
of SMB_VFS_CLOSE is reversed. Originally, it was:
fd_close -> fd_close_posix -> SMB_VFS_CLOSE -> close
And now it is:
fd_close -> SMB_VFS_CLOSE -> fd_close_posix -> close
This is in preparation of removing the fd parameter
from the SMB_VFS_CLOSE function. But it is also the right
place for the pending close calls anyways.
Michael
|
|
|
|
|
|
|
|
|
| |
This is needed to implement the strange write time update
logic later. We need to store 2 time timestamps to
distinguish between the time the file system had before
the first client opened the file and a forced timestamp update.
metze
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
SET_STAT_INVALID only sets nlink, not the other fields
We might consider to change SET_STAT_INVALID to always do ZERO_STRUCT
|
|
|
|
|
| |
Found by a "set but never used" warning. Thanks to talloc_tos() this was not
really a bug, but this way the code becomes much clearer.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
new stream code. (1) In smbd/filename, don't split the name at
':' if we know it's a posix path (this should be parameterized....).
(2). When calling posix_mkdir, we get the flag FILE_FLAG_POSIX_SEMANTICS
passed to open_directory(). I know for a posix client lp_posix_pathnames
should be true (which is checked for in is_ntfs_stream_name() but we
have an explicit flag here, so let's use it.
Jeremy.
|
|
|
|
|
|
|
|
|
|
| |
This is the core of the streams support. The main change is that in
files_struct there is now a base_fsp pointer that holds the main file open
while a stream is open. This is necessary to get the rather strange delete
semantics right: You can't delete the main file while a stream is open without
FILE_SHARE_DELETE, and while a stream is open a successful unlink of the main
file leads to DELETE_PENDING for all further access on the main file or any
stream.
|
| |
|
| |
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Reported by the IBM checker
|
|
|
|
| |
Michael
|
|
|
|
| |
Michael
|
|
|
|
| |
Michael
|
|
|
|
| |
Michael
|
|
|
|
| |
Michael
|
|
|
|
| |
Michael
|
|
|
|
| |
Michael
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
with Volker. Mostly making sure we have data on the incoming
packet type, not stored in the smb header.
Jeremy.
|
|
|
|
| |
"struct security_descriptor" has pointers, not integers inside
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a make test failure on Solaris. When creating a new file,
file_set_dosmode() called from open_file_ntcreate calculates a new permission
mask, very likely different from what had been calculated in
open_file_ntcreate. Further down we overwrote the newly calculated value with
SMB_FCHMOD_ACL, ignoring what file_set_dosmode had calculated.
Why did Linux not see this? fchmod_acl on a newly created file without acls
would not retrieve an acl at all, whereas under Solaris acl(2) returns
something even for files with just posix permissions returns something.
Jeremy, given that we have very similar code in 3.0.28 this might also explain
some of the bug reports that people have concerning ACLs on new files.
Volker
P.S: This one took a while to find...
|
|
|
|
|
| |
On systems with nanosecond atime we need to re-stat after messing with the fd,
at least Solaris 10 updates atime after we stat(2)ed the file.
|
|
|
|
| |
Michael
|
|
|
|
| |
Michael
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Other callers (e.g. reply_open_and_X) might have other ideas of the bit
shuffling
|
| |
|
|
|
|
|
| |
This changes them to be a bit closer to open_file_ntcreate and thus provides
less surprises to developers
|
| |
|
| |
|
|
|
|
|
| |
I'm checking in this long sequence of micro-checkins for review, the overall
patch from 3b057022a5 to this is not too large.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
| |
False instead of NULL. Fix more of the notifications to
be correct for Samba4 RAW-NOTIFY torture (we had missed
one when calling set_ea_dos_attribute().
Jeremy.
|