summaryrefslogtreecommitdiffstats
path: root/source/smbd/nttrans.c
Commit message (Collapse)AuthorAgeFilesLines
* r22650: sync up with SMABA_3_0_25 as of svn r22649Gerald Carter2007-05-031-1/+1
|
* r22138: * Sync up with the SAMBA_3_0_25 as of svn r22132.Gerald Carter2007-04-091-12/+91
| | | | | * Set VERSION to 3.0.25rc1 * Update release notes.
* r21889: * Pull from SAMBA-3_0_25 svn r21888Gerald Carter2007-03-201-50/+88
| | | | * Set version to 3.0.25pre2
* r21585: Start syncing the monster that will become 3.0.25pre1Gerald Carter2007-02-281-276/+309
| | | | | | | | Still todo: * release notes * few minor outstanding patches * additional idmap man pages
* r21147: committing changes for 3.0.24Gerald Carter2007-02-051-3/+9
|
* r16418: Pull in more Klocwork fixes (up to r16415)Gerald Carter2006-06-201-0/+1
|
* r16348: * merging changes from SAMBA_3_0 r16346Gerald Carter2006-06-191-22/+26
| | | | * updating release notes to match
* r16104: Set version to 3.0.23rc2Gerald Carter2006-06-081-7/+8
| | | | | Bring release tree up to current 3.0 tree (svn merge -r15845:16103 $SVNURL/branches/SAMBA_3_0)
* r15837: starting sync up for 3.0.23rc1 (in sync with SAMBA_3_0 r15822)Gerald Carter2006-05-231-4/+27
|
* r15030: On a performace hunt... Remove as many extraneousJeremy Allison2006-04-111-2/+2
| | | | | memset's as possible. Jeremy.
* r15018: Merge Volker's ipc/trans2/nttrans changes overJeremy Allison2006-04-101-288/+316
| | | | | | | | into 3.0. Also merge the new POSIX lock code - this is not enabled unless -DDEVELOPER is defined. This doesn't yet map onto underlying system POSIX locks. Updates vfs to allow lock queries. Jeremy.
* r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison2006-03-071-9/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy.
* r13316: Let the carnage begin....Gerald Carter2006-02-031-1/+1
| | | | Sync with trunk as off r13315
* r13293: Rather a big patch I'm afraid, but this should fix bug #3347Jeremy Allison2006-02-021-13/+13
| | | | | | | | by saving the UNIX token used to set a delete on close flag, and using it when doing the delete. libsmbsharemodes.so still needs updating to cope with this change. Samba4 torture tests to follow. Jeremy.
* r12491: End profile fixes from SATOH Fumiyasu <fumiya@samba.gr.jp>.Jeremy Allison2005-12-261-1/+0
| | | | Jeremy.
* r11420: Fix issue pointed out by Dina Fine <dina@exanet.com>. We canJeremy Allison2005-10-311-13/+20
| | | | | | | | only tell at parse time from the wire if an incoming name has wildcards or not. If it's a mangled name and we demangle the demangled name may contain wildcard characters. Ensure these are ignored. Jeremy.
* r10656: BIG merge from trunk. Features not copied overGerald Carter2005-09-301-22/+7
| | | | | | | * \PIPE\unixinfo * winbindd's {group,alias}membership new functions * winbindd's lookupsids() functionality * swat (trunk changes to be reverted as per discussion with Deryck)
* r8219: Merge the new open code from HEAD to 3.0. Haven't yet run the tortureJeremy Allison2005-07-081-415/+339
| | | | | | | | | tests on this as it's very late NY time (just wanted to get this work into the tree). I'll test this over the weekend.... Jerry - in looking at the difference between the two trees there seem to be some printing/ntprinting.c and registry changes we might want to examine to try keep in sync. Jeremy.
* r7842: With the patch I sent Steve yesterday this gives us complete POSIX ↵Jeremy Allison2005-06-221-0/+3
| | | | | | | pathnames. ie. files containing : and \ can be accessed from Linux. Jeremy.
* r6895: Add "acl check permissions" to turn on/off the new behaviour ofJeremy Allison2005-05-181-2/+2
| | | | | | | | checking for write access in a directory before delete. Also controls checking for write access before labeling a file read-only if DOS attributes are not being stored in EA's. Docuementation to follow. Jeremy.
* r6633: Added "check_path_syntax_posix()" in preparation for handlingJeremy Allison2005-05-061-6/+16
| | | | | POSIX pathnames. Not yet used. Jeremy.
* r6307: Ensure info requested bitmask is printed in log when querying ↵Jeremy Allison2005-04-121-1/+2
| | | | | | security descriptors. Jeremy.
* r6269: With help from Marcel Müller <mueller@maazl.de> in tracking down the ↵Jeremy Allison2005-04-101-2/+5
| | | | | | | | bug, fix trans2 and nttrans secondary packet processing. We were being too strict checking the incoming packet (by 1 byte). Jeremy.
* r6263: Get rid of generate_wellknown_sids, they are const static and ↵Volker Lendecke2005-04-091-1/+0
| | | | | | | | initializable statically. Volker
* r6225: get rid of warnings from my compiler about nested externsHerb Lewis2005-04-061-2/+2
|
* r6204: Fix double-free of talloc context.Jeremy Allison2005-04-051-1/+0
| | | | Jeremy.
* r6203: Fix attribute return on creating a directory with nttrans_create.Jeremy Allison2005-04-051-31/+31
| | | | | Fix strange allocation semantics of openX. Jeremy.
* r6172: Tidy up error processing significantly. Remove unix_ERR_XXX global ↵Jeremy Allison2005-04-011-20/+12
| | | | | | nastyness. Jeremy.
* r6160: Ensure allocation size is correctly returned for OpenX. Only set ↵Jeremy Allison2005-04-011-33/+35
| | | | | | | allocation on create/truncate for nttrans. Jeremy.
* r6146: Added OS/2 EA support in trans2_open and trans2_mkdir. Fixed in ↵Jeremy Allison2005-03-311-24/+36
| | | | | | nttrans_create. Jeremy.
* r6141: Fix OS/2 EA's for NTcreate. OpenX and mkdir to follow.Jeremy Allison2005-03-311-4/+90
| | | | Jeremy.
* r6124: Fix for bug #2242 from Tom Lackemann <cessnatomny@yahoo.com> - don'tJeremy Allison2005-03-301-7/+20
| | | | | set SD on an NTtransact create unless we created the file. Jeremy.
* r6014: rather large change set....Gerald Carter2005-03-231-0/+2
| | | | | | | | | | | | | | pulling back all recent rpc changes from trunk into 3.0. I've tested a compile and so don't think I've missed any files. But if so, just mail me and I'll clean backup in a couple of hours. Changes include \winreg, \eventlog, \svcctl, and general parse_misc.c updates. I am planning on bracketing the event code with an #ifdef ENABLE_EVENTLOG until I finish merging Marcin's changes (very soon).
* r5893: Get us to pass some of the Samba4 EA tests. EA_LIST seems to beJeremy Allison2005-03-191-0/+5
| | | | | working - need to valgrind it to be sure. Jeremy.
* r5720: Attempt to fix bug #2382 (Excel shared workbook stops working). AlsoJeremy Allison2005-03-101-1/+1
| | | | | | incorporates part of the fix created by ke_miyata@itg.hitachi.co.jp for bug #2045 (MS-Office behavior of timestamp). Jeremy.
* r5637: Actually test and fix the crash bugs (sorry:-).Jeremy Allison2005-03-031-2/+2
| | | | Jeremy.
* r5636: Re-add the allocation size - parameterized by share asJeremy Allison2005-03-031-4/+4
| | | | | | | "allocation roundup size", by default set as 1Mb. From advice by BlueArc about Windows client behaviour. VC++ people can set this to zero to turn it off. Jeremy.
* r5548: Stop lying about allocation sizes to Windows clients. It was a niceJeremy Allison2005-02-251-4/+4
| | | | | | idea, and aparently improved performance in some circumstances, but it breaks the VC++ compiler :-(. Not cool. Fix bug #2146. Jeremy.
* r5530: Keep the TRANS call up to date with the NTCreateX call.Jeremy Allison2005-02-241-1/+11
| | | | Jeremy.
* r5524: Don't do share mode checks on can_delete if open, the rest of the openJeremy Allison2005-02-231-1/+2
| | | | | code will do this correctly. More for bug #2201. Jeremy.
* r5510: Optimisation to only do can_delete check if client asks for ↵Jeremy Allison2005-02-221-0/+9
| | | | | | | FILE_SHARE_DELETE. Not completely correct but will catch the XP SP2 problem. Jeremy.
* r5497: Fix for DIR1 failures in build farm. It struck me that we Jeremy Allison2005-02-221-2/+6
| | | | | | | only care about failing with ACCESS_DENIED if we can't delete with DELETE access requested. All other errors will be processed as normal. Jeremy.
* r5324: In order to process DELETE_ACCESS correctly and return access deniedJeremy Allison2005-02-111-0/+18
| | | | | | to a WXPSP2 client we must do permission checking in userspace first (this is a race condition but what can you do...). Needed for bugid #2227. Jeremy.
* r5225: fix mem leak and debug messageStefan Metzmacher2005-02-041-1/+2
| | | | metze
* r4088: Get medieval on our ass about malloc.... :-). Take control of all our ↵Jeremy Allison2004-12-071-6/+17
| | | | | | | | | allocation functions so we can funnel through some well known functions. Should help greatly with malloc checking. HEAD patch to follow. Jeremy.
* r4007: Fix bug #2088 - ensure inherit permissions is only applied on a new file,Jeremy Allison2004-11-301-1/+1
| | | | | not an existing one. Jeremy.
* r3946: Fix for bugid #2085 reported by Jason Mader <jason@ncac.gwu.edu>. Use ↵Jeremy Allison2004-11-251-1/+1
| | | | | | | consistent enum type for Protocol extern. Jeremy.
* r3674: Stefan Esser <s.esser@e-matters.de> pointed out that the max dataJeremy Allison2004-11-101-20/+17
| | | | | | | | value is only valid on the initial trans/trans2/nttrans request, so if there are secondary requests we can't read it from them. Read it from the initial request and pass as a parameter for those functions that need it. Jeremy.
* r3666: Generalise fix for trans and nttrans multi-fragment requests.Jeremy Allison2004-11-101-2/+2
| | | | Jeremy
* r2637: Fix the roundup problem (returning 1mb roundup) for non-WindowsJeremy Allison2004-09-251-4/+4
| | | | | clients. This upsets the smb client in the Linux kernel (and Linus :-). Jeremy.
generated by cgit (git 2.34.1) at 2025-09-27 15:23:01 +0000