summaryrefslogtreecommitdiffstats
path: root/source/smbd/msdfs.c
Commit message (Collapse)AuthorAgeFilesLines
* strtok -> strtok_rVolker Lendecke2008-01-231-2/+3
|
* Don't build rpctorture anymore - not maintained. Just remove.Jeremy Allison2007-12-071-1/+1
| | | | | | Remove all vestiges of pstring (except for smbctool as noted in previous commit). Jeremy
* Always define PATH_MAX. Makes code simpler (removesJeremy Allison2007-11-101-21/+41
| | | | | a bunch of #defines). Remove pstring from msdfs.c. Jeremy.
* RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison2007-10-181-28/+28
| | | | | | | bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy.
* r25327: Normalize the path we return for 'msdfs proxy'Volker Lendecke2007-10-101-1/+11
| | | | | | We now accept both \\server\tmp and \server\tmp. There are other places where this might be necessary, but at least the functionality is a bit easier now.
* r25324: Fix "msdfs proxy"Volker Lendecke2007-10-101-1/+1
| | | | Jeremy, please check!
* r25184: Fix some C++ warnings and an uninitialized variableVolker Lendecke2007-10-101-1/+1
|
* r25173: Use the append_buffer version in a loop.Jeremy Allison2007-10-101-2/+2
| | | | Jeremy.
* r25138: More pstring elimination. Add a TALLOC_CTX parameterJeremy Allison2007-10-101-1/+1
| | | | | to unix_convert(). Jeremy.
* r25111: Move to talloced pathnames on most code paths.Jeremy Allison2007-10-101-10/+6
| | | | | | | | | There are now ony 17 pstrings left in reply.c, and these will be easy to remove (and I'll be doing that shortly). Had to fix an interesting bug in pull_ucs2_base_talloc() when a source string is not null terminated :-). Jeremy.
* r25102: Rewrite msdfs code to use talloced filenames. Passes make testJeremy Allison2007-10-101-252/+609
| | | | | | and make valgrindtest. Final step will be to change srvstr_get_path() to return talloced memory in the major codepaths. Jeremy.
* r25009: Large patch discussed with Volker. Move unix_convert to a talloc-basedJeremy Allison2007-10-101-3/+4
| | | | | | interface. More development will come on top of this. Remove the "mangled map" parameter. Jeremy.
* r24253: From Jan Martin <Jan.Martin@rwedea.com>.Jeremy Allison2007-10-101-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ---------------------------------------------------------- In rare cases, Samba 3.0.25b shows directory contents at the wrong position in the file tree when displaying a subdirectory of a DFS link. The problem occurs whenever Windows XP asks for a DFS referral for a subdirectory of a DFS link with a trailing backslash. Windows does not do this very often, but we saw it several times per day on our central DFS server. smbd/msdfs.c, dfs_path_lookup() does the following with the requested path: - in line 390, the local copy 'localpath' is 'unix_convert'ed; the trailing backslash is removed inside unix_convert - in lines 417-20, 'dfspath' (another copy of the requested path) is mangled another way without removing trailing backslashes That's why the following loop (lines 435-461) that is meant to synchronously cut off the last path component from both strings until it comes to a DFS link, does not handle both strings the same. When the original path ended with a backslash, 'canon_dfspath' has always one component more than 'localpath', so that *consumedcntp gets too big in line 446. This value is reported to the client. ---------------------------------------------------------- Bug #4860. Jeremy.
* r23843: Fix bug #4777, reported by Bill Marshall <bmarsh@us.ibm.com>.Jeremy Allison2007-10-101-1/+2
| | | | | | Doing a DFS traverse through a deep link could fail (not using explorer). Jeremy.
* r23784: use the GPLv3 boilerplate as recommended by the FSF and the license textAndrew Tridgell2007-10-101-2/+1
|
* r23779: Change from v2 or later to v3 or later.Jeremy Allison2007-10-101-1/+1
| | | | Jeremy.
* r23522: Save us a kilobyte stack space in a hot code path: I can't see a reasonVolker Lendecke2007-10-101-3/+5
| | | | | | | | | | | | | | why check_path_syntax should not be able to run in-line. The destination pointer either walks side by side with the source pointer or is decremented. So as far as I can see s>=d is true throughout the whole routine. Jeremy, I'm checking this only into 3_0 for now. Please review and ack or directly merge this to 3_0_26. Thanks, Volker
* r22590: Make TALLOC_ARRAY consistent across all uses.Jeremy Allison2007-10-101-4/+8
| | | | | That should be it.... Jeremy.
* r22064: Fix the DFS code to work better with Vista clients. AllowJeremy Allison2007-10-101-32/+36
| | | | | | | | "host msdfs = true" to be set in the [global] section and allow Vista to see shares with "msdfs root = yes" and "msdfs root = no" off the same server. Down to an error message really :-). Jeremy.
* r22001: change prototype of dump_data(), so that it takes unsigned char * now,Stefan Metzmacher2007-10-101-3/+3
| | | | | | | | which matches what samba4 has. also fix all the callers to prevent compiler warnings metze
* r21961: Repair bug introduced by rev. 21960.Jeremy Allison2007-10-101-0/+6
| | | | | We need to do the initial strtok to set up the internal state. Jeremy.
* r21960: Fix bugs 4463,4464,4465,4466. Thanks Jason :-)Volker Lendecke2007-10-101-2/+0
|
* r21942: Hoist by our own petard :-). Older smbclient binariesJeremy Allison2007-10-101-2/+2
| | | | | | | | | | | | | | were not able to connect to the rewritten dfs code as they set the dfs flag bit but then send local paths. Now that our dfs code is a *lot* more robust in detecting this sort of braindamage we can just call into it directly on getting a DFS flag and let the parser sort it out without having to check it's actually connecting to a dfs enabled share (I'm proud of this code :-). Jeremy.
* r21803: Missed part of patch to make self-referrals work.Jeremy Allison2007-10-101-0/+1
| | | | Jeremy.
* r21800: Check-in the DFS rewrite. I am still testing this but itJeremy Allison2007-10-101-370/+459
| | | | | | | | works from smbclient and Windows, and I am promising to support and fix both client and server code moving forward. Still need to test the RPC admin support but I haven't changed that code. Jeremy.
* r21759: Fix the same bug in a more elegant way, strrchr_mJeremy Allison2007-10-101-7/+12
| | | | | is an expensive call.... Jeremy.
* r21758: Fix a very specific dfs bug when passing in POSIXJeremy Allison2007-10-101-3/+6
| | | | | | | pathnames. When we're working out how much we've consumed we need to backtrack by either a '/' or '\\' component, as both are valid separators. Jeremy.
* r21756: An invarient the dfs code depended on for POSIX pathsJeremy Allison2007-10-101-4/+1
| | | | | is no longer true, so fix it. Jeremy.
* r21754: Volker is completely correct. There's no need forJeremy Allison2007-10-101-1/+31
| | | | | | | the RESOLVE_DFSPATH macros and their varients any more. Fix reporting profile bug with all error returns. Jeremy.
* r21251: Okay, after Jeremy has kindly tested this, check it in :-)Volker Lendecke2007-10-101-1/+5
| | | | | | | | | | | Attached find a workaround that works for me. This is not the "correct" fix, to me it seems our DFS referral marshalling is broken. Vista requests level 4, we reply with level 2, and Vista seems not to like that. If we reply with level 3 it seems more happy. Needs more work! Volker
* r21226: Fix bug #4377 (rename of "foo" -> "Foo" fails).Jeremy Allison2007-10-101-11/+29
| | | | | | | This is actually an interesting case as it exposed bad code in our DFS redirect module (that was where the bug was introduced). Caused by our turning on dfsroot be default. Jeremy.
* r20718: Sync up the filename path parsing changes from SAMBA_3_0_24.Jeremy Allison2007-10-101-2/+4
| | | | | | | The only difference between the two trees now w.r.t file serving are the changes to smbd/open.c in this branch I need to review. Jeremy.
* r19963: Add 'registry shares = yes' and registry key security descriptors.Volker Lendecke2007-10-101-0/+1
|
* r18481: Use pidl-generated server side code for dfs.Jelmer Vernooij2007-10-101-5/+6
|
* r17453: Fix msdfs RPC management (this broke with the autogenerated dfs rpcs).Günther Deschner2007-10-101-0/+1
| | | | | | | | | | * Remove "unknown" from dfs_Enum (samba4 dfs IDL updates to follow). * When encountering an unsupported infolevel the rpc server must reply with a dfs_info_0 structure and WERR_OK (observed from w2k3 when talking to nt4). Guenther
* r17376: Fix bug #3985 - ensure in msdfs we check for ourJeremy Allison2007-10-101-14/+8
| | | | | | | netbios aliases. Reported by Björn Jacke <bjoern@j3e.de>. Probably needs to be in 3.0.23b (if Björn approves of the fix). Jeremy.
* r17348: Some C++ warningsVolker Lendecke2007-10-101-2/+2
|
* r16968: The function parse_processed_dfs_path() is dependent on theJeremy Allison2007-10-101-5/+11
| | | | | | | | fact that check_path_syntax() will convert '\\' characters to '/'. When POSIX pathnames have been selected this doesn't happen, so we must look for the unaltered separator of '\\' instead of the modified '/'. Stevef please check this with the CIFSFS MS-DFS code ! Jeremy
* r16945: Sync trunk -> 3.0 for 3.0.24 code. Still needJeremy Allison2007-10-101-1/+7
| | | | | | | to do the upper layer directories but this is what everyone is waiting for.... Jeremy.
* r16797: Add msdfs proxy junctions in the netdfs rpc enumeration.Günther Deschner2007-10-101-0/+1
| | | | Guenther
* r16203: Fix potentially writing one result of strtok beyond the end of alt_path.Volker Lendecke2007-10-101-1/+2
| | | | | | Found by Klocwork, ID 653. Volker
* r15712: BUG 3435: patch from volker to fix 'msdfs root = yes' in [homes]Gerald Carter2007-10-101-1/+4
|
* r14387: Try and fix the coverity issues (#53, #54) with negativeJeremy Allison2007-10-101-4/+4
| | | | | | sink by ensuring all uses of rpcstr_push are consistent with a size_t dest size arg. Jeremy.
* r14336: Try and quieten coverity #53 and #54. Make it obviousJeremy Allison2007-10-101-2/+2
| | | | | we're using -1 as a special size_t case by casting. Jeremy.
* r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison2007-10-101-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy.
* r13316: Let the carnage begin....Gerald Carter2007-10-101-1/+7
| | | | Sync with trunk as off r13315
* r12194: Ensure that when we set a connection path we've canonicalizedJeremy Allison2007-10-101-1/+1
| | | | | | | | | the name (must be abolute - start with /, must not end in /, must have ./ and ../ removed). Of course for realpath resolved paths this won't be the case but for others we need this name to be canonicalized. This name is going into the sharemode db for #3303 so needs to be in a normalized format. Jeremy.
* r11420: Fix issue pointed out by Dina Fine <dina@exanet.com>. We canJeremy Allison2007-10-101-1/+2
| | | | | | | | only tell at parse time from the wire if an incoming name has wildcards or not. If it's a mangled name and we demangle the demangled name may contain wildcard characters. Ensure these are ignored. Jeremy.
* r9545: (Hopefully the last) fixes for DIR -> SMB_STRUCT_DIR.Jeremy Allison2007-10-101-1/+1
| | | | Jeremy.
* r8963: Clean up the horrid "fake conn struct" part of MSDFS.Jeremy Allison2007-10-101-11/+19
| | | | Jeremy.
generated by cgit (git 2.34.1) at 2024-11-08 07:25:49 +0000