| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
others. The reason we couldn't delete was we were erroring out early if requestor was not the owner of the file we wanted to delete, instead of checking if the requestor owned the directory as well. If either of these is true, we must go on and check the ACL. Karolin, this is a must for 3.4.0 and also 3.3.next. I'll update the bug report with patches for 3.4.0 and 3.3.next and ask vl to review. Jeremy.
(cherry picked from commit 966a51da8998cfd15875ba047b7f765c84b914dd)
|
| |
|
|
|
| |
Jeremy.
(cherry picked from commit a7efcb3666fe4df778df95449e98970a77369b79)
|
| |
|
|
|
|
|
|
|
|
| |
delete file
This fixes the generic rename/delete problem for 3.3.0 and above.
Fixed slightly differently to discussions, user viewable modified
ACLs are not a good idea :-).
Jeremy.
(cherry picked from commit c5462c8b43435763783185a03029903efe3b0c11)
|
| |
|
|
|
|
|
| |
calculation of SEC_FLAG_MAXIMUM_ALLOWED much easier
for files.
Jeremy.
(cherry picked from commit 82a25d224b63148c4f9d38ae477328b12a5a03a6)
|
| |
|
|
| |
No functional change, this is a preparation for more current_user ref removal
|
| |
|
|
|
|
|
|
|
| |
With at least NFSv4 ACLs around the write permission for the owner is a bogus
check if we can delete a file in a directory. Like in Windows, there are two
ways which can grant us such: First, the DELETE permission on the file itself,
or if that does not help, the DELETE_CHILD permission on the directory. It
might be a bit more code that runs, but essentially we should end up with the
same set of syscalls in the non-acl case.
|
| |
|
|
| |
Michael
|
| |
|
|
|
|
| |
This is a security descriptor level function only.
Michael
|
| |
|
|
| |
conn holds the current user info
|
| |
|
|
|
|
|
| |
being (correctly) used in the can_read/can_write checks for hide unreadable/unwritable
and this is more properly done using the functions in smbd/file_access.c.
Preparing to do NT access checks on all file access.
Jeremy.
|
| |
|
|
|
| |
there as it no longer uses explicit POSIX ACL calls.
Jeremy.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Up to now, get_nt_acl() took a files_struct pointer (fsp) and
a file name. All the underlying functions should need and now
do need (after the previous preparatory work), is a connection_struct
and a file name. The connection_struct is already there in the
vfs_handle passed to the vfs functions. So the files_struct
argument can be eliminated.
This eliminates the need of calling open_file_stat in a couple
of places to produce the fsp needed.
Michael
|
| |
|
|
|
|
|
| |
Calling can_access_file could lead to orphaned open files
when SMB_VFS_GET_NT_ACL returned ENOSYS (not implemented).
Michael
|
| | |
|
| |
|
|
| |
Do directory vs file open before entering open_file_stat
|
|
|
to a new source file of their own.
Michael
|
