| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TNG. Actually, it exists in the main Samba cvs tree in APPLIANCE_TNG
as I found out later :-)
It adds a new parameter: server schannel = yes/auto/no defaulting to
auto.
What does this mean to the user: No requireSignOrSeal registry patch
for XP anymore.
Many thanks for this code to Luke Leighton, Elrond and anybody else I
forgot to mention.
My next thing will be to see if this applies cleanly to 3_0.
Please test and comment!
Volker
|
|
|
|
| |
- Change 2 variable names to avoid conflicts (patch by Stephan Kulow <coolo@kde.org>)
|
|
|
|
|
|
| |
Fix an inconpatible poitner type that caused the IA64 not to build
Andrew Bartlett
|
| |
|
|
|
|
|
|
| |
(for example, query to non-dc)
Andrew Bartlett
|
|
|
|
| |
genparser works fine, and it is a marvelous tool to store objects in tdb :)
|
| |
|
|
|
|
|
|
|
|
|
| |
that changed that the client is monitoring.
* couple of comments abnout how we need to validate driver names
on SetPrinter() and AddPrinter()
* up the debug level on some overly verbose dev mode parsing messages
|
| |
|
|
|
|
|
|
|
|
|
| |
cache the printer_info_2 with the open printer handle.
cache is invalidated on a mod_a_printer() call **on that smbd**.
Yes, this means that the window for admins to step on each other
from different clients just got larger, but since handles a generally
short lived this is probably ok.
|
|
|
|
|
|
|
|
| |
* performance optimization in enumprinterdataex() when keyname is empty
* fix a few typos in comments
* reload services after addprinter_command()
dump registry data in ascii when the key is REG_SZ or REG_MULTI_SZ
|
|
|
|
| |
that are not valid SIDs.
|
|
|
|
|
| |
Needed to move to disk based i/o later.
Jeremy.
|
| |
|
| |
|
|
|
|
|
| |
to lookup what SIDs have a particular privilege (that is how
privileges are stored).
|
|
|
|
| |
what was requested.
|
|
|
|
|
|
| |
use smb signing.
Andrew Bartlett
|
|
|
|
| |
of hardcoding it to 0xffff.
|
|
|
|
|
| |
this now gives us complete remove privileges control in the client
libs, so we are in good shape for starting on the server side.
|
|
|
|
|
|
| |
lsa_add_acct_rights function.
This allows us to add privileges remotely to accounts using rpcclient.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
calls to init_unistr2() in the code and every one of them got the 3rd
argument incorrect, so I thought it best just to remove the argument.
The incorrect usage was caused by callers using strlen() to determine
the length of the string. The 3rd argument to init_unistr2() was
supposed to be the character length, not the byte length of the
string, so for non-english this could come out wrong.
I also removed the bogus 'always allocate at least 256 bytes'
hack. There may be some code that relies on this, but if there is then
the code is broken and needs fixing.
|
|
|
|
|
|
|
|
|
|
|
| |
principal similar to the existing cli_lsa_enum_privsaccount() call,
except that cli_lsa_enum_account_rights() doesn't require a call to
open_account first. There is also the minor matter that
cli_lsa_enum_account_rights() works whereas
cli_lsa_enum_privsaccount() doesn't!
this call can be used to find what privileges an account or group
has. This is a first step towards proper privileges support in Samba.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes Samba compile cleanly with -Wwrite-strings.
- That is, all string literals are marked as 'const'. These strings are
always read only, this just marks them as such for passing to other functions.
What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables). The rest
is just adding a lot of 'const'.
As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).
Andrew Bartlett
|
|
|
|
|
|
|
|
| |
this commit change the structure and code to reflect this
some test revelead I'm right.
some other revelead currently the abort shutdown does not work against my test machine even if it returns successfully ... need investigation
|
|
|
|
|
|
| |
field at all. It seems to be an optional 12 byte structure of some
kind. mkaplan found a situation where the structure was not present at
all (depending on ptr_0)
|
|
|
|
|
| |
named. Ensure we can query them.
Jeremy.
|
|
|
|
|
|
| |
SPOOL_USER_CTR look like they should be transposed. We don't make use
of the user level information (what is it used for??) so I haven't
changed any code, just added a comment.
|
| |
|
|
|
|
|
| |
Found via a post from Arcady Chernyak <Arcady.Chernyak@efi.com>.
Jeremy.
|
|
|
|
|
|
| |
dashes of const. This is a rather large check-in, some things may break.
It does compile though :-).
Jeremy.
|
|
|
|
|
|
|
| |
Also tidied up some of Richard's code (I don't think he uses the compiler
flags -g -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual like
I do :-) :-).
Jeremy.
|
| |
|
| |
|
|
|
|
| |
Volker
|
|
|
|
|
|
|
|
|
| |
offset is zero. Previously we were jumping to the start of the
parse buffer (i.e offset zero) and reading string data until we hit
a terminating NULL.
Test case: in a PRINTER_INFO_0 structure, the servername field may be
NULL when doing an enumprinters with flags = PRINTER_ENUM_LOCAL.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The actual design change is relitivly small however:
It all goes back to jerry's 'BOOL store', added to many of the elements in a
SAM_ACCOUNT. This ensured that smb.conf defaults did not get 'fixed' into
ldap. This was a great win for admins, and this patch follows in the same way.
This patch extends the concept - we don't store values back into LDAP unless
they have been changed. So if we read a value, but don't update it, or we
read a value, find it's not there and use a default, we will not update
ldap with that value. This reduced clutter in our LDAP DB, and makes it
easier to change defaults later on.
Metze's particular problem was that when we 'write back' an unchanged value,
we would clear any muliple values in that feild. Now he can still have his
mulitivalued 'uid' feild, without Samba changing it for *every* other
operation.
This also applies to many other attributes, and helps to eliminate a nasty
race condition. (Time between get and set)
This patch is big, and needs more testing, but metze has tested usrmgr, and
I've fixed some pdbedit bugs, and tested domain joins, so it isn't compleatly
flawed ;-).
The same system will be introduced into the SAM code shortly, but this fixes
bugs that people were coming across in production uses of Samba 3.0/HEAD, hence
it's inclusion here.
Andrew Bartlett
|
| |
|
| |
|
|
|
|
| |
from APP_HEAD
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
| |
better job of working with usrmgr. Previously we were blanking out entires,
and all sort of mischif.
The new patch (which I've now had a chance to test/modify) also takes care not
to expand % values (ie we go \\%L\%U -> \\server\user, we don't want to store
\\server\user back) and to correctly notice 'not set' compared to 'null string'
etc.
Andrew Bartlett
|
|
|
|
| |
Volker
|
|
|
|
| |
spot by Florian Weimer <Weimer@CERT.Uni-Stuttgart.DE>
|
|
|
|
| |
similar format to UNISTR2.
|
|
|
|
|
| |
total entries on an error whereas nt4 must send uninitialised data so
we didn't catch this one before.
|