summaryrefslogtreecommitdiffstats
path: root/source/registry
Commit message (Collapse)AuthorAgeFilesLines
* r22650: sync up with SMABA_3_0_25 as of svn r22649Gerald Carter2007-05-032-8/+32
|
* r21585: Start syncing the monster that will become 3.0.25pre1Gerald Carter2007-02-287-45/+73
| | | | | | | | Still todo: * release notes * few minor outstanding patches * additional idmap man pages
* r17911: Mgeres from SAMBA_3_0_23:Gerald Carter2006-08-291-0/+5
| | | | | | | * DNS SRV fixes * fd leak fix in async dns lookup code (nmbd) * krb5 sesssetup double username map fix * NULL deref fix in reg_objects.c
* r16674: After removing each individual post-3.0.23rc3 change:Gerald Carter2006-06-294-17/+47
| | | | | | | | | | | | | | This pulls is what I considered safe fixes from SAMBA_3_0. This boiled down to either Klocwork fixes or obvious compiler warning fixes. I did not include any changes to fnuction signatures not the version change to the passdb API. Also pulled in the 3 nmbd fixes requested by Jeremy and the wildcard delete fix. This code will sit for a few days in the cooker and then become 3.0.23 if nothing blows up. I don't care how many more compile warning fixes people throw into SAMBA_3_0.
* r16438: sync up to r16433Gerald Carter2006-06-211-1/+5
|
* r16418: Pull in more Klocwork fixes (up to r16415)Gerald Carter2006-06-202-8/+39
|
* r15104: Implement Samba4's tdb_name().Volker Lendecke2006-04-171-1/+1
| | | | Volker
* r14768: Fix potential null deref coverity bugs #255, #256.Jeremy Allison2006-03-291-17/+25
| | | | Jeremy.
* r14766: Fix possible NULL deref. Coverity #254.Jeremy Allison2006-03-291-8/+9
| | | | Jeremy.
* r14247: Fix Coverity bug # 136Volker Lendecke2006-03-121-1/+3
|
* r13978: Here is why it's essential to use SAFE_FREE instead of free.Jeremy Allison2006-03-071-6/+6
| | | | | | | | If we use free(data.dptr) and then the subsequent tdb_open fails in _reg_perfcount_get_counter_data() then data.dptr is left as a non-zero pointer that has been freed. This would cause it to be reused later on. Coverity bug #162. Jeremy.
* r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison2006-03-073-40/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy.
* r12002: patch from marcin to allow for the creation of a File value in the ↵Gerald Carter2005-12-011-0/+8
| | | | eventlog registry keys so that file properties can be displayed
* r11860: BUG 3156: don't use find_service() when explicitly looking for a ↵Gerald Carter2005-11-221-1/+10
| | | | printer as the username map might get in the way
* r11579: syncing up perf counter code cfrom trunkGerald Carter2005-11-082-41/+174
|
* r11227: patch from brian moran to fix typo in eventlog message file registry ↵Gerald Carter2005-10-201-3/+3
| | | | value name
* r11137: Compile with only 2 warnings (I'm still working on that code) on a gcc4Jeremy Allison2005-10-182-3/+3
| | | | | x86_64 box. Jeremy.
* r11136: patches from Brian Moran for eventlogadm utilityGerald Carter2005-10-182-24/+19
|
* r11123: * patches from Brian Moran for creating new eventlogGerald Carter2005-10-172-10/+198
| | | | | | source keys * my patches to get registry utility functions linking with eventlogadm tool
* r11073: safety checks on pointers to prevent crashing when converting ↵Gerald Carter2005-10-141-1/+7
| | | | REG_MULTI_SZ
* r11072: add routines for converting REG_MULTI_SZ to and from char**Gerald Carter2005-10-141-0/+104
|
* r10819: merging a couple of fixes from trunkGerald Carter2005-10-072-6/+82
| | | | | | | * only keep the registry,tdb file open when we have an open key handle * tpot's setup.py fix * removing files that no longer exist in trunk and copying some that were missing in 3.0
* r10781: merging eventlog and svcctl code from trunkGerald Carter2005-10-062-160/+121
|
* r10656: BIG merge from trunk. Features not copied overGerald Carter2005-09-309-297/+1648
| | | | | | | * \PIPE\unixinfo * winbindd's {group,alias}membership new functions * winbindd's lookupsids() functionality * swat (trunk changes to be reverted as per discussion with Deryck)
* r10012: fix build breakage caused by forgotten commit in local treeGerald Carter2005-09-031-1/+1
|
* r9965: Fix some typo'sJelmer Vernooij2005-09-021-4/+4
|
* r9914: key ordering in hash list is case insensitiveGerald Carter2005-09-011-1/+1
|
* r9895: fix typo in registry pathGerald Carter2005-09-011-1/+1
|
* r9894: Add new registry key expected by Windows XP clients.Gerald Carter2005-09-011-9/+15
| | | | | | | | | | | | | | | | HKLM\\SYSTEM\\CurrentControlSet\\Control\\Termininal Server\\DefaultUserConfiguration Apparently this started showing up after the winreg-write support was added in 3.0.20rc1 or so. Also modifed init_registry_data() to always run and add the required keys. Initial values however are only written if they don't already exist. This makes it easier to add new keys without having to rev the tdb version number (which is really unnecessary in this case). Portions of patch reviewed by Thomas Bork on the general samba ml.
* r9739: conver the reg_objects (REGSUBKEY_CTR & REGVAL_CTR) to useGerald Carter2005-08-294-128/+116
| | | | | | | | | | | | | | | | the new talloc() features: Note that the REGSUB_CTR and REGVAL_CTR objects *must* be talloc()'d since the methods use the object pointer as the talloc context for internal private data. There is no longer a regXXX_ctr_intit() and regXXX_ctr_destroy() pair of functions. Simply TALLOC_ZERO_P() and TALLOC_FREE() the object. Also had to convert the printer_info_2->NT_PRINTER_DATA field to be talloc()'d as well. This is just a stop on the road to cleaning up the printer memory management.
* r9657: fix final issue with regf sk_records; profiles now successfully rewritesGerald Carter2005-08-261-6/+12
| | | | Win2k and WinXP user profile security descriptors.
* r9656: fix bug in sk record list with next offsetsGerald Carter2005-08-261-2/+2
|
* r9486: ensure that the registry hash records are sorted by original subkey ↵Gerald Carter2005-08-221-3/+4
| | | | name and not the 4 character hash key
* r9278: Remove unused variable. Bugzilla #2983.Tim Potter2005-08-121-2/+1
|
* r9115: using #define for reg paths rather than typing the stringGerald Carter2005-08-051-4/+10
|
* r9086: * fix invalid read in parse_spoolss when writing a devmode to Gerald Carter2005-08-051-1/+6
| | | | | | | the wire * fix dup_a_regval() when size is 0 * ensure we pass a pstring to unlink_internals (fixes delete_driver code)
* r8607: BUG 2900 more compiler warningsGerald Carter2005-07-191-9/+10
|
* r8606: BUG 2899: fix compiler warning in regfio routineGerald Carter2005-07-191-1/+1
|
* r8604: BUG 2890: fix unitialized variable reported by Jason Mader ↵Gerald Carter2005-07-191-0/+1
| | | | <jason@ncac.gwu.edu>
* r8501: * disable printer handle object cache (was mostly used Gerald Carter2005-07-151-2/+2
| | | | | | | | | | for NT4 clients enumerating printer data on slow CPUs) * fix pinter and secdesc record upgrade to normalize the key (rev'd printer tdb version) * fixed problem that was normalizing the printername name field in general, this should fix the issues upgrading print servers from 3.0.14a to 3.0.20
* r8327: * don't use unitialized variablesGerald Carter2005-07-111-3/+2
|
* r8325: * punt....don't normalize the printer name in the RegCreateKey().Gerald Carter2005-07-111-3/+1
| | | | | Print Migrator now works as long as the addprinter command can handle the name
* r8324: * initial cut at creating printers via the registry APIGerald Carter2005-07-111-5/+40
| | | | Need to add delete_key support
* r8323: * convert RegSetValue() calls immediately beneath the printerGerald Carter2005-07-111-9/+23
| | | | key to PRINTER_INFO_2 fields.
* r8322: * get RegSetValue() working for printer subkey valuesGerald Carter2005-07-111-3/+169
| | | | (not immediate values below the <printer name> key yet.
* r8152: * remove commented out structureGerald Carter2005-07-041-2/+2
| | | | | * use SAMBA_PRINTER_PORT_NAME in registry values for builtin printer port
* r8089: successfully delete printer subkeys via the registry....now for valuesGerald Carter2005-07-031-1/+19
|
* r8066: * had to modify the printer data storage slightly in ntprinters.tdbGerald Carter2005-07-021-19/+60
| | | | | | | | when packing values. It is a compatible change though and will not require a tdb version upgrade * Can successfully create new printer subkeys via winreg that are immediately available via spoolss calls. Still cannot delete keys yet though. That comes next.
* r8064: * add the REG_XXX error codes to the pretty error messagesGerald Carter2005-07-012-41/+72
| | | | | * more work on the store_values() functions for the Printers key * add Control\Print\Monitors key to list for reg_db
* r8061: * mostly cleanup and refactoring for better readabilityGerald Carter2005-07-012-313/+304
| | | | | | | | * move to registry.tdb for port listing (at least via the winreg ops) If no one opposes on the samba list, we'll move to a registry lookup for enumerating ports rather than the 'enumports command'. This means that there is a bit of a disconnect between EnumPorts() and RegEnumKey('hklm\software\microsoft\windows nt\currentversion\ports').