summaryrefslogtreecommitdiffstats
path: root/source/printing
Commit message (Collapse)AuthorAgeFilesLines
...
* r14506: Remove remaining references to a KCM credential cache type.Günther Deschner2007-10-101-4/+0
| | | | Guenther
* r14489: Guard against coverity reversion. #181 is a false positiveJeremy Allison2007-10-101-0/+2
| | | | | but make the intent clearer. Jeremy.
* r14273: Fix coverity bug #202. Memory leak on error path.Jeremy Allison2007-10-101-1/+3
| | | | Jeremy.
* r14221: Fix coverity #76. My previous change wasn't quite enough :-).Jeremy Allison2007-10-101-0/+1
| | | | Jeremy.
* r14184: Coverity fix #56. Ensure we can't deref null.Jeremy Allison2007-10-101-1/+1
| | | | Jeremy.
* r14023: My last bug fix still left a potential null deref.Jeremy Allison2007-10-101-8/+9
| | | | | C- "must try harder" :-). Jeremy.
* r14003: Clarify code that lead to Coverity report #13.Jeremy Allison2007-10-102-13/+16
| | | | | Not a bug, but better to remove false positives. Jeremy.
* r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison2007-10-104-56/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy.
* r13622: Allow to rename machine accounts in a Samba Domain. This still uses theGünther Deschner2007-10-101-2/+4
| | | | | | | "rename user script" to do the rename of the posix machine account (this might be changed later). Fixes #2331. Guenther
* r13547: add earlier checks to deny deleting a printer driver. The previousGerald Carter2007-10-101-0/+5
| | | | | | code relied upon file permissions alone. Now we check that the user is a printer administrator and that the share has not been marked read only for that user.
* r13408: Remove C++ comments (# 3494)Günther Deschner2007-10-101-2/+2
| | | | Guenther
* r13316: Let the carnage begin....Gerald Carter2007-10-102-5/+11
| | | | Sync with trunk as off r13315
* r13293: Rather a big patch I'm afraid, but this should fix bug #3347Jeremy Allison2007-10-103-16/+17
| | | | | | | | by saving the UNIX token used to set a delete on close flag, and using it when doing the delete. libsmbsharemodes.so still needs updating to cope with this change. Samba4 torture tests to follow. Jeremy.
* r12889: BUG 3380: fix crash when changing printer drivers caused by ↵Gerald Carter2007-10-101-0/+2
| | | | accessing a previously freed pointer
* r11855: patch from Aruna Prabakar for checking that the spooler si running ↵Gerald Carter2007-10-101-0/+29
| | | | on HP-UX
* r11420: Fix issue pointed out by Dina Fine <dina@exanet.com>. We canJeremy Allison2007-10-101-5/+5
| | | | | | | | only tell at parse time from the wire if an incoming name has wildcards or not. If it's a mangled name and we demangle the demangled name may contain wildcard characters. Ensure these are ignored. Jeremy.
* r10656: BIG merge from trunk. Features not copied overGerald Carter2007-10-106-63/+132
| | | | | | | * \PIPE\unixinfo * winbindd's {group,alias}membership new functions * winbindd's lookupsids() functionality * swat (trunk changes to be reverted as per discussion with Deryck)
* r10555: a few compile warnings from jason MaderGerald Carter2007-10-101-3/+3
|
* r10554: * BUG 3057: assume x64 drivers are v3 driversGerald Carter2007-10-101-1/+8
| | | | | * BUG 3087: allow smbspool to establisha geust connection using a username with no password
* r10371: Adding iPrint printing backend written by Joel J. Smith @ Novell.Jeremy Allison2007-10-103-0/+1257
| | | | Jeremy.
* r10154: Fix crash bug on security descriptor upgrade (as seen on x86_64).Günther Deschner2007-10-101-1/+2
| | | | Guenther
* r9739: conver the reg_objects (REGSUBKEY_CTR & REGVAL_CTR) to useGerald Carter2007-10-101-351/+145
| | | | | | | | | | | | | | | | the new talloc() features: Note that the REGSUB_CTR and REGVAL_CTR objects *must* be talloc()'d since the methods use the object pointer as the talloc context for internal private data. There is no longer a regXXX_ctr_intit() and regXXX_ctr_destroy() pair of functions. Simply TALLOC_ZERO_P() and TALLOC_FREE() the object. Also had to convert the printer_info_2->NT_PRINTER_DATA field to be talloc()'d as well. This is just a stop on the road to cleaning up the printer memory management.
* r9244: Fix bugs found by Coverity.Jeremy Allison2007-10-101-3/+21
| | | | Jeremy.
* r9086: * fix invalid read in parse_spoolss when writing a devmode toGerald Carter2007-10-101-15/+22
| | | | | | | the wire * fix dup_a_regval() when size is 0 * ensure we pass a pstring to unlink_internals (fixes delete_driver code)
* r8686: Revert %LOGONSERVER%-substitution. The substition is done on the client,Günther Deschner2007-10-101-1/+1
| | | | | | | | | | | not on the server. We now preserve this windows variable (important for vampired setups) and correctly substitute only the "%L"s in strings like: "%LOGONSERVER% %L %lOgOnSeRvEr% %L". Guenther
* r8543: merge volker's nt_printing_init() fix from trunk (r8526)Gerald Carter2007-10-101-1/+6
| | | | but make sure to write the new version to the ntdrivers.tdb.
* r8506: BUG 2853: don't strip out characters like '$' from printer namesGerald Carter2007-10-101-16/+8
| | | | when substituting for the lpq command.
* r8501: * disable printer handle object cache (was mostly usedGerald Carter2007-10-101-66/+174
| | | | | | | | | | for NT4 clients enumerating printer data on slow CPUs) * fix pinter and secdesc record upgrade to normalize the key (rev'd printer tdb version) * fixed problem that was normalizing the printername name field in general, this should fix the issues upgrading print servers from 3.0.14a to 3.0.20
* r8219: Merge the new open code from HEAD to 3.0. Haven't yet run the tortureJeremy Allison2007-10-102-41/+61
| | | | | | | | | tests on this as it's very late NY time (just wanted to get this work into the tree). I'll test this over the weekend.... Jerry - in looking at the difference between the two trees there seem to be some printing/ntprinting.c and registry changes we might want to examine to try keep in sync. Jeremy.
* r8089: successfully delete printer subkeys via the registry....now for valuesGerald Carter2007-10-101-0/+32
|
* r8066: * had to modify the printer data storage slightly in ntprinters.tdbGerald Carter2007-10-101-9/+64
| | | | | | | | when packing values. It is a compatible change though and will not require a tdb version upgrade * Can successfully create new printer subkeys via winreg that are immediately available via spoolss calls. Still cannot delete keys yet though. That comes next.
* r8025: *how* can this code have been around so long andGerald Carter2007-10-101-14/+33
| | | | | | | | | | nver normalized the string used for printer and sec_desc key lookups ????? normalized sharename to lower case before storing/fetching from tdb. Need to look at drivers and forms tdb as well (perhaps).
* r7983: clean up some use of un-initialized variables found by valgrindGerald Carter2007-10-101-10/+5
|
* r7882: Looks like a large patch - but what it actually does is make SambaJeremy Allison2007-10-101-13/+13
| | | | | | safe for using our headers and linking with C++ modules. Stops us from using C++ reserved keywords in our code. Jeremy
* r7829: fix unitialized printer status field that was breaking migration of ↵Gerald Carter2007-10-101-0/+2
| | | | print queues
* r7692: start versioning the registry.tdb file since it can be modified nowGerald Carter2007-10-101-4/+1
|
* r7691: * add .gdbinit to the svn:ignore filesGerald Carter2007-10-101-2/+0
| | | | | | | | | * start adding write support to the Samba registry Flesh out the server implementations of RegCreateKey(), RegSetValue(), RegDeleteKey() and RegDeleteValue() I can create a new key using regedit.exe now but the 'New Key #1' key cannot be deleted yet.
* r7620: when adding a new printer driver, we should copy the filesGerald Carter2007-10-101-40/+22
| | | | | | | | | | (not move) to the W32X86/{2,3}/ directory. Printmig.exe copies the driver files for all drivers to print$/W32X86 and the calls AddPrinterDriver() for each driver. If we move the file, then adding a driver which shares a file with a previous driver will fail. I can now restore drivers in bulk to a Samba 3 server.
* r7614: convert move_driver_to_download_area() to return WERROR in order to ↵Gerald Carter2007-10-101-5/+5
| | | | provide better error messages to clients when a AddPrinterDriver[Ex]() call fails
* r7584: cleanup the default printer security descriptorGerald Carter2007-10-101-32/+29
|
* r7200: Don't use memset, use SET_STAT_INVALID (has the same effect).Jeremy Allison2007-10-101-3/+3
| | | | Jeremy.
* r7041: compile fixes....long day I guessGerald Carter2007-10-101-2/+3
|
* r7038: * upgrade version of nt*tdb files. Have to fixGerald Carter2007-10-101-10/+145
| | | | | | | some issues in the printer security descriptors. Ensure that each printer sd has an oaner and group SID (BUILTIN\Administrators) and that we utilize more than the generic bits assigned in <= 3.0.14a.
* r6890: Refactor printing interface to take offset into job. Fixes bugJeremy Allison2007-10-101-2/+3
| | | | | | where large print jobs can have out-of-order offsets. Bug found by Arcady Chernyak <Arcady.Chernyak@efi.com> Jeremy.
* r6673: Fix the write cache based on some VERY good detective workJeremy Allison2007-10-101-1/+0
| | | | | | from Ingo Kilian <ikilian@web.de>. You must do a make clean after updating this. Jeremy.
* r6595: This is Volkers new-talloc patch. Just got the go-ahead fromJeremy Allison2007-10-101-3/+3
| | | | | Volker to commit. Woo Hoo ! Jeremy.
* r6490: BUG 1998: patch from Olaf Imig <Olaf.Imig@bifab.de>; fix byte ↵Gerald Carter2007-10-101-3/+9
| | | | ordering bug when storing 16-bit RAP print job ids
* r6263: Get rid of generate_wellknown_sids, they are const static and ↵Volker Lendecke2007-10-101-1/+0
| | | | | | | | initializable statically. Volker
* r6225: get rid of warnings from my compiler about nested externsHerb Lewis2007-10-102-2/+3
|
* r5993: compiler warning fixGerald Carter2007-10-101-1/+1
|
generated by cgit (git 2.34.1) at 2024-11-20 02:32:13 +0000