| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
pjob info. Ensure we retrieve more than one job from the storage code.
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have an extra NULL here, which is (if I understand correctly) related
to a optional 'charset conversion' function.
In any case, as this is a variable args length function, the compiler
didn't pick it up.
Would it be possible to change applicance_head (or even HEAD) in such
a way that this extra arg would cause a warning?
Finding this by testing is getting painful...
Andrew Bartlett
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
| |
Apply the job returned limit across all requests for job queues.
Jeremy.
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
| |
was to limit the string to 31 or 32 characters (excluding the null term), so
I've assumed for now that 32 is fine, as this matches current behaviour (well, current behaviour would crash, but anyway...)
Jerry: Can you look at this for me?
Andrew Bartlett
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
| |
cache the printer_info_2 with the open printer handle.
cache is invalidated on a mod_a_printer() call **on that smbd**.
Yes, this means that the window for admins to step on each other
from different clients just got larger, but since handles a generally
short lived this is probably ok.
|
|
|
|
|
| |
jobid is below the UNIX_JOB_START number.
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we look see if a user is in a list, and we try to 'expand' an @group, we
should lookup the user's own list of groups, rather than looking for all the
members of a group.
I'm sure this will fix some nasty performance issues, particularly on large
domains etc. In particular, this avoids contacting winbind at all, if the
group is not a winbind group.
(This caused a deadlock on my winbind-on-PDC setup).
The groups list always includes the user's primary group, as per the
getgrouplist manpage, and my recent changes to our implementation.
Andrew Bartlett
|
|
|
|
|
|
|
| |
* never save a pointer to an automatic variable (they go away)
implement a deep copy for SPOOLSS_NOTIFY_MSG to correct
messages being sent that have junk for strings;
fix in response to changes for CR 1504
|
| |
|
|
|
|
|
|
| |
Is tdb_pack in appliance_head different for some reason?
Andrew Bartlett
|
|
|
|
|
|
| |
error.
Andrew Bartlett
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
| |
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
| |
messages. Stops build-up of large numbers of smbd's waiting to terminate
on large print throughput.
Jeremy.
|
|
|
|
| |
Jeremy.
|
| |
|
|
|
|
|
|
| |
read, and add a static.
Andrew Bartlett
|
|
|
|
|
|
|
|
|
| |
- fix a crash when a second NTLMSSP session tried to free the first
- fix a crash due to some NULL pointers in the Add Printer Wizard (or read
printer code too it appears). As far as I can tell it's just that the
GUID just might not exist.
Andrew Bartlett
|
| |
|
|
|
|
| |
to send notify events; CR 1491
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes Samba compile cleanly with -Wwrite-strings.
- That is, all string literals are marked as 'const'. These strings are
always read only, this just marks them as such for passing to other functions.
What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables). The rest
is just adding a lot of 'const'.
As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).
Andrew Bartlett
|
|
|
|
|
| |
named. Ensure we can query them.
Jeremy.
|
|
|
|
| |
query the directory server every time someone asks
|
|
|
|
|
|
|
|
| |
- Add published attribute to info2, needed for win clients to work properly
- Return proper info on getprinter 7
This means you can now look at the sharing tab of a printer and get correct
info about whether it is published or not, and change it.
|
|
|
|
| |
Jeremy.
|
| |
|
|
|
|
|
|
| |
jobid. This was causing Win9x client "set name" calls to fail.
Still need one cleanup fix to finish.
Jeremy.
|
|
|
|
| |
ones should be published now.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
directory' in printer settings. Currently very little is published, and you cannot unpublish because of a bug in win2k clients.
|
|
|
|
|
|
|
|
| |
* fixing change notify on print server handle
* adding change notify support into smbcontrol for sending comment
changes, etc...
All part of CR 1159/1160
|
| |
|
|
|
|
|
| |
Found via a post from Arcady Chernyak <Arcady.Chernyak@efi.com>.
Jeremy.
|
|
|
|
|
|
| |
dashes of const. This is a rather large check-in, some things may break.
It does compile though :-).
Jeremy.
|
|
|
|
|
|
|
| |
connections tdb
with an snum of -1 and a special printername.
Jeremy.
|
|
|
|
|
| |
when holding a mutex.... :-).
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
| |
Jeremy.
|
|
|
|
|
|
|
| |
Also tidied up some of Richard's code (I don't think he uses the compiler
flags -g -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual like
I do :-) :-).
Jeremy.
|